Re: JDK-8171119: Low-Overhead Heap Profiling

gt;>> thread doing an event callback. >>>> >>>> Thanks for your help, >>>> Jc >>>> >>>> >>>>> 3) event posting >>>>>- when you post the event to JVMTI >>>>>- in JvmtiObjectAllocEvent

Re: JDK-8171119: Low-Overhead Heap Profiling

njdk.java.net <mailto:serviceability-dev@openjdk.java.net>; hotspot-compiler-dev mailto:hotspot-compiler-...@openjdk.java.net>> *Subject:* Re: JDK-8171119: Low-Overhead Heap Profiling Hi all, I've been working on deflaking the tests mostly and the wording in

Re: JDK-8171119: Low-Overhead Heap Profiling

pot-compiler-dev-boun...@openjdk.java.net] *On Behalf Of *JC Beyler > *Sent:* Wednesday, March 28, 2018 11:43 AM > *To:* Erik Österlund > *Cc:* serviceability-dev@openjdk.java.net; hotspot-compiler-dev < > hotspot-compiler-...@openjdk.java.net> > *Subject:* Re: JDK-8171119: Low

RE: JDK-8171119: Low-Overhead Heap Profiling

: serviceability-dev@openjdk.java.net; hotspot-compiler-dev Subject: Re: JDK-8171119: Low-Overhead Heap Profiling Hi all, I've been working on deflaking the tests mostly and the wording in the JVMTI spec. Here is the two incremental webrevs: http://cr.openjdk.java.net/~jcbeyler/8171119/heap_

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi JC, Comments are inlined below. On 2018-02-13 06:18, JC Beyler wrote: Hi Erik, Thanks for your answers, I've now inlined my own answers/comments. I've done a new webrev here: http://cr.openjdk.java.net/~jcbeyler/8171119/webrev.08/

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi JC, Adding Markus Grönlund. On 2018-02-14 01:11, JC Beyler wrote: Hi all, Just to show a bit how to solve the one issue Erik was referring to, consider the following webrev: http://cr.openjdk.java.net/~jcbeyler/8171119/webrev.08a/ and incremental is here: http://cr.openjdk.java.net/~jcbey

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi JC, Sorry for the delayed reply. Inlined answers: On 2018-02-06 00:04, JC Beyler wrote: Hi Erik, (Renaming this to be folded into the newly renamed thread :)) First off, thanks a lot for reviewing the webrev! I appreciate it! I updated the webrev to: http://cr.openjdk.java.net/~jcbeyler/

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi Jc, I've just been browsing this and have a few comments/queries src/hotspot/share/prims/jvmtiHeapTransition.hpp In HeapThreadTransition what are the possible entry states? The primary state is presumably _in_native, but what else is expected? You can't transition from arbitrary states to

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi JC, On 01/30/2018 04:22 AM, JC Beyler wrote: - Collectedheap still needs to call AllocTracer to see if it is to be sampled, I can't hide everything in it without a bigger refactor (want me to try?) Yes we need a bigger refactor to do this nicely. I suggested not doing that now, so just roll

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi Robbin, So I did the changes to move most of the code into the AllocTracer and you can see it incrementally here: http://cr.openjdk.java.net/~jcbeyler/8171119/webrev.04_05/ And the full webrev here: http://cr.openjdk.java.net/~jcbeyler/8171119/webrev.05/ Now the issues I see here: - AllocTrac

Re: JDK-8171119: Low-Overhead Heap Profiling

Hi JC, thanks! I'm happy with current state, looks good! Truncated: On 01/27/2018 05:01 AM, JC Beyler wrote: This is strange but I'm assuming it is because we are not working on the same repo? I used: hg clone http://hg.openjdk.java.net/jdk/hs jdkhs-heap I'll try a new clone on Monday and se