RE: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Markus Grönlund
Hi again,   Trying again, could I please have a couple of reviews for this? Many thanks Markus   From: Markus Grönlund Sent: den 16 juli 2013 17:48 To: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RFR(XS): 8020547 : Event based tracing needs a UNICODE

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Bengt Rutisson
Hi Markus, Looks reasonable. Bengt On 7/17/13 12:25 PM, Markus Grönlund wrote: Hi again, Trying again, could I please have a couple of reviews for this? Many thanks Markus From: Markus Grönlund Sent: den 16 juli 2013 17:48 To: serviceability-dev@openjdk.java.net;

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Erik Gahlin
Looks good! (not a Reviewer) /Erik Markus Grönlund skrev 7/16/13 5:48 PM: Greetings, Kindly asking for reviews for the following change in hsx24: Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547 Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Rickard Bäckman
Looks good to me. /R On Jul 17, 2013, at 12:25 PM, Markus Grönlund wrote: Hi again, Trying again, could I please have a couple of reviews for this? Many thanks Markus From: Markus Grönlund Sent: den 16 juli 2013 17:48 To: serviceability-dev@openjdk.java.net;

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Daniel D. Daugherty
On 7/16/13 9:48 AM, Markus Grönlund wrote: Greetings, Kindly asking for reviews for the following change in hsx24: Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547 Webrev: http://cr.openjdk.java.net/~mgronlun/8020547/webrev01/ http://cr.openjdk.java.net/%7Emgronlun/8020547/webrev01/

Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Karen Kinnear
Markus, Looks good. (Ok, I miss the comment about j.l.Thread :-) ship it! Karen On Jul 16, 2013, at 11:48 AM, Markus Grönlund wrote: Greetings, Kindly asking for reviews for the following change in hsx24: Bugid: http://bugs.sun.com/view_bug.do?bug_id=8020547 Webrev:

RE: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Markus Grönlund
2013 16:07 To: Markus Grönlund Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)   On 7/16/13 9:48 AM, Markus Grönlund wrote: Greetings,   Kindly asking for reviews

RE: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)

2013-07-17 Thread Markus Grönlund
Many thanks for your reviews!   Markus   From: Karen Kinnear Sent: den 17 juli 2013 17:06 To: Markus Grönlund Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR(XS): 8020547 : Event based tracing needs a UNICODE string type (hsx24)   Markus