Re: RFR: 8189102: All tools should support -?, -h and --help

Hi, The CSR for this change is approved now. https://bugs.openjdk.java.net/browse/JDK-8191477 If there aren't any more objections, I will push this. Webrev rebased and with updated 2018 copyright messages: http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.08/ Best regards, Goet

RE: RFR: 8189102: All tools should support -?, -h and --help

net; 'compiler-...@openjdk.java.net' > ; serviceability-dev (serviceability- > d...@openjdk.java.net) > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > Hi, > > Besides my private comments to you, there are 2-3 internal tests > which fail. > &

Re: RFR: 8189102: All tools should support -?, -h and --help

t: Re: RFR: 8189102: All tools should support -?, -h and --help Hi, I looked at some of the components I maintain, and they look good. Wrt. the test: 1. The local variables/fields don't comply with the coding conventions, we have been following in the JDK. 2. Hmm, someone parked a .

RE: RFR: 8189102: All tools should support -?, -h and --help

.@openjdk.java.net>; compiler-...@openjdk.java.net; core-libs- > d...@openjdk.java.net > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > Thumbs up for JShell changes. > > -Robert > > > On Nov 28, 2017, at 3:16 AM, Lindenmaier, Goetz >

Re: RFR: 8189102: All tools should support -?, -h and --help

.x.sriniva...@oracle.com] >> Sent: Montag, 27. November 2017 17:43 >> To: Lindenmaier, Goetz >> Cc: core-libs-...@openjdk.java.net; 'compiler-...@openjdk.java.net' >> ; serviceability-dev (serviceability- >> d...@openjdk.java.net) >> Subject: Re:

RE: RFR: 8189102: All tools should support -?, -h and --help

7; > ; serviceability-dev (serviceability- > d...@openjdk.java.net) > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > Hi, > > I looked at some of the components I maintain, and they look good. > > Wrt. the test: > > 1. The local variables/field

RE: RFR: 8189102: All tools should support -?, -h and --help

Hi Kumar, Thanks for looking at my change! > I looked at some of the components I maintain, and they look good. May I ask which these are? So I can account whether all parts have been reviewed? > 1. The local variables/fields don't comply with the coding conventions, > we have been > fo

Re: RFR: 8189102: All tools should support -?, -h and --help

Hi, I looked at some of the components I maintain, and they look good. Wrt. the test: 1. The local variables/fields don't comply with the coding conventions, we have been following in the JDK. 2. Hmm, someone parked a .ini file in bin directory, later removed, perhaps on windows s

RE: RFR: 8189102: All tools should support -?, -h and --help

serviceability-dev@openjdk.java.net) d...@openjdk.java.net> > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > Hi Goetz > > I would just remove it. > > Thanks > Max > > > On Nov 22, 2017, at 2:53 PM, Lindenmaier, Goetz > wrote:

Re: RFR: 8189102: All tools should support -?, -h and --help

>> Sent: Monday, November 20, 2017 3:49 PM >> To: Lindenmaier, Goetz >> Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; >> serviceability-dev (serviceability-dev@openjdk.java.net) > d...@openjdk.java.net> >> Subject: Re: RFR: 8189102: All tools shoul

RE: RFR: 8189102: All tools should support -?, -h and --help

oracle.com] > Sent: Monday, November 20, 2017 3:49 PM > To: Lindenmaier, Goetz > Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; > serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net> > Subject: Re: RFR: 8189102: All tools should suppor

Re: RFR: 8189102: All tools should support -?, -h and --help

essage > jstatd -?|-h|--help > > >> -Original Message- >> From: Weijun Wang [mailto:weijun.w...@oracle.com] >> Sent: Sonntag, 19. November 2017 01:28 >> To: Lindenmaier, Goetz >> Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; >>

Re: RFR: 8189102: All tools should support -?, -h and --help

On 20/11/2017 13:41, Lindenmaier, Goetz wrote: : The deprecated tools are orbd, wsgen wsimport schemagen Is that correct? Yes, plus xjc, idlj, servertool and tnameserv (the full list is in the draft JEP that I linked to). -Alan

RE: RFR: 8189102: All tools should support -?, -h and --help

] > Sent: Sonntag, 19. November 2017 01:28 > To: Lindenmaier, Goetz > Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; > serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net> > Subject: Re: RFR: 8189102: All tools should support -?, -h an

RE: RFR: 8189102: All tools should support -?, -h and --help

From: Alan Bateman [mailto:alan.bate...@oracle.com] > Sent: Samstag, 18. November 2017 09:42 > To: Lindenmaier, Goetz ; core-libs- > d...@openjdk.java.net; 'compiler-...@openjdk.java.net' d...@openjdk.java.net>; serviceability-dev (serviceability- > d...@openjdk.java.net) >

RE: RFR: 8189102: All tools should support -?, -h and --help

Message- > From: Robert Field [mailto:robert.fi...@oracle.com] > Sent: Freitag, 17. November 2017 20:07 > To: Lindenmaier, Goetz > Cc: core-libs-...@openjdk.java.net; compiler-...@openjdk.java.net; > serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net> &g

RE: RFR: 8189102: All tools should support -?, -h and --help

19:30 > To: Lindenmaier, Goetz ; core-libs- > d...@openjdk.java.net; 'compiler-...@openjdk.java.net' d...@openjdk.java.net>; serviceability-dev (serviceability- > d...@openjdk.java.net) > Subject: Re: RFR: 8189102: All tools should support -?, -h and --help > > Goetz, > &

Re: RFR: 8189102: All tools should support -?, -h and --help

We are already in a hybrid world of old-style and new-style options :-( All the new module-related options added in JDK 9 are "new style", following the guidelines of JEP 293. It does not make sense to add "--" to some of the older tools, that may be going away at some point, and while we may

Re: RFR: 8189102: All tools should support -?, -h and --help

I am OK with all commands supporting --help, but I am not sure if every tool should show it on the help screen if the tools's other options are still using the old single-"-" style. It looks like the tools are half-converted. Is there a timetable to add "--" support to all tools? Thanks Max >

Re: RFR: 8189102: All tools should support -?, -h and --help

On 17/11/2017 11:23, Lindenmaier, Goetz wrote: Hi, please review this change. I also filed a CSR for this: http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8189102 CSR: https://bugs.openjdk.java.net/browse/JDK-8191477 See the we

Re: RFR: 8189102: All tools should support -?, -h and --help

JShell changes — The code change is fine. The help change in the properties file is not consistent with the other items, note:--help-extra, -X Print help on… so this should be: —help, -h, -? Or, if there is a tool-wide standard, then the —help-extra entry should be chang

Re: RFR: 8189102: All tools should support -?, -h and --help

Goetz, I understand why you might want to ensure that a basic set of help options is supported, but I don't understand why that justifies removing older options, like "-help" for many tools. In addition, I notice the CSR says: *Compatibility Risk Description:*