Re: RFR: 8196337 Add commit methods that take all event properties as argument

2018-03-09 Thread Leo Korinth
: RFR: 8196337 Add commit methods that take all event properties as argument Hi, I would be happy for reviews! Thanks, Leo On 31/01/18 11:00, Leo Korinth wrote: Hi, I am adding commit methods that take all event properties as argument. For instant events (without start and stop times) a static

Re: RFR: 8196337 Add commit methods that take all event properties as argument

2018-03-09 Thread Erik Helin
good, thanks for doing this. Sorry for the delay. Cheers Markus -Original Message- From: Leo Korinth Sent: den 13 februari 2018 12:26 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8196337 Add commit methods that take all event properties

Re: RFR: 8196337 Add commit methods that take all event properties as argument

2018-03-09 Thread Leo Korinth
-Original Message- From: Leo Korinth Sent: den 13 februari 2018 12:26 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8196337 Add commit methods that take all event properties as argument Hi, I would be happy for reviews! Thanks, Leo On 31/01

RE: RFR: 8196337 Add commit methods that take all event properties as argument

2018-03-08 Thread Markus Gronlund
Hi Leo, Looks good, thanks for doing this. Sorry for the delay. Cheers Markus -Original Message- From: Leo Korinth Sent: den 13 februari 2018 12:26 To: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8196337 Add commit methods that take all

Re: RFR: 8196337 Add commit methods that take all event properties as argument

2018-02-13 Thread Leo Korinth
Hi, I would be happy for reviews! Thanks, Leo On 31/01/18 11:00, Leo Korinth wrote: Hi, I am adding commit methods that take all event properties as argument. For instant events (without start and stop times) a static commit method is created (taking all properties). For non-instant event