Hi Ralf,
Overall looks good, but I do have a few suggestions and questions:
I think I prefer passing EI_VM_INIT for triggering_ei, but if you prefer
to keep it as is, I suggest a comment to clarify why it might be out of
range.
The help for "oncmd" says "debug triggered by jcmd?". I think yo
Hi Chris,
> I think I prefer passing EI_VM_INIT for triggering_ei, but if you prefer
> to keep it as is, I suggest a comment to clarify why it might be out of
> range.
Actually, I used EI_VM_INIT for the longest time and only changed it recently,
because I thought that code could assume that e
Hi Ralf,
I don't think the comments from Goetz made it to the list. However, with
the current changes it all looks good to me, except there are some
indentation issues. Indent tab stops are should be increments of 2 for
hotspot code. You have a few cases of using 4 in the dcmd files. For the
estion: Do we need a CSR for this?
Best regards
Christoph
> -Original Message-
> From: serviceability-dev On
> Behalf Of Schmelter, Ralf
> Sent: Donnerstag, 6. Dezember 2018 15:54
> To: Chris Plummer ; serviceability-
> d...@openjdk.java.net
> Subject: [CAUTION] RE: RFR
ards,
Ralf Schmelter
-Original Message-
From: Langer, Christoph
Sent: Freitag, 7. Dezember 2018 09:41
To: Schmelter, Ralf ; Chris Plummer
; serviceability-dev@openjdk.java.net
Subject: RE: RFR (M) 8214892: Delayed starting of debugging via jcmd
Hi Ralf,
thanks for doing this change. Ove
e is
> that the jcmd would not return, since the initialize method would be blocked
> until a debugger has been connected.
>
> I've updated the webrev:
> http://cr.openjdk.java.net/~rrich/webrevs/schmelter/8214892/webrev.03/
>
> Best regards,
> Ralf Schmelter
>
>
>
Lindenmaier, Goetz
> Subject: RE: RFR (M) 8214892: Delayed starting of debugging via jcmd
>
> Hi,
>
> @Ralf: Thanks for updating the patch. I'm good with it now 😊 As there are no
> other opinions about the naming of the jdwp agent property, I'm fine with
> "onjcmd"
