Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-27 Thread Daniel Fuchs
. best regards, -- daniel Amit -Original Message- From: Mandy Chung Sent: Tuesday, October 25, 2016 3:24 AM To: Amit Sapre Cc: serviceability-dev; Daniel Fuchs; David Holmes Subject: Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-25 Thread Mandy Chung
year for all modified files. > > Amit > >> -Original Message- >> From: Mandy Chung >> Sent: Tuesday, October 25, 2016 3:24 AM >> To: Amit Sapre >> Cc: serviceability-dev; Daniel Fuchs; David Holmes >> Subject: Re: RFR : JDK-8151099 : >> java.la

RE: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-25 Thread Amit Sapre
> Sent: Tuesday, October 25, 2016 3:24 AM > To: Amit Sapre > Cc: serviceability-dev; Daniel Fuchs; David Holmes > Subject: Re: RFR : JDK-8151099 : > java.lang.management.ManagementFactory.getPlatformMXBeans() should work > even if jdk.management is not present. > > > > On

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-24 Thread Mandy Chung
> On Oct 24, 2016, at 5:49 AM, Amit Sapre wrote: > > Hello, > > I have incorporate review comments and updated changes are available in this > webrev: > Updated Webrev : http://cr.openjdk.java.net/~asapre/webrev/8151099/webrev.01/ > Looks okay to me. sun/management/VMManagementImpl.java 1

RE: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-24 Thread Amit Sapre
David Holmes > Cc: Amit Sapre; serviceability-dev; Daniel Fuchs > Subject: Re: RFR : JDK-8151099 : > java.lang.management.ManagementFactory.getPlatformMXBeans() should work > even if jdk.management is not present. > > > > On Jul 14, 2016, at 8:55 AM, David Holmes > wrot

RE: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-14 Thread Amit Sapre
1099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present. > On Jul 14, 2016, at 8:55 AM, David Holmes wrote: > > On 13/07/2016 9:06 PM, Mandy Chung wrote: >> >>> On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: >&

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread Mandy Chung
> On Jul 14, 2016, at 8:55 AM, David Holmes wrote: > > On 13/07/2016 9:06 PM, Mandy Chung wrote: >> >>> On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: >>> >>> Hello, >>> Please review the fix >>> >>> Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 >>> Webrev : http://cr.openjdk.jav

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread David Holmes
On 13/07/2016 9:06 PM, Mandy Chung wrote: On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: Hello, Please review the fix Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/ Looks okay. You could rename the method to

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-07-13 Thread Mandy Chung
> On Jul 13, 2016, at 6:56 PM, Amit Sapre wrote: > > Hello, > Please review the fix > > Bug ID : https://bugs.openjdk.java.net/browse/JDK-8151099 > Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8151099/webrev.00/ Looks okay. You could rename the method to load_and_initialize_klass_or_