Hi everyone,
this change adds the option to write a hprof heap dump directly gzipped.
Currently this is supported for the GC.heap_dump diagnostic command via the
"-gz" flag.
Since gzip is not particular fast when compressing the data, the actual
compression will be done parallel in a bunch of
Hi Ralf,
- diagnosticCommand.cpp
You can use `DCmdArgument` for -gz option.
If you want to use lesser type (e.g. int, unsigned char), I guess you need to
modify GenDCmdArgument class.
- heapDumper.cpp
_nr_of_threads, _id_to_write, _current in CompressionBackend should be added
`volatile` a
eads by the
compression level.
Best regards,
Ralf Schmelter
-Original Message-
From: Yasumasa Suenaga
Sent: Samstag, 8. Februar 2020 14:46
To: Schmelter, Ralf ; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ral
lter, Ralf ; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
- diagnosticCommand.cpp
You can use `DCmdArgument` for -gz option.
If you want to use lesser type (e.g. int, unsigned char), I guess y
hmelter
-Original Message-
From: Yasumasa Suenaga
Sent: Samstag, 8. Februar 2020 14:46
To: Schmelter, Ralf ; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi Ralf,
- diagnosticCommand.cpp
You can use `
) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
One part of this caught my eye and now I look at the webrev I have some
concerns. Introducing new threads to the VM is not something that should
be done lightly and it has to be done very carefully - I need to look
closer at this
2020 14:46
To: Schmelter, Ralf ; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
- diagnosticCommand.cpp
You can use `DCmdArgument` for -gz option.
If you want to use lesser type (e.g. int, unsigned char), I g
Hi Yasumasa,
I think I've tried too much by using the -gz flag as a boolean plus a int
value. I've decided to use two options instead: -gz as a boolean option to turn
compression on and -gz-level to specify the compression level. E.g.
GC.heap_dump -gz -gz-level=3 test.hprof.gz
Best regards,
Ra
Hi Ralf,
I'd suggest for the option format something like this:
-gz[=level]
where level is an int. The part [=level] is optional.
The level is 0 by default (if it is not set).
Thanks,
Serguei
On 2/11/20 7:35 AM, Schmelter, Ralf wrote:
Hi Yasumasa,
I think I've tried too much by using the -
Ralf,
I see this feature adds a lot of code. In fact, I'm not sure, it is
worth to add this kind of complexity (including new compressing threads)
into the VM implementation. What is a real use case behind it? Could
this compressing be done separately from VM implementation?
Thanks,
Serguei
On 2/11/20 11:41 AM, serguei.spit...@oracle.com wrote:
Hi Ralf,
I'd suggest for the option format something like this:
-gz[=level]
where level is an int. The part [=level] is optional.
The level is 0 by default (if it is not set).
+1!
Thanks,
Serguei
On 2/11/20 7:35 AM, Schmelter, Ral
On 2/11/20 11:49 AM, serguei.spit...@oracle.com wrote:
Ralf,
I see this feature adds a lot of code. In fact, I'm not sure, it is
worth to add this kind of complexity (including new compressing
threads) into the VM implementation. What is a real use case behind
it? Could this compressing be
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi Ralf,
- diagnosticCommand.cpp
You can use `DCmdArgument` for -gz option.
If you want to use lesser type (e.g. int, unsigned char), I guess
you need to modify GenDCmdArgument cla
ks!
Yasumasa (ysuenaga)
Best regards,
Ralf Schmelter
-Original Message-
From: Yasumasa Suenaga
Sent: Samstag, 8. Februar 2020 14:46
To: Schmelter, Ralf ; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
H
Hi Ralf,
I agree with Serguei and Laurence.
+1 to -gz[=level] only.
Yasumasa
On 2020/02/12 0:35, Schmelter, Ralf wrote:
Hi Yasumasa,
I think I've tried too much by using the -gz flag as a boolean plus a int
value. I've decided to use two options instead: -gz as a boolean option to turn
co
t: Dienstag, 11. Februar 2020 08:44
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi again Ralf, :)
A few more comments after taking a closer look at the thread code.
On the surface
an integer seems strange too.
Best regards,
Ralf
-Original Message-
From: serguei.spit...@oracle.com
Sent: Dienstag, 11. Februar 2020 20:42
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write
-
From: serguei.spit...@oracle.com
Sent: Dienstag, 11. Februar 2020 20:49
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Ralf,
I see this feature adds a lot of code. In fac
Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Ralf,
I see this feature adds a lot of code. In fact, I'm not sure, it is
worth to add this kind of complexity (including new compressing threads)
into the VM implementation. What is a real use case behind it? Could
this comp
directly.
Thanks, will do.
Best regards,
Ralf
-Original Message-
From: David Holmes
Sent: Dienstag, 11. Februar 2020 08:44
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi a
; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Ralf,
I see this feature adds a lot of code. In fact, I'm not sure, it is
worth to add this kind of complexity (including new compressing
threads)
in
tag, 11. Februar 2020 20:49
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Ralf,
I see this feature adds a lot of code. In fact, I'm not sure, it is
worth to add thi
They don't accesses
objects, classes or other 'VM objects'.
Best regards,
Ralf
-Original Message-
From: David Holmes
Sent: Donnerstag, 13. Februar 2020 05:28
To: Schmelter, Ralf ; Yasumasa Suenaga
; OpenJDK Serviceability
Cc: yasue...@gmail.com
Subject: Re: RFR(L)
Original Message-
From: Ioi Lam
Sent: Mittwoch, 19. Februar 2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf ;
hotspot-runtime-...@openjdk.java.net runtime
Cc: Laurence Cable ; serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
nsible.
Thanks
- Ioi
Best regards,
Ralf
-Original Message-
From: Ioi Lam
Sent: Mittwoch, 19. Februar 2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf ;
hotspot-runtime-...@openjdk.java.net runtime
Cc: Laurence Cable ; serviceability-dev@openjdk.java.net
Subject: Re: RFR
runtime-...@openjdk.java.net
runtime
Cc: Laurence Cable ;
serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi Ralf,
We are usually pretty picky about adding new features into the JVM. This
seems to be an edge case (where your environment has mo
, 19. Februar 2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf ;
hotspot-runtime-...@openjdk.java.net runtime
Cc: Laurence Cable ; serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
We are usually pretty picky abou
er, Ralf
; hotspot-runtime-...@openjdk.java.net
runtime
Cc: Laurence Cable ;
serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi Ralf,
We are usually pretty picky about adding new features into the JVM.
This
seems to be an e
oi Lam
Sent: Mittwoch, 19. Februar 2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf
; hotspot-runtime-...@openjdk.java.net
runtime
Cc: Laurence Cable ;
serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi Ralf,
We are us
2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf ;
hotspot-runtime-...@openjdk.java.net runtime
Cc: Laurence Cable ; serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
We are usually pretty picky about adding new fea
riginal Message-
From: Ioi Lam
Sent: Mittwoch, 19. Februar 2020 01:16
To: serguei.spit...@oracle.com; Schmelter, Ralf
; hotspot-runtime-...@openjdk.java.net
runtime
Cc: Laurence Cable ;
serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Yasumasa Suenaga
Sent: Donnerstag, 20. Februar 2020 00:59
To: Ioi Lam ; Schmelter, Ralf ;
serguei.spit...@oracle.com; hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi,
Generally
o: Ioi Lam ; Schmelter, Ralf ;
serguei.spit...@oracle.com; hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi,
Generally I agree with Ioi, but I think it is not a problem only for gzip
rstag, 20. Februar 2020 14:21
> To: Yasumasa Suenaga ; Ioi Lam
> ; serguei.spit...@oracle.com; hotspot-runtime-
> d...@openjdk.java.net runtime
> Cc: serviceability-dev@openjdk.java.net
> Subject: [CAUTION] RE: RFR(L) 8237354: Add option to jcmd to write a
> gzipped heap dump
>
> Hi Ya
-Original Message-
From: Yasumasa Suenaga
Sent: Donnerstag, 20. Februar 2020 00:59
To: Ioi Lam ; Schmelter, Ralf
; serguei.spit...@oracle.com; hotspot-runtime-
d...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a
ei.spit...@oracle.com; hotspot-runtime-
d...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: [CAUTION] RE: RFR(L) 8237354: Add option to jcmd to write a
gzipped heap dump
Hi Yasumasa,
I think it would be great if we could redirect larger chunks data to
jcmd.
But you
v On Behalf Of Schmelter, Ralf
Sent: Donnerstag, 20. Februar 2020 14:21
To: Yasumasa Suenaga ; Ioi Lam
; serguei.spit...@oracle.com; hotspot-runtime-
d...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: [CAUTION] RE: RFR(L) 8237354: Add option to jcmd to write a
gzip
Hi Ioi,
> Ralf and Christoph,
>
> I agree that making it easy for the user is important, so dependency on
> an external program like pgzip will be a hassle.
Yes 😊
> How about implementing the compression in a Java program? Will something
> like this be too much of a hassle?
>
> jcmd $PID
Hi Christoph,
This sounds fair. I will remove my objection :-)
Thanks
- Ioi
On 2/25/20 2:21 AM, Langer, Christoph wrote:
Hi Ioi,
Ralf and Christoph,
I agree that making it easy for the user is important, so dependency on
an external program like pgzip will be a hassle.
Yes 😊
How about im
iceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Christoph,
This sounds fair. I will remove my objection :-)
Thanks
- Ioi
020 18:03
To: Langer, Christoph ; Schmelter, Ralf ;
Yasumasa Suenaga ; serguei.spit...@oracle.com;
hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Christoph,
This sounds fair. I will
sumasa Suenaga
; serguei.spit...@oracle.com
; hotspot-runtime-...@openjdk.java.net
runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
On 13/03/2020 9:43 pm, Schmelter, Ralf wrote:
> Hi,
>
> I have up
olmes
Sent: Wednesday, March 18, 2020 6:11 AM
To: Schmelter, Ralf ; Ioi Lam ; Langer, Christoph
; Yasumasa Suenaga ;
serguei.spit...@oracle.com ; hotspot-runtime-...@openjdk.java.net
runtime
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR(L) 8237354: Add option to jcmd to wr
Ralf
Sent: Freitag, 13. März 2020 12:43
To: Ioi Lam ; Langer, Christoph ;
Yasumasa Suenaga ; serguei.spit...@oracle.com;
hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: [CAUTION] RE: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
H
enjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
thanks for providing this enhancement to parallel gzip-compress heap dumps!
I reckon it's safe to say that the coding is sophisticated. It w
2020 10:30
To: Schmelter, Ralf ; Ioi Lam ;
Langer, Christoph ; Yasumasa Suenaga
; serguei.spit...@oracle.com;
hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
thanks for providing
ber, Richard ; Ioi Lam ; Langer,
Christoph ; Yasumasa Suenaga ;
serguei.spit...@oracle.com; hotspot-runtime-...@openjdk.java.net runtime
Cc: serviceability-dev@openjdk.java.net
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Richard,
thanks for the review. I
> Yasumasa Suenaga ;
> serguei.spit...@oracle.com; hotspot-runtime-...@openjdk.java.net
> runtime
> Cc: serviceability-dev@openjdk.java.net
> Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap
> dump
>
> Hi Richard,
>
> thanks for the r
Ralf
> ; Ioi Lam ; Langer, Christoph
> ; Yasumasa Suenaga
> ; serguei.spit...@oracle.com; hotspot-
> runtime-...@openjdk.java.net runtime d...@openjdk.java.net>
> Cc: serviceability-dev@openjdk.java.net
> Subject: Re: RFR(L) 8237354: Add option to jcmd to write a gzipped heap
ot-runtime-...@openjdk.java.net
runtime ; coleen.phillim...@oracle.com
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
while I'm reviewing your change I think extracting the compression coding to an
own file would be a good idea. Maybe you could name it heapDumpCompres
l Message-
From: serviceability-dev On
Behalf Of Schmelter, Ralf
Sent: Montag, 18. Mai 2020 09:23
To: Langer, Christoph
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
runtime
Subject: [CAUTION] RE: RFR(L) 8237354: Add option to jcmd to write a gzipped
heap dump
Hi
c: serviceability-dev@openjdk.java.net ;
hotspot-runtime-...@openjdk.java.net runtime
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
I had a look at your change, webrev.3.
Thanks for contributing this!
Overall, a nicely engineered piece of work. Thus,
ach @test block sperately and evaluate the @requires as expected.
Best regards,
Goetz.
-Original Message-
From: serviceability-dev <mailto:serviceability-dev-boun...@openjdk.java.net>
On Behalf Of Schmelter, Ralf
Sent: Montag, 18. Mai 2020 09:23
To: Langer, Christoph <mailto:chri
hange on
Wednesday.
Best regards,
Ralf
-Original Message-
From: Lindenmaier, Goetz
Sent: Friday, 5 June 2020 18:02
To: Schmelter, Ralf ; Langer, Christoph
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
runtime
Subject: RE: RFR(L) 8237354: Add option to jcmd to
-...@openjdk.java.net
runtime ; David Holmes
; serguei.spit...@oracle.com; Ioi Lam
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Goetz,
> What kind of tests did you run?
The jdk submit repo, the JCK tests (apart from API) and the jtreg tests on
Windows x86/64, MacO
; Langer, Christoph
>
> Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-
> d...@openjdk.java.net runtime ;
> David Holmes ; serguei.spit...@oracle.com; Ioi
> Lam
> Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap
> dump
>
> Hi Goetz,
>
> >
23
To: Schmelter, Ralf
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
runtime ; David Holmes
; serguei.spit...@oracle.com; Ioi Lam
; Lindenmaier, Goetz
Subject: RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump
Hi Ralf,
I finally managed to fully read th
57 matches
Mail list logo
