On 8/31/17 15:08, Daniel D. Daugherty
wrote:
On 8/31/17 4:06 PM, serguei.spit...@oracle.com
wrote:
On 8/31/17 14:51, Daniel D.
Daugherty wrote:
I compared the .2 and .3 patches. Everything
good exce
On 8/31/17 4:06 PM, serguei.spit...@oracle.com wrote:
On 8/31/17 14:51, Daniel D. Daugherty wrote:
I compared the .2 and .3 patches. Everything good except for
this whitespace change that didn't show up in the webrev (IIRC):
- /*
+ /*
* Start the transport loop in a
On 8/31/17 14:51, Daniel D. Daugherty
wrote:
I compared the .2 and .3 patches. Everything good except for
this whitespace change that didn't show up in the webrev (IIRC):
- /*
+ /*
* Start t
On 8/31/17 13:40, Daniel D. Daugherty
wrote:
> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c
> L574: EXIT_ERROR(map2jvmtiError(serror), "JDWP
Transport failed to initialize");
> This is a new exit code path. P
I compared the .2 and .3 patches. Everything good except for
this whitespace change that didn't show up in the webrev (IIRC):
- /*
+ /*
* Start the transport loop in a separate thread
*/
I'll wait to see how we resolve the new "exit code path" issue
before
On 8/31/17 11:54, Daniel D. Daugherty
wrote:
On 8/29/17 2:44 AM, serguei.spit...@oracle.com
wrote:
Hi Dan,
Please, find the updated webrev's here:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/
> src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c
> L574: EXIT_ERROR(map2jvmtiError(serror), "JDWP Transport
failed to initialize");
> This is a new exit code path. Previously the process
> did not exit here. Why the change in behavior?
I think this new exit code
On 8/29/17 2:44 AM, serguei.spit...@oracle.com wrote:
Hi Dan,
Please, find the updated webrev's here:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8061228-jdi-transport.2/
src/jdk.jdwp.agent/share/native/include/jdwpTransport.h
L202: /* 12: SetTransportConfiguration */
Hi Dan,
Please, find the updated webrev's here:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8061228-jdi-transport.2/
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8061228-jdi-transport.2.inc/
I think, I've resolved all y
Hi Dan,
Thank you a lot for review!
On 8/28/17 11:00, Daniel D. Daugherty wrote:
Resending with Dmitry's e-mail address included.
Please delete the previous version.
On 8/22/17 5:22 PM, serguei.s
On 8/28/17 12:41, Daniel D. Daugherty
wrote:
On 8/28/17 1:37 PM, serguei.spit...@oracle.com
wrote:
On 8/28/17 12:17, Daniel D.
Daugherty wrote:
On 8/22/17 5:22 PM, serguei.spit...@oracle.com
wrote:
On 8/28/17 1:37 PM, serguei.spit...@oracle.com wrote:
On 8/28/17 12:17, Daniel D. Daugherty wrote:
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote:
Please, review another revision of the fix for the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
CSR:
https://bugs.openjdk.ja
On 8/28/17 12:17, Daniel D. Daugherty
wrote:
On 8/22/17 5:22 PM, serguei.spit...@oracle.com
wrote:
Please, review another revision of the fix for the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote:
Please, review another revision of the fix for the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
CSR:
https://bugs.openjdk.java.net/browse/CCC-8061228
The SCR is in the DRAFT state.
Joe suggested to consider this CSR appr
Resending with Dmitry's e-mail address included.
Please delete the previous version.
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote:
Please, review another revision of the fix for the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
CSR:
https://bugs.openjdk.java.net/browse
On 8/22/17 5:22 PM, serguei.spit...@oracle.com wrote:
Please, review another revision of the fix for the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
CSR:
https://bugs.openjdk.java.net/browse/CCC-8061228
The SCR is in the DRAFT state.
Joe suggested to consider this CSR appr
t 2017 11:20
To: Dmitry Samersoff ; serviceability-
d...@openjdk.java.net; Robbin Ehn ; Daniel
Daugherty ; Alan Bateman
Subject: Re: RFR(M): 8061228 Allow JDWP socket connector to accept
connections from certain ip addresses only
Thanks, Dmitry!
I'm not sure, who is a reviewer in our case? :
ability-
d...@openjdk.java.net; Robbin Ehn ; Daniel
Daugherty ; Alan Bateman
Subject: Re: RFR(M): 8061228 Allow JDWP socket connector to accept
connections from certain ip addresses only
Thanks, Dmitry!
I'm not sure, who is a reviewer in our case? :)
You are the author, aren't you?
Thanks,
Sergue
Samersoff ; serviceability-
d...@openjdk.java.net; Robbin Ehn ; Daniel
Daugherty ; Alan Bateman
Subject: Re: RFR(M): 8061228 Allow JDWP socket connector to accept
connections from certain ip addresses only
Thanks, Dmitry!
I'm not sure, who is a reviewer in our case? :)
You are the author, aren
l
> Daugherty ; Alan Bateman
>
> Subject: Re: RFR(M): 8061228 Allow JDWP socket connector to accept
> connections from certain ip addresses only
>
> Thanks, Dmitry!
> I'm not sure, who is a reviewer in our case? :)
> You are the author, aren't you?
>
> Thanks,
>
Thanks, Dmitry!
I'm not sure, who is a reviewer in our case? :)
You are the author, aren't you?
Thanks,
Serguei
On 8/24/17 01:08, Dmitry Samersoff wrote:
Serguei,
The changes looks good to me.
Thank you for doing it.
-Dmitry
On 23.08.2017 23:59, serguei.spit...@oracle.com wrote:
Added Dmi
Serguei,
The changes looks good to me.
Thank you for doing it.
-Dmitry
On 23.08.2017 23:59, serguei.spit...@oracle.com wrote:
> Added Dmitry's email address to the list as he is not subscribed on the
> serviceability-dev.
>
> Thanks,
> Serguei
>
>
> On 8/22/17 16:22, serguei.spit...@oracle.c
Added Dmitry's email address to the
list as he is not subscribed on the serviceability-dev.
Thanks,
Serguei
On 8/22/17 16:22, serguei.spit...@oracle.com wrote:
Please, review another revision of the fix for the enhanceme
Please, review another revision of the fix for
the enhancement:
https://bugs.openjdk.java.net/browse/JDK-8061228
CSR:
https://bugs.openjdk.java.net/browse/CCC-8061228
The SCR is in the DRAFT state.
Joe suggested to consider this C
24 matches
Mail list logo
