Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8078896
webrev: http://cr.openjdk.java.net/~ykantser/8078896
The push will be pushed to jdk9/dev.
Thanks,
Katja
Alan's clarification from same change in hotspot (RFR: JDK-8075586: add
@modules as nee
On 05/05/2015 10:04, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8078896
webrev: http://cr.openjdk.java.net/~ykantser/8078896
The push will be pushed to jdk9/dev.
Thanks Katja, this looks good. One thing that we shou
Alan,
Thanks for the review! And for the catch - I'll fix it.
// Katja
On 05/05/2015 03:30 PM, Alan Bateman wrote:
Thanks Katja, this looks good. One thing that we should as part of
this is rev the requiredVersion in jdk/test/TEST.ROOT in case people
are using older versions of jtreg. I think
On 05/05/2015 02:04 AM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8078896
webrev: http://cr.openjdk.java.net/~ykantser/8078896
com.sun.management has been moved to jdk.management module. The patch
for JDK-8042
On 05/05/2015 01:33 PM, Mandy Chung wrote:
On 05/05/2015 02:04 AM, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.openjdk.java.net/browse/JDK-8078896
webrev: http://cr.openjdk.java.net/~ykantser/8078896
com.sun.management has been moved to j
On 05/05/2015 22:00, Mandy Chung wrote:
:
About the test selection, one typical aspect of svc tests is to run a
j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,jcmd,
jps etc that are in jdk.jcmd module). I would expect all
test/sun/tools/jcmd tests should have @modules jdk.jc
Mandy,
Thanks fro your review! Please see my comment inlined.
On 05/05/2015 11:00 PM, Mandy Chung wrote:
com.sun.management has been moved to jdk.management module. The
patch for JDK-8042901 is just integrated in jdk9/dev today. Most, if
not all, test/com/sun/management tests need updates t
On 05/06/2015 04:21 AM, Yekaterina Kantserova wrote:
The new webrev can be found here:
http://cr.openjdk.java.net/~ykantser/8078896/webrev.02/
Looks good.
About the test selection, one typical aspect of svc tests is to run a
j* tool in a child process (e.g. jinfo, jstack, jstat, jstatd,