Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread serguei.spit...@oracle.com
On 6/12/20 17:22, Daniel D. Daugherty wrote: Hi Serguei, Thanks for reviewing! I pushed the changeset just before I took a dinner break Great! so I won't be able to list you as a reviewer. Not a big deal. :) Thanks, Serguei Dan On 6/12/20 6:40 PM, serguei.spit...@oracle.com wrote:

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
Hi Serguei, Thanks for reviewing! I pushed the changeset just before I took a dinner break so I won't be able to list you as a reviewer. Dan On 6/12/20 6:40 PM, serguei.spit...@oracle.com wrote: Hi Dan and Chris, Problem-listing it for Xcomp only looks right to me. Thank you for taking care

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread serguei.spit...@oracle.com
Hi Dan and Chris, Problem-listing it for Xcomp only looks right to me. Thank you for taking care about it! Thanks, Serguei On 6/12/20 14:20, Chris Plummer wrote: On 6/12/20 1:59 PM, Daniel D. Daugherty wrote: On 6/12/20 4:48 PM, Chris Plummer wrote: On 6/12/20 12:13 PM, Daniel D. Daugherty

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
On 6/12/20 5:20 PM, Chris Plummer wrote: On 6/12/20 1:59 PM, Daniel D. Daugherty wrote: On 6/12/20 4:48 PM, Chris Plummer wrote: On 6/12/20 12:13 PM, Daniel D. Daugherty wrote: On 6/12/20 2:58 PM, Chris Plummer wrote: On 6/12/20 11:52 AM, Daniel D. Daugherty wrote: On 6/12/20 2:49 PM, Chris

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Chris Plummer
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote: On 6/12/20 4:48 PM, Chris Plummer wrote: On 6/12/20 12:13 PM, Daniel D. Daugherty wrote: On 6/12/20 2:58 PM, Chris Plummer wrote: On 6/12/20 11:52 AM, Daniel D. Daugherty wrote: On 6/12/20 2:49 PM, Chris Plummer wrote: Hi Dan, What's the

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
On 6/12/20 4:48 PM, Chris Plummer wrote: On 6/12/20 12:13 PM, Daniel D. Daugherty wrote: On 6/12/20 2:58 PM, Chris Plummer wrote: On 6/12/20 11:52 AM, Daniel D. Daugherty wrote: On 6/12/20 2:49 PM, Chris Plummer wrote: Hi Dan, What's the criteria for "noise". There is no specific criteria

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Chris Plummer
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote: On 6/12/20 2:58 PM, Chris Plummer wrote: On 6/12/20 11:52 AM, Daniel D. Daugherty wrote: On 6/12/20 2:49 PM, Chris Plummer wrote: Hi Dan, What's the criteria for "noise". There is no specific criteria that I'm aware of. It popped up in

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
On 6/12/20 2:58 PM, Chris Plummer wrote: On 6/12/20 11:52 AM, Daniel D. Daugherty wrote: On 6/12/20 2:49 PM, Chris Plummer wrote: Hi Dan, What's the criteria for "noise". There is no specific criteria that I'm aware of. It popped up in today's JDK15 testing so it got on my radar (again).

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
Yumin, Thanks for the review! Dan On 6/12/20 2:51 PM, Yumin Qi wrote: Hi, Dan   Looks good to me and it is trivial. Thanks Yumin On 6/12/20 11:40 AM, Daniel D. Daugherty wrote: Tap, tap, tap... is this thing working? Anyone out there? This is a trivial 1-liner review... Dan On

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Chris Plummer
Hi Dan, What's the criteria for "noise". I don't consider the failures for this test as noisy. I only see 3 in mach5 CI testing for all of JDK 15. JDK 14 does  appear to have been somewhat noisy, possibly enough so that it looks like maybe something changed to reduce the number of failures in

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Yumin Qi
Hi, Dan   Looks good to me and it is trivial. Thanks Yumin On 6/12/20 11:40 AM, Daniel D. Daugherty wrote: Tap, tap, tap... is this thing working? Anyone out there? This is a trivial 1-liner review... Dan On 6/12/20 12:46 PM, Daniel D. Daugherty wrote: Greetings, It's time to reduce

Re: RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
Tap, tap, tap... is this thing working? Anyone out there? This is a trivial 1-liner review... Dan On 6/12/20 12:46 PM, Daniel D. Daugherty wrote: Greetings, It's time to reduce the noise in the CI so I'm ProblemListing tests. Here's the bug for failure:     JDK-8205957

RFR(T): 8247495: ProblemList vmTestbase/nsk/jvmti/SetFieldAccessWatch/setfldw001/TestDescription.java

2020-06-12 Thread Daniel D. Daugherty
Greetings, It's time to reduce the noise in the CI so I'm ProblemListing tests. Here's the bug for failure:     JDK-8205957 setfldw001/TestDescription.java fails with bad field value     https://bugs.openjdk.java.net/browse/JDK-8205957 and here's the bug for the ProblemListing: