Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread Igor Ignatyev
thanks, i'll push it as soon as I get full test results (assuming there are no new failures). -- Igor > On Apr 27, 2020, at 10:21 PM, serguei.spit...@oracle.com wrote: > > This update looks good too. > > Thanks, > Serguei > > > On 4/27/20 22:12, Igor Ignatyev wrote: >> Thanks Mikael, >> >>

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread serguei.spit...@oracle.com
This update looks good too. Thanks, Serguei On 4/27/20 22:12, Igor Ignatyev wrote: Thanks Mikael, there is, thought, one more test failing after 8243928 -- serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the fix is pretty much the same revert part of 8243928:

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread Igor Ignatyev
Hi Serguei, thanks for review, no I haven't yet as I found another problem w/ 8243928. -- Igor > On Apr 27, 2020, at 10:14 PM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > Looks good but you have already pushed. :) > > Thanks, > Serguei > > > On 4/27/20 22:10, Mikael Vidstedt wrote:

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread serguei.spit...@oracle.com
Hi Igor, Looks good but you have already pushed. :) Thanks, Serguei On 4/27/20 22:10, Mikael Vidstedt wrote: Looks good, thanks for the quick turnaround! Cheers, Mikael On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread Igor Ignatyev
Thanks Mikael, there is, thought, one more test failing after 8243928 -- serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java. the fix is pretty much the same revert part of 8243928: > diff -r 67cbcf4f >

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread David Holmes
Looks good and trivial. Thanks, David On 28/04/2020 3:02 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up

Re: RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread Mikael Vidstedt
Looks good, thanks for the quick turnaround! Cheers, Mikael > On Apr 27, 2020, at 10:02 PM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 >> 2 lines changed: 0 ins; 0 del; 2 mod; > > Hi all, > > (so now it's my time to apology for inconvenience) > >

RFR(T) : 8243946 : serviceability/sa tests fail after JDK-8243928

2020-04-27 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8243946/webrev.00 > 2 lines changed: 0 ins; 0 del; 2 mod; Hi all, (so now it's my time to apology for inconvenience) could you please review this small follow-up fix/partial revert of 8243928[1]? serviceability/sa/TestCpoolForInvokeDynamic.java and