RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
Greetings, I have a small fix for a very intermittent ServerSocket related test failure:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307 The fix is copied from Jerry's work on the following bugs:     JDK-8182757 JDWP: Socket Tran

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
Adding core-libs-dev@... since this is RMI code. Thanks Alan! Folks, this review spans three OpenJDK aliases so Thunderbird's reply-to-list feature won't get it right. This is one of the few times that reply-to-all is the right thing to do... Dan On 12/7/17 11:38 AM, Daniel D. Daugherty wrote:

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Gerald Thornbrugh
Hi Dan, Your fix looks good. Jerry Adding core-libs-dev@... since this is RMI code. Thanks Alan! Folks, this review spans three OpenJDK aliases so Thunderbird's reply-to-list feature won't get it right. This is one of the few times that reply-to-all is the right thing to do... Dan On 12/7/1

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
Jerry, Thanks for the review! Dan On 12/7/17 12:00 PM, Gerald Thornbrugh wrote: Hi Dan, Your fix looks good. Jerry Adding core-libs-dev@... since this is RMI code. Thanks Alan! Folks, this review spans three OpenJDK aliases so Thunderbird's reply-to-list feature won't get it right. This

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Roger Riggs
+1 On 12/7/2017 12:00 PM, Gerald Thornbrugh wrote: Hi Dan, Your fix looks good. Jerry Adding core-libs-dev@... since this is RMI code. Thanks Alan! Folks, this review spans three OpenJDK aliases so Thunderbird's reply-to-list feature won't get it right. This is one of the few times that rep

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
Roger, Thanks for the review! Dan P.S. I'm planning to push this fix to jdk/hs since the only sightings have been in jdk/hs testing or in projects that are parented to jdk/hs repos... Hope that's okay... On 12/7/17 12:07 PM, Roger Riggs wrote: +1 On 12/7/2017 12:00 PM, Gerald Thornbrugh wro

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread serguei.spit...@oracle.com
Hi Dan, The fix looks good to me. Nice, you have caught it. Do you want this fixed in 10 or 11? I thought that the jdk/hs is for 11 now. Is it correct? Thanks, Serguei On 12/7/17 09:09, Daniel D. Daugherty wrote: Roger, Thanks for the review! Dan P.S. I'm planning to push this fix to jdk/

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread serguei.spit...@oracle.com
On 12/7/17 10:08, serguei.spit...@oracle.com wrote: Hi Dan, The fix looks good to me. Nice, you have caught it. Do you want this fixed in 10 or 11? I thought that the jdk/hs is for 11 now. Is it correct? Never mind. I've just found a message from Jesper the jdk/hs is used for 10 pushes for o

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
On 12/7/17 1:08 PM, serguei.spit...@oracle.com wrote: Hi Dan, The fix looks good to me. Nice, you have caught it. Thanks for the review! Do you want this fixed in 10 or 11? I thought that the jdk/hs is for 11 now. Is it correct? Please see Mark R's e-mail with the subject line of "JDK 10

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-07 Thread Daniel D. Daugherty
Greetings, My fix for the following bug:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307 broke two hs-tier3 tests. I'm backing out the fix via:     JDK-8193225 [BACKOUT] fix for 8182307 Error during JRMP connection establishment

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-08 Thread Alan Bateman
On 07/12/2017 16:55, Daniel D. Daugherty wrote: : Greetings, I have a small fix for a very intermittent ServerSocket related test failure:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307 : For the gory details of the reasons fo

Re: RFR(XXS): 8182307 - Error during JRMP connection establishment

2017-12-08 Thread Daniel D. Daugherty
On 12/8/17 4:28 AM, Alan Bateman wrote: On 07/12/2017 16:55, Daniel D. Daugherty wrote: : Greetings, I have a small fix for a very intermittent ServerSocket related test failure:     JDK-8182307: Error during JRMP connection establishment     https://bugs.openjdk.java.net/browse/JDK-8182307