Hi, loise
Thanks for your review. I will send out a new webrev soon.
For your concern, see embedded answers.
arguments.cpp - looks good, no comments
I will add another functions, is_filename_valid, and in this functions,
check if the given filename is 'legal' function name, currently we di
Hi Yumin,
I do have some follow on review comments:
arguments.cpp - looks good, no comments
ostream.hpp - looks good, no comments
ostream.cpp -
- Have you tried a file name that is 255 characters? It would seem
that after you appended the pid + timestamp + .current + # you could
overru
> Append vs clobber: with or without rotation, -Xloggc always clobbers the last
> log. That's why people want a time stamp or pid in the gc file name, IMHO.
My client just clobbered his log files yet... I'd still *not* want the time
stamp because this can potentially accidentally fill producti
Hi,
Based on the discussion, I updated the webrev, and in this version
1) deleted unused rotatingFileStream constructor, which keep code shorter.
2) removed reformat_filename in previous version.
3) still keep original design, that if no rotation, just use file name
given by -Xloggc:.
Others
Hi, Bernd
On 8/27/2013 10:27 AM, Bernd Eckenfels wrote:
Hello,
no matter what you decide (for example configurable pattern like J9 is
doing it) please add enough header informatiomn to the logfile that it
answers common gc diagnostic questions (version, command line
settings, ram/swap size)
On 8/27/13 1:01 AM, Bengt Rutisson wrote:
Yumin,
On 8/26/13 7:01 PM, Yumin Qi wrote:
Bengt,
Thanks for your comments.
Yes, as you said, the purpose of rotating logs is primarily
targeted for saving disk space. This bug is supplying customers
another option to prevent the previous gc
On 2013-08-27, at 10:01 AM, Bengt Rutisson wrote:
>
> Yumin,
>
> On 8/26/13 7:01 PM, Yumin Qi wrote:
>> Bengt,
>>
>> Thanks for your comments.
>> Yes, as you said, the purpose of rotating logs is primarily targeted for
>> saving disk space. This bug is supplying customers another option t
Yumin,
On 8/26/13 7:01 PM, Yumin Qi wrote:
Bengt,
Thanks for your comments.
Yes, as you said, the purpose of rotating logs is primarily targeted
for saving disk space. This bug is supplying customers another option
to prevent the previous gc logs from removed by restart app without
mak
Bengt,
Thanks for your comments.
Yes, as you said, the purpose of rotating logs is primarily targeted
for saving disk space. This bug is supplying customers another option
to prevent the previous gc logs from removed by restart app without
making copy. Now with this pid and time stamp inc
