RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-24 Thread Marcus Larsson
Hi, Please review the following patch to enable multiple -Xlog arguments to aggregate the log configuration. Summary: Tag sets that are unaffected by a -Xlog argument will now be left untouched, enabling them to keep settings from a previous -Xlog argument. To be able to print the current l

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread Marcus Larsson
Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Changes: * LogLevel::Unchanged was changed to LogLevel::NotMentioned. * Test improvements. I also looked a

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread Bengt Rutisson
Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ Looks good. Changes: * LogLevel::Unchanged was

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread Marcus Larsson
Thanks for reviewing, Bengt! Marcus On 2015-11-26 16:25, Bengt Rutisson wrote: Hi Marcus, On 2015-11-26 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental: http://cr.openjdk.java.net/~

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 26 nov. 2015, at 16:17, Marcus Larsson wrote: > > Hi, > > New webrev after offline review with Bengt and Staffan: > http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ > > Incremental: > http://cr.openjdk.java.net/~mlarsson/8142952/webrev.00-01/ > > Chan

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread Marcus Larsson
Thanks for reviewing, Staffan! Marcus On 2015-11-26 16:54, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 26 nov. 2015, at 16:17, Marcus Larsson wrote: Hi, New webrev after offline review with Bengt and Staffan: http://cr.openjdk.java.net/~mlarsson/8142952/webrev.01/ Incremental:

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-26 Thread David Holmes
Hi Marcus, I had assumed from the JEP that multiple -Xlog arguments for different tags were already supported - so good to see that is now fixed. I'm unclear what the semantics are for combining multiple -Xlog arguments for the same tag (either directly or via implicit wildcards)? Most detai

Re: RFR: 8142952: Unified Logging framework does not allow multiple -Xlog: arguments

2015-11-27 Thread Marcus Larsson
Hi David, On 2015-11-27 02:12, David Holmes wrote: Hi Marcus, I had assumed from the JEP that multiple -Xlog arguments for different tags were already supported - so good to see that is now fixed. I'm unclear what the semantics are for combining multiple -Xlog arguments for the same tag (e