Hi all,
JSnap is useful SA tool to check PerfCounter.
So I want to add it to jhsdb.
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.00/
Could you review it?
Thanks,
Yasumasa
Yasumasa,
It's better (with upcoming changes for JDK-8148659 in mind) to create a
separate
private static boolean jsnapHelp() {
System.out.println(" \tdump perfromance counters");
return commonHelp();
}
and write:
System.out.println(" jsnap --help\tto get more information");
Please also
Hi Dmitry,
Thank you for your comment.
I uploaded new webrev:
hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/hotspot/
jdk: http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.01/jdk/
Could you review again?
Thanks,
Yasumasa
On 2016/03/04 0:15, Dmitry Samers
Yasumasa,
91 s/perfromance/performance/
Test:
146 launch("compiler detected.", "jsnap");
Please, choose expectedMessage carefully, I'm not sure "compiler
detected." is an appropriate one.
-Dmitry
On 2016-03-03 18:45, Yasumasa Suenaga wrote:
> Hi Dmitry,
>
> Thank you for your comme
Hi Dmitry,
I uploaded new webrev:
hotspot (not changed):
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.02/hotspot/
jdk:
http://cr.openjdk.java.net/~ysuenaga/JDK-8151181/webrev.02/jdk/
Could you review it again?
BTW, jmap test uses "compiler detected" as expect
Yasumasa,
1. Changes looks good for me, but please fix a typeo in
hotspot/SALauncher.java (no need to re-review)
91 s/perfromance/performance/
2. Simple jmap output looks like
dooku:test#/opt/jdk9/bin/jmap 6379
Attaching to process ID 6379, please wait...
Debugger attached successfully.
Server
Hi Dmitry,
Thanks, I understood.
I will send changesets to you.
Yasumasa
On 2016/03/04 16:59, Dmitry Samersoff wrote:
> Yasumasa,
>
> 1. Changes looks good for me, but please fix a typeo in
> hotspot/SALauncher.java (no need to re-review)
>
> 91 s/perfromance/performance/
>
> 2. Simple jmap
