RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Per Liden
There's no support for SA heap walking when using ZGC. Hence the tests for this should not execute when ZGC is enabled. Bug: https://bugs.openjdk.java.net/browse/JDK-8214484 Webrev: http://cr.openjdk.java.net/~pliden/8214484/webrev.0 /Per

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Aleksey Shipilev
On 11/29/18 4:07 PM, Per Liden wrote: > There's no support for SA heap walking when using ZGC. Hence the tests for > this should not execute > when ZGC is enabled. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214484 > Webrev: http://cr.openjdk.java.net/~pliden/8214484/webrev.0 Looks good.

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Per Liden
On 11/29/18 4:17 PM, Aleksey Shipilev wrote: On 11/29/18 4:07 PM, Per Liden wrote: There's no support for SA heap walking when using ZGC. Hence the tests for this should not execute when ZGC is enabled. Bug: https://bugs.openjdk.java.net/browse/JDK-8214484 Webrev: http://cr.openjdk.java.net/~p

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Aleksey Shipilev
On 11/29/18 4:34 PM, Per Liden wrote: > On 11/29/18 4:17 PM, Aleksey Shipilev wrote: >> On 11/29/18 4:07 PM, Per Liden wrote: >>> There's no support for SA heap walking when using ZGC. Hence the tests for >>> this should not execute >>> when ZGC is enabled. >>> >>> Bug: https://bugs.openjdk.java.n

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Per Liden
Hi, On 11/29/18 4:48 PM, Aleksey Shipilev wrote: On 11/29/18 4:34 PM, Per Liden wrote: On 11/29/18 4:17 PM, Aleksey Shipilev wrote: On 11/29/18 4:07 PM, Per Liden wrote: There's no support for SA heap walking when using ZGC. Hence the tests for this should not execute when ZGC is enabled. B

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Aleksey Shipilev
On 11/29/18 5:26 PM, Per Liden wrote: > Hi, > > On 11/29/18 4:48 PM, Aleksey Shipilev wrote: >> On 11/29/18 4:34 PM, Per Liden wrote: >>> On 11/29/18 4:17 PM, Aleksey Shipilev wrote: On 11/29/18 4:07 PM, Per Liden wrote: > There's no support for SA heap walking when using ZGC. Hence the t

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Chris Plummer
Hi Per, I think there may have been some discussion about this before. Are there plans to eventually get SA heap walking support for ZGC, and is the list of disabled tests being maintained somewhere? thanks, Chris On 11/29/18 7:07 AM, Per Liden wrote: There's no support for SA heap walking

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Roman Kennke
Hi Chris, Per, Shenandoah has the same problem, for the same reasons. And I'm not convinced that G1 is safe either, at least with -XX:+ClassUnloadingWithConcurrentMark. In my opinion, this whole code section needs to be rewritten to use something like CollectedHeap::object_iterate() (which is use

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Per Liden
On 2018-11-29 17:40, Aleksey Shipilev wrote: On 11/29/18 5:26 PM, Per Liden wrote: Hi, On 11/29/18 4:48 PM, Aleksey Shipilev wrote: On 11/29/18 4:34 PM, Per Liden wrote: On 11/29/18 4:17 PM, Aleksey Shipilev wrote: On 11/29/18 4:07 PM, Per Liden wrote: There's no support for SA heap walk

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Per Liden
Hi Chris, On 2018-11-29 20:04, Chris Plummer wrote: Hi Per, I think there may have been some discussion about this before. Are there plans to eventually get SA heap walking support for ZGC, and is the list of disabled tests being maintained somewhere? The latest directive I've received is t

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-29 Thread Chris Plummer
On 11/29/18 1:28 PM, Per Liden wrote: Hi Chris, On 2018-11-29 20:04, Chris Plummer wrote: Hi Per, I think there may have been some discussion about this before. Are there plans to eventually get SA heap walking support for ZGC, and is the list of disabled tests being maintained somewhere?

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-11-30 Thread Thomas Schatzl
Hi, On Thu, 2018-11-29 at 16:07 +0100, Per Liden wrote: > There's no support for SA heap walking when using ZGC. Hence the > tests > for this should not execute when ZGC is enabled. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8214484 > Webrev: http://cr.openjdk.java.net/~pliden/8214484/web

Re: RFR: 8214484: ZGC: Exclude SA tests ClhsdbJhisto and TestHeapDumpFor*

2018-12-03 Thread Per Liden
Thanks for reviewing, Thomas! /Per On 11/30/18 1:53 PM, Thomas Schatzl wrote: Hi, On Thu, 2018-11-29 at 16:07 +0100, Per Liden wrote: There's no support for SA heap walking when using ZGC. Hence the tests for this should not execute when ZGC is enabled. Bug: https://bugs.openjdk.java.net/bro