Hello, please review the following change .
It enhances the error messages in libinstrument in case initialization fails .
( I found the enhanced error messages helpful when analyzing jtreg
failures on one of our platforms in the
java/lang/instrument/PremainClass/PremainClassTest.java
changing the test to
if (environment == NULL) { … }
or is this resolved now on all platforms ?
Best regards, Matthias
From: Jean Christophe Beyler
Sent: Freitag, 15. März 2019 15:53
To: Baesken, Matthias
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8220355: Improve assertion texts
On 18/03/2019 08:54, Baesken, Matthias wrote:
Hi JC, thanks for your comments .
Second webrev , may I have a second review please ?
http://cr.openjdk.java.net/~mbaesken/webrevs/8220355.1/
I think this looks okay except I think "emergency" should be dropped
from the message (and the existi
18. März 2019 10:09
To: Baesken, Matthias ; Jean Christophe Beyler
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8220355: Improve assertion texts and exception messages in
eventHandlerVMInit
On 18/03/2019 08:54, Baesken, Matthias wrote:
Hi JC, thanks for your comments .
Second webr
t failed");
If you prefer I could output just “fallback init failed" - is
this fine with you?
Best regards, Matthias
*From:*Alan Bateman
*Sent:* Montag, 18. März 2019 10:09
*To:* Baesken, Matthias ; Jean Christophe
Beyler
*Cc:* serviceability-dev@openjdk.java.net
*Subject:* Re:
ava.net<mailto:serviceability-dev@openjdk.java.net>
Subject: Re: RFR: 8220355: Improve assertion texts and exception messages in
eventHandlerVMInit
On 18/03/2019 08:54, Baesken, Matthias wrote:
Hi JC, thanks for your comments .
Second webrev , may I have a second review please ?
http://cr.
eyler <
> jcbey...@google.com>
> *Cc:* serviceability-dev@openjdk.java.net
> *Subject:* RE: RFR: 8220355: Improve assertion texts and exception
> messages in eventHandlerVMInit
>
>
>
> Hi Alan, thanks for the review .
>
>
>
> > I think this looks okay exc
On 18/03/2019 14:34, Baesken, Matthias wrote:
Updated webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8220355.2/
Alan + JC , may I add you as reviewers ?
Yes, looks good to me.
-Alan
Hi Matthias,
+1
Thanks,
Serguei
On 3/18/19 09:47, Alan Bateman wrote:
On
18/03/2019 14:34, Baesken, Matthias wrote:
Updated webrev :
http://cr.openjdk.java.net/~mb
