Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2020-01-06 Thread Yasumasa Suenaga
some one please sponsor this push? Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Tuesday, December 17, 2019 12:42 AM To: Kevin Walls ; Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2020-01-05 Thread Fairoz Matte
Walls ; Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled +1 On 12/16/19 8:35 AM, Kevin Walls wrote: > Great! 8-) > > On 16/12/2019 15:36, Fairoz Matte wrote: >> Oh yes, >> Thanks

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-16 Thread Chris Plummer
+1 On 12/16/19 8:35 AM, Kevin Walls wrote: Great! 8-) On 16/12/2019 15:36, Fairoz Matte wrote: Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-16 Thread Kevin Walls
Great! 8-) On 16/12/2019 15:36, Fairoz Matte wrote: Oh yes, Thanks Kevin for the review. Corrected the same - http://cr.openjdk.java.net/~fmatte/8235637/webrev.02 Thanks, Fairoz

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-16 Thread Fairoz Matte
: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Nice to know the difference between something that is zero, and something that has failed. 8-) ...oops, that says INAVLID_LOAD_ADDRESS ..not INVALID, so other that the typo yes it looks good. --- Kevin On 13/12

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-16 Thread Kevin Walls
Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: Hi, Please review this small

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-15 Thread Fairoz Matte
Thanks Chris, > -Original Message- > From: Chris Plummer > Sent: Friday, December 13, 2019 11:09 PM > To: Fairoz Matte ; serviceability- > d...@openjdk.java.net > Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if > prelink is enabled > &

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-13 Thread Chris Plummer
.01/ Thanks, Fairoz -Original Message- From: Chris Plummer Sent: Thursday, December 12, 2019 9:48 PM To: Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-13 Thread Fairoz Matte
Sent: Thursday, December 12, 2019 9:48 PM To: Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-12 Thread Chris Plummer
Can you use a macro for -1L? Maybe INAVLID_LOAD_ADDRESS or LOAD_ADDRESS_ERROR. Chris On 12/11/19 7:10 PM, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address()

RE: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-12 Thread Fairoz Matte
7: jhsdb jmap from OpenJDK 11.0.5 doesn't work if > prelink is enabled > > Hi Fairoz, > > Looks good! > I want you to backport this change to both jdk11u and 8u. > > > Thanks, > > Yasumasa > > > On 2019/12/12 12:10, Fairoz Matte wrote: > > Hi, &g

Re: RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-11 Thread Yasumasa Suenaga
Hi Fairoz, Looks good! I want you to backport this change to both jdk11u and 8u. Thanks, Yasumasa On 2019/12/12 12:10, Fairoz Matte wrote: Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after

RFR: 8235637: jhsdb jmap from OpenJDK 11.0.5 doesn't work if prelink is enabled

2019-12-11 Thread Fairoz Matte
Hi, Please review this small change, Updating error handling, to make sure "lib_base_diff = 0" is still a valid scenario even after calc_prelinked_load_address() call. JBS - https://bugs.openjdk.java.net/browse/JDK-8235637 Webrev - http://cr.openjdk.java.net/~fmatte/8235637/webrev.00/ This