; Date: Monday, May 11, 2020 at 11:53 AM
> To: Daniil Titov , serviceability-dev
> Subject: Re: RFR: 8241080: Consolidate signature parsing code in
serviceability tools
>
> Hi Daniil,
>
> It looks pretty good in general.
> A couple of nit
; Daniil
>
>
> From: "serguei.spit...@oracle.com"
> Date: Monday, May 11, 2020 at 11:53 AM
> To: Daniil Titov , serviceability-dev
> Subject: Re: RFR: 8241080: Consolidate signature parsing code in
serviceability tools
>
> Hi Daniil
45057
Thank you,
Daniil
From: "serguei.spit...@oracle.com"
Date: Monday, May 11, 2020 at 11:53 AM
To: Daniil Titov , serviceability-dev
Subject: Re: RFR: 8241080: Consolidate signature parsing code in serviceability
tools
Hi Daniil,
It looks pretty good in general.
A couple of ni
Subject: Re: RFR: 8241080: Consolidate signature parsing code in serviceability
tools
Hi Daniil,
It looks pretty good in general.
A couple of nits below.
http://cr.openjdk.java.net/~dtitov/8241080/webrev.01/src/jdk.jdwp.agent/share/native/libjdwp/invoker.c.udiff.html
+void *cursor;
+jbyte arg
;
Date: Monday, May 11, 2020 at 11:53 AM
To: Daniil Titov , serviceability-dev
Subject: Re: RFR: 8241080: Consolidate signature parsing code in serviceability
tools
Hi Daniil,
It looks pretty good in general.
A couple of nits below.
http://cr.openjdk.java.net/~dtitov/8241080/webrev.01/src/jdk.j
Hi Daniil,
In the grand scheme of things, could servicability use the signature
parsing support in HotSpot?
Thanks, Roger
On 5/9/20 12:29 PM, Daniil Titov wrote:
Please review a change[1] that centralizes the signature processing in
serviceability tools to make it capable of being easily e
Hi Daniil,
It looks pretty good in general.
A couple of nits below.
http://cr.openjdk.java.net/~dtitov/8241080/webrev.01/src/jdk.jdwp.agent/share/native/libjdwp/invoker.c.udiff.html
+void *cursor;
+jbyte argumentTag;
+jint argIndex = 0;
+jv
Hi Daniil,
Overall looks good. Just one minor thing. In ClassTypeImpl.c and
ObjectReferenceImpl.c I think the following would be more readable with
an if/else:
79 return JNI_FUNC_PTR(env,ExceptionOccurred)(env) ?
AGENT_ERROR_JNI_EXCEPTION
80 : JVMTI_ERROR_NONE;
Also
Please review a change[1] that centralizes the signature processing in
serviceability tools to make it capable of being easily extensible in the
future.
Testing: Mach5 tier1-tier3 tests successfully passed.
[1] http://cr.openjdk.java.net/~dtitov/8241080/webrev.01
[2] https://bugs.openjdk.java.
