Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2021-01-18 Thread Lin Zang
On Fri, 8 Jan 2021 13:21:21 GMT, Lin Zang wrote: >> Changes requested by cjplummer (Reviewer). > > Hi @plummercj , > Thanks very much for reviewing! > Sorry that I got stuck on other work and didn't read review message timely. > I will go through your suggestions carefully and try to fix all is

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2021-01-08 Thread Lin Zang
On Mon, 4 Jan 2021 22:35:24 GMT, Chris Plummer wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete unnecessary print > > Changes requested by cjplummer (Reviewer). Hi @plummercj , Thanks very much for reviewing! So

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2021-01-04 Thread Chris Plummer
On Mon, 4 Jan 2021 22:00:34 GMT, Chris Plummer wrote: >> Lin Zang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> delete unnecessary print > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/JMap.java line 62: > >> 60:

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2021-01-04 Thread Chris Plummer
On Thu, 10 Dec 2020 03:08:48 GMT, Lin Zang wrote: >> 8257234 : Add gz option to SA jmap to write a gzipped heap dump > > Lin Zang has updated the pull request incrementally with one additional > commit since the last revision: > > delete unnecessary print Changes requested by cjplummer (Revi

Re: RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v3]

2020-12-09 Thread Lin Zang
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump Lin Zang has updated the pull request incrementally with one additional commit since the last revision: delete unnecessary print - Changes: - all: https://git.openjdk.java.net/jdk/pull/1712/files - new: https:/