On Tue, 22 Jun 2021 12:56:27 GMT, David Holmes wrote:
> I can sponsor, but as per hotspot integration guidelines we should wait at
> least 24 hours to give people in different timezones a chance to comment.
Got it. Thanks a lot!
-
PR: https://git.openjdk.java.net/jdk/pull/4546
On Tue, 22 Jun 2021 10:53:06 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> Considering the consistency of `JavaThread` and other threads, such as
>> WorkerThread and CompilerThread, `JavaThread` could use a method named
>> `cast` to replace the method `Thread::as_Java_thread()`. It can reduce the
On Tue, 22 Jun 2021 11:36:02 GMT, David Holmes wrote:
> The error is in ZGC code and ZGC is not tested in tier-1 or pre-submit.
Got it. Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/4546
On Tue, 22 Jun 2021 11:34:58 GMT, David Holmes wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove inline specifier
>
> Updates look fine.
>
> Thanks,
> David
@dholmes-ora @stefank Thanks for your reviews. Coul
On Tue, 22 Jun 2021 10:53:06 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> Considering the consistency of `JavaThread` and other threads, such as
>> WorkerThread and CompilerThread, `JavaThread` could use a method named
>> `cast` to replace the method `Thread::as_Java_thread()`. It can reduce the
On 22/06/2021 5:24 pm, Guoxiong Li wrote:
On Tue, 22 Jun 2021 01:59:17 GMT, David Holmes wrote:
Guoxiong Li has updated the pull request incrementally with one additional
commit since the last revision:
Fix incorrect use of the method cast
Hi Guoxiong,
Thanks for picking up this enhanc
On Tue, 22 Jun 2021 10:21:45 GMT, Stefan Karlsson wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix incorrect use of the method cast
>
> src/hotspot/share/runtime/thread.hpp line 1432:
>
>> 1430: assert(t->is
> Hi all,
>
> Considering the consistency of `JavaThread` and other threads, such as
> WorkerThread and CompilerThread, `JavaThread` could use a method named `cast`
> to replace the method `Thread::as_Java_thread()`. It can reduce the Thread's
> knowledge about the subtypes.
>
> This patch rem
On Tue, 22 Jun 2021 07:17:00 GMT, Guoxiong Li wrote:
>> Hi all,
>>
>> Considering the consistency of `JavaThread` and other threads, such as
>> WorkerThread and CompilerThread, `JavaThread` could use a method named
>> `cast` to replace the method `Thread::as_Java_thread()`. It can reduce the
On Tue, 22 Jun 2021 07:21:29 GMT, Guoxiong Li wrote:
> Maybe we can improve the tier1 or the Pre-submit tests in the future.
I meant to improve the test coverage.
-
PR: https://git.openjdk.java.net/jdk/pull/4546
On Tue, 22 Jun 2021 01:59:17 GMT, David Holmes wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix incorrect use of the method cast
>
> Hi Guoxiong,
>
> Thanks for picking up this enhancement request.
>
> I wasn't
> Hi all,
>
> Considering the consistency of `JavaThread` and other threads, such as
> WorkerThread and CompilerThread, `JavaThread` could use a method named `cast`
> to replace the method `Thread::as_Java_thread()`. It can reduce the Thread's
> knowledge about the subtypes.
>
> This patch rem
On Tue, 22 Jun 2021 01:11:30 GMT, Guoxiong Li wrote:
> Hi all,
>
> Considering the consistency of `JavaThread` and other threads, such as
> WorkerThread and CompilerThread, `JavaThread` could use a method named `cast`
> to replace the method `Thread::as_Java_thread()`. It can reduce the Thread
Hi all,
Considering the consistency of `JavaThread` and other threads, such as
WorkerThread and CompilerThread, `JavaThread` could use a method named `cast`
to replace the method `Thread::as_Java_thread()`. It can reduce the Thread's
knowledge about the subtypes.
This patch removes two methods
14 matches
Mail list logo
