Hi all,
[Including build-dev also since this includes build related changes].
Requesting reviews for:
https://bugs.openjdk.java.net/browse/JDK-8189429 (SA: MacOSX: Replace
the deprecated PT_ATTACH with PT_ATTACHEXC)
Webrev: http://cr.openjdk.java.net/~jgeorge/8189429/webrev.04/
This is the
Hello Jini,
In general this looks pretty good, but it's also breaking some new
ground as it's adding generation of native source in the java gensrc
step. Mixing native code with the java code that the genrcs targets and
gensrc output directories are meant for seems ok for now, but may cause
t
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/
Thank you,
Jini.
On 6/23/2018 3:31 AM, Erik Joelsson wrote:
Hello Jini,
In general this looks pretty good, but it's also brea
: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH
with PT_ATTACHEXC
Hi Erik,
Thank you very much for looking into this. I have addressed your comments. The
latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/
Thank you,
Jini.
On 6/23/2018 3:31 AM, Erik Joelsson
, 2018 11:07 PM
To: Erik Joelsson; serviceability-dev@openjdk.java.net;
build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated PT_ATTACH
with PT_ATTACHEXC
Hi Erik,
Thank you very much for looking into this. I have addressed
Build changes look good.
/Erik
On 2018-06-24 10:37, Jini George wrote:
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/
Thank you,
Jini.
On 6/23/2018 3:31 AM, Erik Joelsson
Thank you, Erik !
- Jini.
On 6/25/2018 9:23 PM, Erik Joelsson wrote:
Build changes look good.
/Erik
On 2018-06-24 10:37, Jini George wrote:
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/81
,
Sharath
-Original Message-
From: Jini George
Sent: Sunday, June 24, 2018 11:07 PM
To: Erik Joelsson; serviceability-dev@openjdk.java.net;
build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated
PT_ATTACH with
ava.net;
build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: JDK-8189429: SA: MacOSX: Replace the deprecated
PT_ATTACH with PT_ATTACHEXC
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.ja
ni,
Changes in MacosxDebuggerLocal.m looks good.
Thanks,
Sharath
-Original Message-
From: Jini George
Sent: Sunday, June 24, 2018 11:07 PM
To: Erik Joelsson; serviceability-dev@openjdk.java.net;
build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: JDK-8189429: SA: MacO
10 matches
Mail list logo
