Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Thanks, Erik. On 6/18/18, 10:26 AM, "Erik Helin" wrote: On 06/18/2018 06:14 PM, Hohensee, Paul wrote: > Thanks, Eric! > > I'd push, but it seems I don't seem to have permission at the moment. Who should I contact to get that fixed? That would be

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

On 06/18/2018 06:14 PM, Hohensee, Paul wrote: Thanks, Eric! I'd push, but it seems I don't seem to have permission at the moment. Who should I contact to get that fixed? That would be o...@openjdk.java.net. Thanks, Erik Thanks, Paul On 6/18/18, 7:09 AM, "Erik Helin" wrote: On

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Thanks, Eric! I'd push, but it seems I don't seem to have permission at the moment. Who should I contact to get that fixed? Thanks, Paul On 6/18/18, 7:09 AM, "Erik Helin" wrote: On 06/16/2018 09:00 PM, Hohensee, Paul wrote: > Thanks for the re-review, Erik. New webrev with your

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

On 06/16/2018 09:00 PM, Hohensee, Paul wrote: Thanks for the re-review, Erik. New webrev with your fixes: http://cr.openjdk.java.net/~phh/8195115/webrev.04/ The patch is good to go now, Reviewed. Thanks, Erik Need another reviewer, please. Thanks, Paul On 6/16/18, 1:25 AM, "Erik Helin"

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Looks fine to me. Mandy On 6/16/18 12:00 PM, Hohensee, Paul wrote: Thanks for the re-review, Erik. New webrev with your fixes: http://cr.openjdk.java.net/~phh/8195115/webrev.04/ Need another reviewer, please. Thanks, Paul

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Thanks for the re-review, Erik. New webrev with your fixes: http://cr.openjdk.java.net/~phh/8195115/webrev.04/ Need another reviewer, please. Thanks, Paul On 6/16/18, 1:25 AM, "Erik Helin" wrote: On 06/15/2018 10:21 PM, Hohensee, Paul wrote: > After some difficulty with the submit

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

On 06/15/2018 10:21 PM, Hohensee, Paul wrote: After some difficulty with the submit cluster, with which Erik helped me out, the patch passes. It also passed fastdebug hotspot tier 1 testing on my Mac laptop, which former includes the new test. I had to increase -Xmx and -Xms to 12m in order

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

After some difficulty with the submit cluster, with which Erik helped me out, the patch passes. It also passed fastdebug hotspot tier 1 testing on my Mac laptop, which former includes the new test. I had to increase -Xmx and -Xms to 12m in order to get TestOldGenCollectionUsage to pass on the

Re: FW: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

(adding back serviceability-dev, please keep both hotspot-gc-dev and serviceability-dev) Hi Paul, before I start re-reviewing, did you test the new version of the patch via the jdk/submit repository [0]? Thanks, Erik [0]: http://hg.openjdk.java.net/jdk/submit On 06/09/2018 03:29 PM,

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Back after a long hiatus... Thanks, Eric, for your review. Here's a new webrev incorporating your recommendations. Bug: https://bugs.openjdk.java.net/browse/JDK-8195115 Webrev: http://cr.openjdk.java.net/~phh/8195115/webrev.02/ TIA for your re-review. Plus, may I have another reviewer look at

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Hi Paul, a couple of comments on the patch: - memoryService.hpp: + 150 bool countCollection, + 151 bool allMemoryPoolsAffected = true); There is no need to use a default value for the parameter allMemoryPoolsAffected here. Skipping the default value

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Ping for a review please. Thanks, Paul On 2/16/18, 12:26 PM, "serviceability-dev on behalf of Hohensee, Paul" wrote: The CSR https://bugs.openjdk.java.net/browse/JDK-8196719 for the original fix has been

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

entire heap usage. Are you seeing issue/bug with the sum result? > > > > > > > > > typo: s/an incorrect approximation/an approximation. > > > >

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

<http://cr.openjdk.java.net/%7Ephh/8195115/webrev.hs.01/> > > > > > > Waiting on the submit repo to come back with a result on it. > >

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

> > > > *From: *mandy chung <mandy.ch...@oracle.com> > > *Organization: *Oracle Corporation > > *Date: *Monday, January 29, 2018 at 1:41 PM > > *To: *"Hohensee, Paul&quo

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

> Thanks, > > > > Paul > > > > *From: *mandy chung <mandy.ch...@oracle.com> > > *Organization: *Oracle Corporation > > *Date: *Monday, January 29, 2018 at 1:

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

> > > > Paul > > > > *From: *mandy chung <mandy.ch...@oracle.com> > > *Organization: *Oracle Corporation > > *Date: *Monday, January 29, 2018 at 1:41 PM > > *To: *"

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

r you? > > Thanks, > Erik > > > Thanks, > > > > Paul > > > > *From: *mandy chung <mandy.ch...@oracle.com> > > *Organization: *Oracle Corporation > > *Date: *Monday

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

k for you? > >Thanks, >Erik > >> Thanks, >> >> Paul >> >> *From: *mandy chung <mandy.ch...@oracle.com> >> *Organization: *Oracle Corporation >> *Date: *Monday, January 29, 2018 at 1:41 PM >> *To: *"Hohensee, Paul&

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

January 29, 2018 at 1:41 PM > *To: *"Hohensee, Paul" <hohen...@amazon.com> > *Cc: *"serviceability-dev@openjdk.java.net" > <serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" > <hotspot-gc-...@openjdk.ja

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

bility-dev@openjdk.java.net" > <serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" > <hotspot-gc-...@openjdk.java.net> > *Subject: *Re: RFR (S): 8195115: G1 Old Gen MemoryPool > CollectionUsage.used values don't reflect m

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

<mailto:serviceability-dev@openjdk.java.net> <serviceability-dev@openjdk.java.net> <mailto:serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" <mailto:hotspot-gc-...@openjdk.java.net> <hotspot-gc-...@openjdk.java.net>

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

n...@amazon.com> Cc: "serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" <hotspot-gc-...@openjdk.java.net> Subject: Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't re

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

> On Jan 29, 2018, at 5:27 PM, Hohensee, Paul wrote: > > A name change would affect Amazon’s heap monitoring, and thus I expect it > would affect other users as well. I can name a number of tools that would be disrupted by this type of change. Additionally tooling would

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

viceability-dev@openjdk.java.net> <serviceability-dev@openjdk.java.net> <mailto:serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" <mailto:hotspot-gc-...@openjdk.java.net> <hotspot-gc-...@openjdk.j

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

On the CSR question, yes this would need a CSR just to ensure the compatibility issues have been covered. David On 25/01/2018 11:20 PM, Erik Helin wrote: Hi Paul, thanks for your interest in this area and for your patch! The GarbageCollectorMXBean and MemoryPoolMXBean support for G1 is in

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

jdk.java.net>, "hotspot-gc-...@openjdk.java.net" <hotspot-gc-...@openjdk.java.net> Subject: Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results On 1/29/18 10:35 AM, mandy chung wrote: Thanks for the reply Paul. Try to understa

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

d Holmes <david.hol...@oracle.com> *Cc: *"serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" <hotspot-gc-...@openjdk.java.net> *Subject: *Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used valu

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

-dev@openjdk.java.net>, "hotspot-gc-...@openjdk.java.net" <hotspot-gc-...@openjdk.java.net> *Subject: *Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results On 1/25/18 1:04 PM, Hohensee, Paul wrote: > The JMX API spec doesn’t

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

jdk.java.net>, "hotspot-gc-...@openjdk.java.net" <hotspot-gc-...@openjdk.java.net> Subject: Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results On 1/25/18 1:04 PM, Hohensee, Paul wrote: > The JMX API spec doesn’t specify what the m

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

On 1/25/18 1:04 PM, Hohensee, Paul wrote: The JMX API spec doesn’t specify what the memory pool or garbage > collector names are, but the current names are de-facto part of the > API, so if we change the existing ones, imo a CSR should be filed. The names are implementation details but I

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Hi Erik, The proposal you outline below is reasonable. The API was designed to allow any number of memory pools managed by a memory manager that can represent different phases of a garbage collector or other resource manager to expose various metrics. How G1 exposes these monitoring metrics is

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Hi Erik & co, thanks for looking at this. Would you be ok with pushing this fix (it really is a bug!) and then me doing a followup RFE? That way, I can backport the fix to 8u and eventually remove the patch I’ve already pushed to our OpenJDK8 internal release. Some background. We used to

Re: RFR (S): 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Hi Paul, thanks for your interest in this area and for your patch! The GarbageCollectorMXBean and MemoryPoolMXBean support for G1 is in need of some updates, so thanks for working on this. Looking at your patch, I'm not sure that this is the direction we want to go in. I discussed this a