Kindly review the changes made.
https://bugs.openjdk.java.net/browse/JDK-8044122
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.00/
CSR : https://bugs.openjdk.java.net/browse/JDK-8189091
Thanks,
Ujwal.
kindly see the new webrev incorporating review comments.
webrev:
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.01/
Thanks,
Ujwal.
On 10/11/2017 3:50 PM, Ujwal Vangapally wrote:
Thanks for the review and suggestions Mandy, Roger.
kindly see my comments inline.
On 10/
Hi Ujwal,
Looks fine.
Please correct the copyright date in ProcessIdTest. A new file usually
has only the current year.
Thanks, Roger
On 10/20/17 2:07 AM, Ujwal Vangapally wrote:
kindly see the new webrev incorporating review comments.
webrev:
http://cr.openjdk.java.net/~uvangapally/web
Thanks for the review Roger, I will correct the copyright date.
Ujwal.
On 10/20/2017 7:37 PM, Roger Riggs wrote:
Hi Ujwal,
Looks fine.
Please correct the copyright date in ProcessIdTest. A new file
usually has only the current year.
Thanks, Roger
On 10/20/17 2:07 AM, Ujwal Vangapally w
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that doesn't
support this operation. RuntimeMXBean::getPid should specify when the
platform does not support this operation.
ProcessIdTest - can you also check if g
m: serviceability-dev [mailto:serviceability-dev-
> boun...@openjdk.java.net] On Behalf Of Ujwal Vangapally
> Sent: Freitag, 20. Oktober 2017 11:08
> To: serviceability-dev@openjdk.java.net; Mandy Chung
> ; Roger Riggs
> Subject: Re: RFR : JDK-8044122 MBean access to the PID
>
> kind
: Friday, October 20, 2017 4:42:00 PM
To: Ujwal Vangapally; Roger Riggs
Cc: serviceability-dev
Subject: Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that doesn't
su
:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that doesn't
support this oper
4:42:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that doesn't
support this oper
--
http://bernd.eckenfels.net
From: serviceability-dev on
behalf of mandy chung
Sent: Tuesday, October 24, 2017 7:20:27 PM
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR : JDK-8044122 MBean access to the PID
The permission check should be done
: JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that
doesn't
support this operation. RuntimeMXBean::getPid should specify when the
platform does not support this oper
mandy
chung
*Sent:* Friday, October 20, 2017 4:42:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on p
*From:* serviceability-dev
on behalf of mandy
chung
*Sent:* Friday, October 20, 2017 4:42:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with
, October 20, 2017 4:42:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that
doesn't
support
:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the call
with doPrivileged. Process::pid can throw UOE on platform that
doesn't
support this operation. RuntimeMXBean::getPid should specify
when the
platform doe
:* Friday, October 20, 2017 4:42:00 PM
*To:* Ujwal Vangapally; Roger Riggs
*Cc:* serviceability-dev
*Subject:* Re: RFR : JDK-8044122 MBean access to the PID
Process::pid may throw SecurityException. You have to wrap the
call
with doPrivileged. Process::pid can throw UOE on platform that
doesn
On 10/30/17 9:50 AM, Ujwal Vangapally wrote:
Hi Mandy,
yes, this makes it more clear.
kindly take a look at new webrev.
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.04/
Looks good.
thanks
Mandy
Thanks for the Review Roger, Mandy.
Ujwal.
On 10/31/2017 4:09 AM, mandy chung wrote:
On 10/30/17 9:50 AM, Ujwal Vangapally wrote:
Hi Mandy,
yes, this makes it more clear.
kindly take a look at new webrev.
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.04/
Hi,
kindly take a look at latest changes.
webrev:
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.05/
Thanks,
Ujwal.
On 10/31/2017 9:20 AM, Ujwal Vangapally wrote:
Thanks for the Review Roger, Mandy.
Ujwal.
On 10/31/2017 4:09 AM, mandy chung wrote:
On 10/30/17 9:5
Looks good to me.
Please do make docs target to verify.
Mandy
On 11/6/17 9:34 PM, Ujwal Vangapally wrote:
Hi,
kindly take a look at latest changes.
webrev:
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.05/
Thanks,
Ujwal.
On 10/31/2017 9:20 AM, Ujwal Vangapally wrot
Thanks for the review Mandy,
built image and verified everything is as expected.
Ujwal.
On 11/7/2017 11:45 AM, mandy chung wrote:
Looks good to me.
Please do make docs target to verify.
Mandy
On 11/6/17 9:34 PM, Ujwal Vangapally wrote:
Hi,
kindly take a look at latest changes.
webrev:
On 10/10/2017 12:47, Ujwal Vangapally wrote:
Kindly review the changes made.
https://bugs.openjdk.java.net/browse/JDK-8044122
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.00/
CSR : https://bugs.openjdk.java.net/browse/JDK-8189091
The term "PID" is not defined i
Thanks for the review Alan,
will make that change in next webrev.
Ujwal.
On 10/10/2017 5:27 PM, Alan Bateman wrote:
On 10/10/2017 12:47, Ujwal Vangapally wrote:
Kindly review the changes made.
https://bugs.openjdk.java.net/browse/JDK-8044122
webrev :
http://cr.openjdk.java.net/~uvangapall
Hi Ujwal,
Could you please add a test-case to validate your changes? You can spawn
a new process and it can exchange its pid to its parent via
System.out/in or via sockets.
Also, VMManagementImpl:145, the change from getProcessId to getVmPid
seems unnecessary.
-Harsha
On Tuesday 10 Octob
Thanks for the review Harsha.
kindly see my comments inline.
On 10/10/2017 5:51 PM, Harsha Wardhana B wrote:
Hi Ujwal,
Could you please add a test-case to validate your changes? You can
spawn a new process and it can exchange its pid to its parent via
System.out/in or via sockets.
will it
On 10/10/17 4:47 AM, Ujwal Vangapally wrote:
Kindly review the changes made.
https://bugs.openjdk.java.net/browse/JDK-8044122
webrev :
http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.00/
RuntimeMXBean.java
@since is missing
Process::pid is long rather than int.
Hi Ujwal,
In the implementation RuntimeMXBean.java: 72: Include a message
"getProcessId" in the throw new Unsupported...
In the text and @return change "PID" to "process ID" as Alan suggested.
66: the @implSpec should be on its own line so the text starts on a new
line to make the source more
Thanks for the review and suggestions Mandy, Roger.
kindly see my comments inline.
On 10/10/2017 11:25 PM, Roger Riggs wrote:
Hi Ujwal,
In the implementation RuntimeMXBean.java: 72: Include a message
"getProcessId" in the throw new Unsupported...
In the text and @return change "PID" to "pr
28 matches
Mail list logo