Re: RFR 8037082: java/lang/instrument/NativeMethodPrefixAgent.java failing

2014-08-26 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 26 aug 2014, at 10:15, Jaroslav Bachorik wrote: > On 08/25/2014 08:37 PM, Staffan Larsen wrote: >> Thanks for taking on this one! >> >> The code looks good. Just two small things below. >> >> Have you tested with -Xverify:all, just to see if there are any byte

Re: RFR 8037082: java/lang/instrument/NativeMethodPrefixAgent.java failing

2014-08-26 Thread Jaroslav Bachorik
On 08/25/2014 08:37 PM, Staffan Larsen wrote: Thanks for taking on this one! The code looks good. Just two small things below. Have you tested with -Xverify:all, just to see if there are any byte code problems? I've re-run the tests with -Xverify:all and fixed one problem in the generated b

Re: RFR 8037082: java/lang/instrument/NativeMethodPrefixAgent.java failing

2014-08-25 Thread Staffan Larsen
Thanks for taking on this one! The code looks good. Just two small things below. Have you tested with -Xverify:all, just to see if there are any byte code problems? Could fix the auto-naming of the params in this code? 131 @Override 132 public void visit(int i, int i1

RFR 8037082: java/lang/instrument/NativeMethodPrefixAgent.java failing

2014-08-25 Thread Jaroslav Bachorik
Please, review the following test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8037082 Webrev: http://cr.openjdk.java.net/~jbachorik/8037082/webrev.00 As Staffan mentions in the issue comments - "The two tests NativeMethodPrefixAgent and RetransformAgent use their own byte code instru