Thanks Alan!
On 20 mar 2014, at 19:15, Alan Bateman wrote:
> On 20/03/2014 12:11, Staffan Larsen wrote:
>> :
>> Yes, that one was a bit messy. I cleaned it up and added some comments. Also
>> remove the SCCS workarounds.
>>
>> http://cr.openjdk.java.net/~sla/8037825/webrev.02/
>>
>>
> It's l
On 20/03/2014 12:11, Staffan Larsen wrote:
:
Yes, that one was a bit messy. I cleaned it up and added some comments. Also
remove the SCCS workarounds.
http://cr.openjdk.java.net/~sla/8037825/webrev.02/
It's looks okay and thanks for adding a comment.
-Alan
On 20 mar 2014, at 11:25, Alan Bateman wrote:
> On 20/03/2014 09:13, Staffan Larsen wrote:
>>
>> Thanks!
>>
>> Still need someone to look at the actual code changes.
>>
>>
> In webrev.01 then jdk/make/lib/ServiceabilityLibraries.gmk and
> src/solaris/native/sun/management/MacosxOperatingSys
On 20/03/2014 09:13, Staffan Larsen wrote:
Thanks!
Still need someone to look at the actual code changes.
In webrev.01 then jdk/make/lib/ServiceabilityLibraries.gmk and
src/solaris/native/sun/management/MacosxOperatingSystem.c are showing up
as new files, I can't tell why that is.
The code
Thanks!
Still need someone to look at the actual code changes.
/Staffan
On 20 mar 2014, at 09:49, Magnus Ihse Bursie
wrote:
> On 2014-03-19 17:47, Erik Joelsson wrote:
>> Build part looks good!
>
> Build part looks good to me to.
>
> /Magnus
>
On 2014-03-19 17:47, Erik Joelsson wrote:
Build part looks good!
Build part looks good to me to.
/Magnus
On 19 mar 2014, at 17:47, Erik Joelsson wrote:
> Build part looks good!
Thanks.
>
> Don't forget to push the closed generated configure.
I would have forgotten…
/Staffan
>
> /Erik
>
> On 2014-03-19 15:20, Staffan Larsen wrote:
>> Erik, Magnus,
>>
>> Thanks for the quick looks. Here is a
Build part looks good!
Don't forget to push the closed generated configure.
/Erik
On 2014-03-19 15:20, Staffan Larsen wrote:
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
http://cr.openjdk.java.net/~sla/8037825/webrev.01
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
http://cr.openjdk.java.net/~sla/8037825/webrev.01/root/
http://cr.openjdk.java.net/~sla/8037825/webrev.01/jdk/
Thanks,
/Staffan
On 19 mar 2014, at 14:03, Erik Joelsson wrote:
Hello,
Nice work! Removing warnings and enforcing them is definitely something
we like.
For the makefile change, ideally the new variable WARNINGS_ARE_ERRORS
should be set in configure. I would suggest flags.m4, in
FLAGS_SETUP_COMPILER_FLAGS_MISC. Also, instead of making the conditional
on
On 2014-03-19 13:30, Staffan Larsen wrote:
The serviceability libraries (as defined by jdk/make/lib/ServiceabilityLibraries.gmk)
should be compiled with "warnings as errors". To enable this all current
warnings need to be fixed.
The background for this is that we recently had a bug that could
The serviceability libraries (as defined by
jdk/make/lib/ServiceabilityLibraries.gmk) should be compiled with "warnings as
errors". To enable this all current warnings need to be fixed.
The background for this is that we recently had a bug that could have easily
been avoided if we had paid att
12 matches
Mail list logo
