Mandy Chung wrote:
CheckSomeMXBeanImplPackage.java
line 45-50 & 58-60: should be called unconditionally since they
should pass if java.management is present.
The method "check" checks that an MBean implementation must be from
"com.sun.management.internal", so even we look for an MXBean with
On 4/2/15 12:58 PM, Shanliang Jiang wrote:
Hi,
I have to ask the review again because I need to modify:
langtools/src/jdk.dev/share/classes/com/sun/tools/jdeps/Profile.java
The issue was found when langtools tests were added into my test list.
The new version is:
http://cr.openjdk.java.net/
Hi,
I have to ask the review again because I need to modify:
langtools/src/jdk.dev/share/classes/com/sun/tools/jdeps/Profile.java
The issue was found when langtools tests were added into my test list.
The new version is:
http://cr.openjdk.java.net/~sjiang/JDK-8042901/02/
which integrated
Looks good, thanks!
/Erik
On 2015-04-01 20:03, shanliang wrote:
Erik Joelsson wrote:
Hello,
(Adding build-dev since this touches makefiles and jigsaw-dev since
this touches modules.xml)
In general, the build changes look pretty good. I much appreciate
moving the OS specific source into OS
On 3/31/2015 9:39 AM, shanliang wrote:
Please review this fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8042901
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/
Thank you for doing this big change to separate com.sun.management
API from java.management module. Looking really g
Erik Joelsson wrote:
Hello,
(Adding build-dev since this touches makefiles and jigsaw-dev since
this touches modules.xml)
In general, the build changes look pretty good. I much appreciate
moving the OS specific source into OS specific source dirs. A few
notes however. Though I realize you f
Hi Shanliang,
Impressive work! I know how long it took you and how much
effort went into this!
This does look good.
One minor remark is that it might have been good to have a simple
mechanical rule to transform the name of the MBean concrete
implementation from the java.management module to the
Jaroslav Bachorik wrote:
Hi Shanliang,
Looks good! A lot of work here ...
Just a nit -
*
jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandInfo.java
- superfluous import @L28 (and the copyright year change)
Yes the import of L28 is unnecessary.
The copyri
Hi Shanliang,
Looks good! A lot of work here ...
Just a nit -
*
jdk/src/jdk.management/share/classes/com/sun/management/internal/DiagnosticCommandInfo.java
- superfluous import @L28 (and the copyright year change)
I suppose all reg-tests and related JCK tests are still passing.
-JB-
On 3
Hello,
(Adding build-dev since this touches makefiles and jigsaw-dev since this
touches modules.xml)
In general, the build changes look pretty good. I much appreciate moving
the OS specific source into OS specific source dirs. A few notes
however. Though I realize you followed existing patte
Please review this fix:
Bug: https://bugs.openjdk.java.net/browse/JDK-8042901
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8042901/00/
Some code within the module java.management is separated and moved to
the new module jdk.management, the new module takes the implementation
code for Oracle
11 matches
Mail list logo
