Thank you Serguei. I'll fix the indentation to 4 since that's the
coding style for Java (I like 2 better!)
Coleen
On 7/23/15 8:30 AM, serguei.spit...@oracle.com wrote:
The fix is good.
Nice test!
A couple of places with indent 2:
78 static void localSleep() {
79 try
The fix is good.
Nice test!
A couple of places with indent 2:
78 static void localSleep() {
79 try{
80 Thread.currentThread().sleep(10);//sleep for 10 ms
81 } catch(InterruptedException ie) {
82 }
83 }
119 for (int i
Hi Coleen,
On 7/23/15 4:49 AM, Coleen Phillimore wrote:
Hi Serguei,
On 7/23/15 2:35 AM, serguei.spit...@oracle.com wrote:
Coleen,
The fix looks good in general.
There is one more place where the same may need to be fixed.
It is in the function java_lang_StackTraceElement::create ():
1911
Hi Serguei,
On 7/23/15 2:35 AM, serguei.spit...@oracle.com wrote:
Coleen,
The fix looks good in general.
There is one more place where the same may need to be fixed.
It is in the function java_lang_StackTraceElement::create ():
1911 // Fill in source file name and line number.
1912 //
Coleen,
The fix looks good in general.
There is one more place where the same may need to be fixed.
It is in the function java_lang_StackTraceElement::create ():
1911 // Fill in source file name and line number.
1912 // Use specific ik version as a holder since the mirror might
1913
Dan, Thank you again for the quick code review.
On 7/22/15 8:57 PM, Daniel D. Daugherty wrote:
On 7/22/15 11:22 AM, Coleen Phillimore wrote:
Summary: Need to get source_file_name from the_class's constant pool
not previous version constant pool
open webrev at http://cr.openjdk.java.net/~co
On 7/22/15 11:22 AM, Coleen Phillimore wrote:
Summary: Need to get source_file_name from the_class's constant pool
not previous version constant pool
open webrev at http://cr.openjdk.java.net/~coleenp/8087315.01/
src/share/vm/classfile/javaClasses.cpp
So in the new code, you avoid the use
Summary: Need to get source_file_name from the_class's constant pool not
previous version constant pool
open webrev at http://cr.openjdk.java.net/~coleenp/8087315.01/
bug link https://bugs.openjdk.java.net/browse/JDK-8087315
Tested with added test (yay!), RBT (remote build and test),
vm.redefi
