Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-12 Thread Jaroslav Bachorik
On 07/11/2014 11:28 PM, Jeremy Manson wrote: Hi Jaroslav, I haven't written many Streams yet, so perhaps I'm missing something obvious / well-known. Streams can replace the original code in an obvious way (filter the elements of list based on whether they are contained in map.values()), but I'm

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-11 Thread Jaroslav Bachorik
Hi Jeremy, On 05/08/2014 08:56 PM, Jeremy Manson wrote: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did this wrong, I apologize. Basically, the debugger becomes very slow if there are a lot of methods in a class. This can happen (O(thousands)) if you are u

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-09 Thread David Holmes
I'm good with it too - as Erik is happy with it. So Reviewed. David On 10/07/2014 3:56 AM, Erik Gahlin wrote: Looks good! Not a Reviewer, but I can sponsor it. Erik Jeremy Manson skrev 08/05/14 20:56: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did thi

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-07-09 Thread Erik Gahlin
Looks good! Not a Reviewer, but I can sponsor it. Erik Jeremy Manson skrev 08/05/14 20:56: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did this wrong, I apologize. Basically, the debugger becomes very slow if there are a lot of methods in a class. This

Re: RFR: 8042778: Getting all visible methods in ReferenceTypeImpl is slow

2014-05-08 Thread David Holmes
Hi Jeremy, On 9/05/2014 4:56 AM, Jeremy Manson wrote: I'm testing out my newly acquired OpenJDK authorship with something simple. If I did this wrong, I apologize. Basically, the debugger becomes very slow if there are a lot of methods in a class. This can happen (O(thousands)) if you are usi