Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Erik Gahlin
Looks good, jconsole now compile in Eclipse! Erik Staffan Larsen skrev 2015-03-12 13:54: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version sys

RE: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Iris Clark
Hi, Staffan. > bug: https://bugs.openjdk.java.net/browse/JDK-8075056 > webrev: http://cr.openjdk.java.net/~sla/8075056/webrev.00/ > Looks good. I'm always happy to see changes where complexity is reduced. Thanks, iris

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Mandy Chung
On 3/12/2015 5:54 AM, Staffan Larsen wrote: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version system property at runtime. bug: https://bugs.o

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Magnus Ihse Bursie
On 2015-03-12 13:54, Staffan Larsen wrote: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version system property at runtime. bug: https://bugs.ope

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Alan Bateman
On 12/03/2015 12:54, Staffan Larsen wrote: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version system property at runtime. bug: https://bugs.ope

Re: RFR: JDK-8075056 Remove Version.java.template from jconsole

2015-03-12 Thread Erik Joelsson
Looks good. /Erik On 2015-03-12 13:54, Staffan Larsen wrote: The build for jconsole currently takes a template file and inserts the version number of the build into the file. We can simplify this by removing the template file and reading the java.runtime.version system property at runtime. b