Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Stefan Karlsson
Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Some comments below: On 05/21/2013 12:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Net

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/20/2013 11:39 PM, David Holmes wrote: Hi Coleen, On 21/05/2013 8:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Basic VM changes look fine to me. Thanks! Net footprint change is zero except that these fields are in Java

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Staffan Larsen
Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA changes to code that I don't know is used.

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/21/2013 05:11 AM, Stefan Karlsson wrote: Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Yes, I'm hoping for someone to review the SA changes. Some comments below: On 05/21/2013 12:39 AM, Coleen

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Stefan Karlsson
On 21 maj 2013, at 16:12, Coleen Phillimore coleen.phillim...@oracle.com wrote: On 05/21/2013 05:11 AM, Stefan Karlsson wrote: Hi Coleen, Good to see all these oops moving to the mirrors. I think the changes look good. I let someone else review the SA changes Yes, I'm hoping for

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
Thanks Stefan, I have 2 small comments. On 05/21/2013 10:38 AM, Stefan Karlsson wrote: On 21 maj 2013, at 16:12, Coleen Phillimore coleen.phillim...@oracle.com wrote: On 05/21/2013 05:11 AM, Stefan Karlsson wrote: Hi Coleen, Good to see all these oops moving to the mirrors. I think the

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-21 Thread Coleen Phillimore
On 05/21/2013 09:18 AM, Staffan Larsen wrote: Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with InstanceKlass size which is in fixed size space with UseCompressedKlassPointers. Included serviceability because there were SA

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. dl On 05/20/2013 03:39 PM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers,

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Coleen Phillimore
On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We actually use the protection domain and init_lock from

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
Hi Coleen, On 21/05/2013 8:39 AM, Coleen Phillimore wrote: Summary: Inject protection_domain, signers, init_lock into java_lang_Class Basic VM changes look fine to me. Net footprint change is zero except that these fields are in Java heap rather than metaspace. This helps a little with

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
On 5/20/2013 7:50 PM, Coleen Phillimore wrote: On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
On 21/05/2013 12:50 PM, Coleen Phillimore wrote: On 5/20/2013 8:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of java.lang.Class, allowing, for example, getProtectionDomain0() to be a simple Java method instead of a native method. We

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Ioi Lam
But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean Long wrote: It seems like you could take this opportunity to make these declared fields of

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread Dean Long
Right, unless there is a way to inject them conditionally. dl On 5/20/2013 9:02 PM, Ioi Lam wrote: But if you move these fields into Class.java (in JDK8), then hsx25 will not run on JDK7 anymore, unless these fields are also added in Class.java in JDK7. - Ioi On 05/20/2013 05:42 PM, Dean

Re: RFR 8003421: NPG: Move oops out of InstanceKlass into mirror

2013-05-20 Thread David Holmes
On 21/05/2013 2:50 PM, Dean Long wrote: Right, unless there is a way to inject them conditionally. You can inject them conditionally based on the JRE version, but then why bother moving to the Java level if you will still need the code in the VM ? On 5/20/2013 9:02 PM, Ioi Lam wrote: But