Re: Request for review:8021948:Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool index

2013-08-22 Thread serguei.spit...@oracle.com
I'm looking at it but it is time for a Town Hall meeting. Thanks, Serguei On 8/22/13 5:54 AM, Staffan Larsen wrote: I don't claim to understand this, but if I remove the changes to jvmtiRedefineClasses.cpp in [1] the test passes. My guess is that there is no need to change the source file

Re: Request for review:8021948:Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool index

2013-08-22 Thread Jiangli Zhou
Thanks, Serguei! Jiangli On 08/22/2013 09:00 AM, serguei.spit...@oracle.com wrote: I'm looking at it but it is time for a Town Hall meeting. Thanks, Serguei On 8/22/13 5:54 AM, Staffan Larsen wrote: I don't claim to understand this, but if I remove the changes to jvmtiRedefineClasses.cpp in

Re: Request for review:8021948:Change InstanceKlass::_source_file_name and _generic_signature from Symbol* to constant pool index

2013-08-22 Thread Jiangli Zhou
Hi Staffan, Thanks so much for looking into this. On 08/22/2013 05:54 AM, Staffan Larsen wrote: I don't claim to understand this, but if I remove the changes to jvmtiRedefineClasses.cpp in [1] the test passes. My guess is that there is no need to change the source file name cp index in