Jaroslav,
I'll do it.
-Dmitry
On 2012-10-15 20:17, Jaroslav Bachorik wrote:
> Thank you guys for the reviews! I would like to kindly ask someone with
> the committer rights to sponsor this fix and push the change.
>
>
> Thanks!
>
> -JB-
>
> On 10/15/2012 04:15 PM, Rickard Bäckman wrote:
>>
Thank you guys for the reviews! I would like to kindly ask someone with
the committer rights to sponsor this fix and push the change.
Thanks!
-JB-
On 10/15/2012 04:15 PM, Rickard Bäckman wrote:
> Looks good!
>
> /R
>
> On Oct 15, 2012, at 2:14 PM, Jaroslav Bachorik wrote:
>
>> On 10/15/2012
Looks good!
/R
On Oct 15, 2012, at 2:14 PM, Jaroslav Bachorik wrote:
> On 10/15/2012 01:45 PM, David Holmes wrote:
>> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote:
>>> On 10/15/2012 04:19 AM, David Holmes wrote:
I think your changes now go further than needed. The original code uses
Looks good to me.
Hopefully someone else will chime in too :)
Thanks,
David
On 15/10/2012 10:14 PM, Jaroslav Bachorik wrote:
On 10/15/2012 01:45 PM, David Holmes wrote:
On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote:
On 10/15/2012 04:19 AM, David Holmes wrote:
I think your changes now go fu
On 10/15/2012 01:45 PM, David Holmes wrote:
> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote:
>> On 10/15/2012 04:19 AM, David Holmes wrote:
>>> I think your changes now go further than needed. The original code uses
>>> a dual synchronization scheme:
>>>
>>> a) it synchronizes most of the Timer me
On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote:
On 10/15/2012 04:19 AM, David Holmes wrote:
I think your changes now go further than needed. The original code uses
a dual synchronization scheme:
a) it synchronizes most of the Timer methods
b) it also uses a thread-safe Hashtable
This means tha
Thanks David,
On 10/15/2012 04:19 AM, David Holmes wrote:
> Hi Jaroslav,
>
> I think your changes now go further than needed. The original code uses
> a dual synchronization scheme:
>
> a) it synchronizes most of the Timer methods
> b) it also uses a thread-safe Hashtable
>
> This means that no
Hi Jaroslav,
I think your changes now go further than needed. The original code uses
a dual synchronization scheme:
a) it synchronizes most of the Timer methods
b) it also uses a thread-safe Hashtable
This means that not all of the Timer methods need to be synchronized
because the only threa
The updated webrev is now at http://btrace.kenai.com/webrevs/JDK-6809322/
I am sorry for this chaos with webrev locations but its not that easy to
work efficiently without an OpenJDK username :/
-JB-
On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote:
> On Fri 12 Oct 2012 04:44:31 AM CEST, David Ho
On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote:
> Hi Jaroslav,
>
>
> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote:
>> Dmitry has put the webrev on the public CR -
>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/
>>
>>
>> Thanks!
>>
>> -JB-
>>
>> On 10/10/20
Hi Jaroslav,
On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote:
Dmitry has put the webrev on the public CR -
http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/
Thanks!
-JB-
On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote:
I am looking for a review and a sponsor.
The
Dmitry has put the webrev on the public CR -
http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/
Thanks!
-JB-
On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote:
> I am looking for a review and a sponsor.
>
> The issue is about some javax.management.timer.Timer notificatio
Thanks, could you update with this webrev? I've fixed the problem with
hgmq <-> webrev where the file copy is mistakenly marked as a file move.
Thanks,
-JB-
On 10/10/2012 08:32 PM, Dmitry Samersoff wrote:
> Jaroslav,
>
> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/
Jaroslav,
The fix looks good for me.
-Dmitry
On 2012-10-10 22:25, Jaroslav Bachorik wrote:
> On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote:
>> Jaroslav,
>>
>> Not able to open it as a webrev - only list of files.
>>
>> E-mail me the webrev and I'll put it to
>> file:///opt/src/jdks
Jaroslav,
http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/
-Dmitry
On 2012-10-10 22:25, Jaroslav Bachorik wrote:
> On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote:
>> Jaroslav,
>>
>> Not able to open it as a webrev - only list of files.
>>
>> E-mail me the w
Jaroslav,
Not able to open it as a webrev - only list of files.
E-mail me the webrev and I'll put it to
cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/N
-Dmitry
On 2012-10-10 18:39, Jaroslav Bachorik wrote:
> I am sorry for the webrev URL - a stale clipboard :(
>
> The correct webrev U
I am sorry for the webrev URL - a stale clipboard :(
The correct webrev URL is
https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322
-JB-
On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote:
> I am looking for a review and a sponsor.
>
> The issue is about some javax.manageme
17 matches
Mail list logo
