Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

On 6/18/13 8:35 PM, Dan Xu wrote: Thanks for your feedbacks. I have updated my changes and uploaded to webrev at http://cr.openjdk.java.net/~dxu/8016592/webrev.01/. I have tested the fix with the jck tests and regression tests. And the results look good. Thanks! Hi Dan, This looks good! (I

Re: Codereview for JDK-8016221: A unit test should not use a fixed port to run a jmx connector (JDCMD MBean Tests)

Hi Shanliang, This change looks good. There's probably a subtle difference between invoking a command through a user created JMXConnectorServer as opposed as sending it through the default agent - but I don't think that's what matters here. cheers, -- daniel On 6/12/13 9:56 AM, shanliang wrote

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

On 19/06/2013 08:18, Daniel Fuchs wrote: On 6/18/13 8:35 PM, Dan Xu wrote: Thanks for your feedbacks. I have updated my changes and uploaded to webrev at http://cr.openjdk.java.net/~dxu/8016592/webrev.01/. I have tested the fix with the jck tests and regression tests. And the results look go

hg: jdk8/tl/jdk: 7188658: Add possibility to disable client initiated renegotiation

Changeset: a76858faad59 Author:xuelei Date: 2013-06-19 02:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a76858faad59 7188658: Add possibility to disable client initiated renegotiation Reviewed-by: weijun, wetmore ! src/share/classes/sun/security/ssl/Handshaker.java ! src

hg: jdk8/tl/langtools: 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits

Changeset: 6d3b33aea370 Author:vromero Date: 2013-06-19 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6d3b33aea370 8006981: javac, method toString() of class ...javac.code.Flags doesn't print all the flag bits Reviewed-by: jjg ! src/share/classes/com/sun/tools/

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 22337da71eca Author:chegar Date: 2013-06-19 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/22337da71eca 8017044: anti-delta fix for 8015402 Reviewed-by: alanb ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java ! src/share/classes/j

hg: jdk8/tl/langtools: 2 new changesets

Changeset: be62183f938a Author:chegar Date: 2013-06-19 11:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be62183f938a 8017045: anti-delta fix for 8013789 Reviewed-by: alanb ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/jav

Re: RFR: 8010278 SA: provide mechanism for using an alternative SA debugger back-end.

Hi Staffan -- And apologies from me for the slow turnaround. 8-) Thanks for the suggestions, implementing them all. http://cr.openjdk.java.net/~kevinw/8010278/webrev.02/ Also adding the same kind of change to the HSDB tool, a few changes there to get the gui closing without using System.exit

hg: jdk8/tl/jdk: 4837946: Faster multiplication and exponentiation of large integers; ...

Changeset: 9b802d99cb52 Author:bpb Date: 2013-06-19 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9b802d99cb52 4837946: Faster multiplication and exponentiation of large integers 4646474: BigInteger.pow() algorithm slow in 1.4.0 Summary: Implement Karatsuba and 3-way T

hg: jdk8/tl/jdk: 6 new changesets

Changeset: e7ece2dbdc70 Author:sla Date: 2013-06-10 11:33 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7ece2dbdc70 8005008: Add Java Flight Recorder Phase II Reviewed-by: erikj Contributed-by: Karen Kinnear , Bengt Rutisson , Calvin Cheung , Erik Gahlin , Erik Helin , Je

Re: RFR JDK-8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

Thank you all for the review and good feedback. I am pushing it now. -Dan On 06/19/2013 02:15 AM, Alan Bateman wrote: On 19/06/2013 08:18, Daniel Fuchs wrote: On 6/18/13 8:35 PM, Dan Xu wrote: Thanks for your feedbacks. I have updated my changes and uploaded to webrev at http://cr.openjdk.j

hg: jdk8/tl/hotspot: 5 new changesets

Changeset: d0add7016434 Author:amurillo Date: 2013-06-07 09:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0add7016434 8016078: new hotspot build - hs25-b37 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f2110083203d Author:sla Date: 2013-06-10 11:3

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 6/17/2013 1:01 PM, Chris Hegarty wrote: On 06/17/2013 08:08 PM, Kurchi Hazra wrote: - Maybe a webrev helps: http://cr.openjdk.java.net/~khazra/8016576/webrev.01/ Looks fine, but trivially remove the unnecessary null check in equa

Re: Code Review Request: 8016576: Overrides warnings in jdi and jconsole

On 19/06/2013 20:05, Kurchi Hazra wrote: On 6/17/2013 1:01 PM, Chris Hegarty wrote: On 06/17/2013 08:08 PM, Kurchi Hazra wrote: - Maybe a webrev helps: http://cr.openjdk.java.net/~khazra/8016576/webrev.01/ Looks fine, but trivially

hg: jdk8/tl/jdk: 8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java

Changeset: f6d72c4f6bf1 Author:dxu Date: 2013-06-19 13:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6d72c4f6bf1 8016592: Clean-up Javac Overrides Warnings In javax/management/NotificationBroadcasterSupport.java Summary: Add hashCode() methods to ListenerInfo and Wildca

hg: jdk8/tl/jdk: 8016576: Overrides warnings in jdi and jconsole

Changeset: de6b93fd6d23 Author:khazra Date: 2013-06-19 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de6b93fd6d23 8016576: Overrides warnings in jdi and jconsole Summary: Implement hashCode() in classes emitting warnings Reviewed-by: alanb, chegar ! src/share/classes/

hg: jdk8/tl/jdk: 8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java

Changeset: e1b18a666f76 Author:khazra Date: 2013-06-19 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b18a666f76 8016698: Cleanup overrides warning in sun/tools/ClassDeclaration.java Summary: Override Object.hashCode() Reviewed-by: alanb, chegar ! src/share/classes/s

hg: jdk8/tl/langtools: 8016610: javac, add new internal symbols to make operator resolution faster

Changeset: be10ac0081b2 Author:vromero Date: 2013-06-19 22:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/be10ac0081b2 8016610: javac, add new internal symbols to make operator resolution faster Reviewed-by: jjg Contributed-by: [email protected] ! src/s

hg: jdk8/tl/jdk: 7025238: HttpURLConnection does not handle URLs with an empty path component.

Changeset: 2b156531b7eb Author:arieber Date: 2013-06-19 17:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2b156531b7eb 7025238: HttpURLConnection does not handle URLs with an empty path component. Summary: Prepend a '/' to file when path is empty Reviewed-by: chegar, khazr

hg: hsx/hotspot-rt/hotspot: 8014326: [OSX] All libjvm symbols are exported

Changeset: 91acb82a8b7a Author:dholmes Date: 2013-06-19 13:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/91acb82a8b7a 8014326: [OSX] All libjvm symbols are exported Summary: Add support for a MacOS X compatible form of the libjvm mapfile. Reviewed-by: dcubed, r