hg: jdk8/tl/jdk: 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010

Changeset: 914c29c10bce Author:okutsu Date: 2013-10-02 15:31 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/914c29c10bce 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010 Reviewed-by: peytoia ! src/share/classes/java/util/GregorianCalendar.java

Re: RFR (S): 8016845: SA is unable to use hsdis on windows

Looks good! Thanks, /Staffan On 20 sep 2013, at 16:29, Fredrik Arvidsson wrote: > Please help me review this: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8016845 > Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8016845/webrev.00/ >

hg: jdk8/tl/jdk: 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl

Changeset: 368172cb6dc5 Author:coffeys Date: 2013-10-02 09:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5 8024952: ClassCastException in PlainSocketImpl.accept() when using custom socketImpl Reviewed-by: chegar ! src/windows/classes/java/net/PlainSocketImpl.

RFR 6523160: RuntimeMXBean.getUptime() returns negative values

Hello, currently the JVM uptime reported by the RuntimeMXBean is based on System.currentTimeMillis() which makes it susceptible to changes of the OS time (eg. changing timezone, NTP synchronization etc.). The uptime should not depend on the system time and should be calculated using a monoton

Re: RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

Hi Fredrik, Looks great! Thanks for fixing this, /peter On Sep 20, 2013, at 2:35 PM, Fredrik Arvidsson wrote: > Hi > > Please help me and review the changes below: > > Webrev: http://cr.openjdk.java.net/~allwin/farvidss/6313383/webrev.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-631

Re: RFR (S): 8016845: SA is unable to use hsdis on windows

Fredrik, On 09/20/2013 04:29 PM, Fredrik Arvidsson wrote: Please help me review this: Bug: https://bugs.openjdk.java.net/browse/JDK-8016845 Webrev: http://cr.openjdk.java.net/~allwin/farvidss/8016845/webrev.00/ the change look

Re: RFR 6523160: RuntimeMXBean.getUptime() returns negative values

Looks good! Thanks, /Staffan On 2 okt 2013, at 10:47, Jaroslav Bachorik wrote: > Hello, > > currently the JVM uptime reported by the RuntimeMXBean is based on > System.currentTimeMillis() which makes it susceptible to changes of the OS > time (eg. changing timezone, NTP synchronization etc.)

Re: RFR (S): JDK-8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes

Hi and thanks for all your comments. I have simplified the code in *instanceKlass.cpp* like suggested and here is a new webrev: http://cr.openjdk.java.net/~allwin/farvidss/8024423/webrev.01/ Regarding the need to synchronize t

Re: serviceability-dev Digest, Vol 71, Issue 7

est system didn't like that kind of heap sizes and ultimately failed (OOM > and sometimes timeout). The test should be reintroduced once we can reliably > support such tests in the test system. > > Thanks 'allwin' for hosting my review :) > > Cheers > /Fredrik --

hg: jdk8/tl/jdk: 8022666: java.util.Calendar.set(int, int, int, int, int, int) documentation typo

Changeset: 82e3150778e0 Author:okutsu Date: 2013-10-02 17:57 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82e3150778e0 8022666: java.util.Calendar.set(int,int,int,int,int,int) documentation typo Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java

Re: jmx-dev RFR: 8024613 javax/management/remote/mandatory/connection/RMIConnector_NPETest.java failing intermittently

On 20.9.2013 14:54, shanliang wrote: Jaroslav, It is a good idea to use the RMI Testlibrary. Better to call: agent.close(); at Line 55, close the RMIRegistry (rmid.shutdown(rmidPort) Line 55) does not ensure the JMX connector doing full clean, it is always better to do clean within a

[ping] Re: jmx-dev RFR: 8004926 sun/management/jmxremote/bootstrap/CustomLauncherTest.sh oftenly times out

On 19.9.2013 16:33, Jaroslav Bachorik wrote: The updated webrev: http://cr.openjdk.java.net/~jbachorik/8004926/webrev.03 I've moved some of the functionality to the testlibrary. -JB - On 12.9.2013 17:31, Jaroslav Bachorik wrote: On 09/12/2013 05:13 PM, Dmitry Samersoff wrote: Jaroslav, Cust

[ping] Re: RFR: 8022220 Intermittent test failures in javax/management/remote/mandatory/connection/RMIConnectionIdTest.java

On 11.9.2013 17:20, Jaroslav Bachorik wrote: On 09/11/2013 05:06 PM, shanliang wrote: The fix looks OK for me. I am wondering that in case of loopback address, is it better to always using "127.0.0.1" to generate a connectionId? this will make sure to have a unique id. I am afraid we are gett

hg: jdk8/tl/jdk: 8025535: Unsafe typecast in java.util.stream.SortedOps

Changeset: e1b04fd49204 Author:psandoz Date: 2013-10-01 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b04fd49204 8025535: Unsafe typecast in java.util.stream.SortedOps Reviewed-by: mduigou, chegar ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util

Re: jmx-dev RFR: 8022220 Intermittent test failures in javax/management/remote/mandatory/connection/RMIConnectionIdTest.java

Jaroslav, As a far as loopback address could be resolved to any of 127.0.0.0/8 client and server have to use the same loopback address. Generally speaking it's not required for 127.0.1.1 to be able to talk to 127.0.0.1 and we are in risk to get a weird fail instead of clear error message. -Dmitr

RE: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Dan You have my thumbs up changes look good > -Original Message- > From: David Holmes > Sent: Tuesday, October 01, 2013 8:53 PM > To: Daniel Daugherty > Cc: [email protected]; build-dev; > [email protected] > Subject: Re: code review round 0 for Ful

hg: jdk8/tl/jdk: 6696975: JTop plugin fails if connected readonly to target JVM

Changeset: 3bb89c509d59 Author:egahlin Date: 2013-10-01 17:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3bb89c509d59 6696975: JTop plugin fails if connected readonly to target JVM Reviewed-by: mchung, jbachorik, sla, sjiang ! src/share/demo/management/JTop/JTop.java

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

David, Thanks for the thorough review (as always)! It will take me a while to process all the comments, but another reply will be forthcoming. Dan On 10/1/13 8:52 PM, David Holmes wrote: Hi Dan, Overall thumbs up. A couple of minor issues that need fixing. A few meta-comments (I hate seein

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Ron, Thanks for the review. Dan On 10/2/13 8:44 AM, Ron Durbin wrote: Dan You have my thumbs up changes look good -Original Message- On 21/09/2013 1:36 PM, Daniel D. Daugherty wrote: Greetings, I have the initial support for Full Debug Symbols (FDS) on MacOS X done and ready fo

hg: jdk8/tl/langtools: 8023679: Improve error message for '_' used as a lambda parameter name

Changeset: 1e6088da1740 Author:vromero Date: 2013-10-02 17:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e6088da1740 8023679: Improve error message for '_' used as a lambda parameter name Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/parser/Jav

hg: jdk8/tl/jdk: 8025694: Rename getStrongSecureRandom based on feedback; ...

Changeset: a6ac824b463d Author:wetmore Date: 2013-10-02 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a6ac824b463d 8025694: Rename getStrongSecureRandom based on feedback 8014838: getStrongSecureRandom() should require at least one implementation Reviewed-by: mullan, d

Re: RR(S): JDK-8022616 u4 should not be used as a type for thread_id

Serguei, I run all runtime tests on MAC OS X - lots of tests fails[1], but this numners is exactly the same with or without my fix. I'd considered it as a good result and plan to push changes tomorrow. Do you have any concerns? [1] TOTAL TESTS IN RUN: 1043 TEST PASS: 502; 48% rate TEST FAIL: 54

hg: hsx/hotspot-rt/hotspot: 8025671: Test name changed, test list not updated. Test6878713.sh

Changeset: d574419c5372 Author:mseledtsov Date: 2013-10-02 15:17 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d574419c5372 8025671: Test name changed, test list not updated. Test6878713.sh Summary: Removed the obsolete test from the test group file Reviewed-by: s

Re: RR(S): JDK-8022616 u4 should not be used as a type for thread_id

Dmitry, Thank you for running the tests, it is good to be safe. In general it is Ok to judge on the fix quality basing on the test result differences. But I'm surprised the TEST FAIL rate is so high (is it normal for Mac OS?). You may want to take a look how many of them are unexpected. It is

Re: RR(S): JDK-8022616 u4 should not be used as a type for thread_id

Serguei, UTE attempts to run windows specific (dotnet) tests[1] and it cause huge failure rate. I'd contacted SQE (Leonid) and he is in process of investigation whether it is result of wrong MAC setup or bug in latest UTE. I'd checked - none of these failures is related to my fix. [1] "/User

Re: RR(S): JDK-8022616 u4 should not be used as a type for thread_id

Ok. Thanks, Dmitry! Serguei On 10/2/13 3:40 PM, Dmitry Samersoff wrote: Serguei, UTE attempts to run windows specific (dotnet) tests[1] and it cause huge failure rate. I'd contacted SQE (Leonid) and he is in process of investigation whether it is result of wrong MAC setup or bug in latest

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 931f105563c5 Author:coleenp Date: 2013-10-02 13:02 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/931f105563c5 8025569: -XX:+CheckUnhandledOops crashes on Windows Summary: Disable CHECK_UNHANDLED_OOPS in fastdebug builds for JDK 8 on WIndows 32 & 64 bit

hg: jdk8/tl/jdk: 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions

Changeset: cb8946eda85b Author:emc Date: 2013-10-02 19:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb8946eda85b 8020981: Update methods of java.lang.reflect.Parameter to throw correct exceptions Summary: Fix behavior of parameter reflection API for malformed class file

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 2bd38d594b9a Author:dsamersoff Date: 2013-10-02 20:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2bd38d594b9a 8025283: Nits in os_bsd file breaks compilation of open hotspot Summary: Couple of nits in os_bsd.cpp brake compilation of open hotspot on

hg: hsx/hotspot-rt/hotspot: 2 new changesets

Changeset: 5705c7ee6dd7 Author:dsamersoff Date: 2013-10-02 22:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5705c7ee6dd7 8025250: SA: Sync linux and bsd versions of ps_core file Summary: linux/ps_core.c and bsd/ps_core.c share most of code, but it has differen