Looks good! But I wonder why there is a shell script involved. Couldn't this be
just a straightforward java file with several @run tags?
Thanks,
/Staffan
On 11 okt 2013, at 20:02, Stefan Karlsson wrote:
> On 10/11/13 7:44 PM, Coleen Phillimore wrote:
>>
>> Stefan,
>>
>> I added a check about
The fix looks good, but I have a problem with the ROUNDUP_PAGE macro. First, I
don't like having macros defined in the middle of a method. Second, the
definition of the macro includes the value of a local variable which is a bit
hairy. Can't you just ROUNDUP directly in the four places it's need
Looks fine.
-JB-
On 11.10.2013 14:32, Peter Allwin wrote:
Thanks for the feedback, good points!
I've put an updated webrev here:
http://cr.openjdk.java.net/~allwin/8004183/webrev.01/
Changes:
boolean instead of Boolean
no longer sets worker as daemon
Regards,
/peter
On Oct 11, 20
Changeset: 9f8bfdd99129
Author:dfuchs
Date: 2013-10-14 10:42 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f8bfdd99129
8024704: Improve API documentation of ClassLoader and ServiceLoader with
respect to enumeration of resources.
Reviewed-by: alanb, psandoz, mchung
! src/s
Changeset: de8c803d4958
Author:aefimov
Date: 2013-10-13 13:50 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/de8c803d4958
8008733: Psr:perf:osb performance regression (18%) in wss_bodyenc
Reviewed-by: alanb, shade
! src/com/sun/org/apache/xpath/internal/XPathContext.java
Changeset: 077237e4613f
Author:tyan
Date: 2013-10-14 11:47 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/077237e4613f
8023555: test/java/net/Socks/SocksProxyVersion.java fails when machine name is
localhost
Reviewed-by: chegar, alanb
! test/java/net/Socks/SocksProxyVersion
On 2013-10-14 09:42, Staffan Larsen wrote:
Looks good!
Thanks, Staffan.
But I wonder why there is a shell script involved. Couldn't this be
just a straightforward java file with several @run tags?
Probably. I'd rather not change that now.
thanks,
StefanK
Thanks,
/Staffan
On 11 okt 201
Hi,
Could I please have a review of this fix.
An empty string is returned if the thread name is null. The protocol
should be updated to support INVALID_STRING for the Thread Reference
Command <#Error_INVALID_STRING>, but that is a larger effort and
probably better to do when fixing other prot
Changeset: f15a0087181e
Author:stefank
Date: 2013-10-14 14:28 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15a0087181e
7196801: NPG: Fix java/lang/management/MemoryMXBean/LowMemoryTest2
Reviewed-by: coleenp, sla
Contributed-by: [email protected], coleen.phillim...
Looks good to me. (not a reviewer)
A small nit - in the test the copyright year should be only 2013
(instead of "2003, 2013")
-JB-
On 14.10.2013 14:44, Erik Gahlin wrote:
Hi,
Could I please have a review of this fix.
An empty string is returned if the thread name is null. The protocol
shou
Hello, Thomas. Did you see this simple diff?
Original Message
Subject:Re: Fix to 8025925
Date: Wed, 9 Oct 2013 09:04:20 +0200
From: Staffan Larsen
To: [email protected], Thomas Schatzl
CC: [email protected]
serviceability-dev@openjd
On 10.10.2013 13:15, Staffan Larsen wrote:
On 10 okt 2013, at 13:02, Jaroslav Bachorik
wrote:
On 10.10.2013 05:44, David Holmes wrote:
On 10/10/2013 4:12 AM, Staffan Larsen wrote:
On 9 okt 2013, at 16:19, Jaroslav Bachorik
wrote:
On 9.10.2013 16:10, Staffan Larsen wrote:
There is now
Hi,
On Mon, 2013-10-14 at 17:11 +0400, [email protected] wrote:
> Hello, Thomas. Did you see this simple diff?
no :) I am not on servicability-dev. Thanks for making me aware of
this.
> Looks good to me, but I'd like Thomas' opinion as well.
>
> Thanks,
> /Staffan
>
> On 9 okt 201
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actual
"extension" used for the "debuginfo" file so that we don't need macosx
conditionals as m
Please, review the following simple change.
The test times out on slower machines and I was able to reproduce the
failure even on a normally fast machine using the fastdebug build. The
timeout does not occur on every run - more like once in 10-15 runs.
There is nothing really wrong with the t
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure what happened here.
I somehow missed/lost two 1-line
On 14/10/2013 16:21, Jaroslav Bachorik wrote:
Please, review the following simple change.
The test times out on slower machines and I was able to reproduce the
failure even on a normally fast machine using the fastdebug build. The
timeout does not occur on every run - more like once in 10-15 r
Changeset: d69f4ac43d64
Author:lana
Date: 2013-10-08 14:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d69f4ac43d64
Merge
Changeset: cdc3577cba0b
Author:lana
Date: 2013-10-11 00:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/cdc3577cba0b
Merge
Changeset: 3551855c4f40
Author:lana
Date: 2013-10-08 15:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/3551855c4f40
Merge
- make/java.security.override
Changeset: b48b719c5efc
Author:lana
Date: 2013-10-11 03:09 -0700
URL: http://hg.openjdk.java.net/jdk
Changeset: 4dfcf3a6902f
Author:lana
Date: 2013-10-08 14:59 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4dfcf3a6902f
Merge
- src/share/classes/jdk/Supported.java
- test/tools/javac/generics/OverrideBridge.java
Changeset: 2f43529df42f
Author:lana
Date: 2013-
Changeset: 1d6c13d3b8de
Author:lana
Date: 2013-10-08 14:55 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/1d6c13d3b8de
Merge
Changeset: 7c0a7937f6ef
Author:lana
Date: 2013-10-11 00:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7c0a7937f6ef
Mer
Changeset: 7c0e2fd8be4d
Author:lana
Date: 2013-10-08 14:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/7c0e2fd8be4d
Merge
Changeset: 3ece65f23ed2
Author:lana
Date: 2013-10-11 00:06 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/3ece65f23ed2
Merge
Changes
Changeset: b024fe427d24
Author:jjg
Date: 2013-10-14 12:38 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b024fe427d24
8026368: doclint does not report empty tags when tag closed implicitly
Reviewed-by: darcy
! src/share/classes/com/sun/tools/doclint/Checker.java
! test
Changeset: 8a041011b6e6
Author:jgodinez
Date: 2013-09-27 13:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a041011b6e6
6870661: Setting a custom PrintService on a PrinterJob leads to a
PrinterException
Reviewed-by: prr, jgodinez
Contributed-by: [email protected]
! src/w
Changeset: 87b5bfef7edb
Author:jlahoda
Date: 2013-10-14 22:11 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/87b5bfef7edb
8014016: javac is too late detecting invalid annotation usage
Summary: Adding new queue to Annotate for validation tasks, performing
annotation val
Changeset: dd0deeb04933
Author:michaelm
Date: 2013-10-14 22:09 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd0deeb04933
8014719: HttpClient/ProxyTest.java failing with IAE HttpURLPermission.parseURI
Reviewed-by: alanb, chegar
+ src/share/classes/java/net/HostPortrange.jav
Changeset: 94d4aa2fb414
Author:henryjen
Date: 2013-10-14 17:27 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94d4aa2fb414
8026362: java/lang/invoke/lambda/LogGeneratedClassesTest.java failed on
windows, jtreg report Fail to org.testng.SkipException
Reviewed-by: chegar
! te
Changeset: b9e3b55a908c
Author:jjg
Date: 2013-10-14 16:28 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b9e3b55a908c
8026371: "tidy" issues in langtools/src/**/*.html files
Reviewed-by: darcy
+ src/share/classes/com/sun/javadoc/package-info.java
- src/share/classes/co
Changeset: eb169222d3f2
Author:joehw
Date: 2013-10-14 22:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/eb169222d3f2
8015092: SchemaFactory cannot parse schema if whitespace added within patterns
in Selector XPath expression
Reviewed-by: lancea, alanb
! src/com/sun/org/
Changeset: 50e88f25255f
Author:joehw
Date: 2013-10-14 22:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50e88f25255f
8015092: SchemaFactory cannot parse schema if whitespace added within patterns
in Selector XPath expression
Reviewed-by: lancea, alanb
+ test/javax/xml/ja
Changeset: 7d266a2b31b2
Author:jjg
Date: 2013-10-14 22:34 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7d266a2b31b2
8025693: recent javadoc changes cause
com/sun/javadoc/testLinkOption/TestLinkOption.java to fail
Reviewed-by: darcy
! src/share/classes/com/sun/tools/
On 15/10/2013 1:52 AM, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure wha
On 15/10/2013 1:18 AM, Daniel D. Daugherty wrote:
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the actual
"extension" used for the "debuginfo" fil
Looks good!
Thanks,
/Staffan
On 14 okt 2013, at 14:44, Erik Gahlin wrote:
> Hi,
>
> Could I please have a review of this fix.
>
> An empty string is returned if the thread name is null. The protocol should
> be updated to support INVALID_STRING for the Thread Reference Command, but
> that
Changeset: 09a414673570
Author:jjg
Date: 2013-10-14 23:07 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/09a414673570
8025998: Missing LV table in lambda bodies
Reviewed-by: vromero
! src/share/classes/com/sun/tools/javac/code/Flags.java
! src/share/classes/com/sun/too
Changeset: 2f8728d92483
Author:acorn
Date: 2013-10-14 21:52 -0400
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f8728d92483
8026299: invokespecial gets ICCE when it should get AME.
Reviewed-by: ccheung, coleenp
! src/share/vm/interpreter/linkResolver.cpp
! src/share/v
I've been using this patch while debugging other issues and I now get full
symbols in the debugger without a lot of manual work. So it's a go!
Thanks,
/Staffan
On 11 okt 2013, at 22:27, Daniel D. Daugherty
wrote:
> Greetings,
>
> I'm ready for code review round 1 of the FDS on MacOS X hotspo
Hi Jaroslav,
os_bsd.cpp / os_linux.cpp:
If you don't have a monotonic clock you leave timer_frequency set to 0!
(So you need to test on a system without a monotonic clock, or else
force it to act as-if not present.)
That aside I don't trust clock_getres to give values that actually allow
th
38 matches
Mail list logo
