Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-20 Thread Dmitry Samersoff
David, > Unfortunately I do see some other implicit aborts due to allocation > failures, but I have to say this seems very wrong to me. IMHO, If the system can't allocate about 100 bytes for valid options, we have no chance to recover or send a message. if someone try to feed dcmd with 1Gb of g

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-20 Thread Dmitry Samersoff
David, PS: It might be a good to check opt_len for some large enough value (like 2048) before allocation attempt and send back a message. -Dmitry On 2016-01-20 08:03, David Holmes wrote: > On 20/01/2016 9:13 AM, Yasumasa Suenaga wrote: >> Hi David, >> >> ShouldNotReachHere( ) is called at NMTDc

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-20 Thread Staffan Larsen
> On 19 jan. 2016, at 23:37, David Holmes wrote: > > On 19/01/2016 11:19 PM, Yasumasa Suenaga wrote: >> Hi, >> >> I uploaded a new webrev: >> http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.03/ >> >> It is malloc/free version. >> If NULL returns from malloc(), it calls vm_exit_out_of

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-20 Thread Yasumasa Suenaga
I agree to Dmitry. Most case of malloc error, native memory is exhausted. Thus I think process (or system) is illegal state. It should be shut down. If do not so, malloc failure might be occurred another point. However, I think that it is very difficult to set the threshold. If it can be clear, I

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-20 Thread [email protected]
> On Jan 20, 2016, at 5:20 AM, David Holmes wrote: > > On 19/01/2016 11:58 PM, Marcus Larsson wrote: >> Hi, >> >> Please review the following patch to fix an issue in UL causing the VM >> to crash during shutdown. >> >> The problem is that the static LogStdoutOutput is deinitialized before >>

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-20 Thread Marcus Larsson
Hi Kim, On 01/19/2016 08:25 PM, Kim Barrett wrote: On Jan 19, 2016, at 8:58 AM, Marcus Larsson wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of

RFR: 8147848: tmtools tests ported to JTREG need to be quarantined

2016-01-20 Thread Alexander Kulyakhtin
Hi, Could you, please, review this quarantine request: CR: https://bugs.openjdk.java.net/browse/JDK-8147848 "https://bugs.openjdk.java.net/browse/JDK-8147848"; Webrev: http://cr.openjdk.java.net/~akulyakh/8147848/index.html The 3 tests need to be quarantined until the root cause of the failures

Re: RFR: 8147848: tmtools tests ported to JTREG need to be quarantined

2016-01-20 Thread Daniel D. Daugherty
On 1/20/16 9:50 AM, Alexander Kulyakhtin wrote: Hi, Could you, please, review this quarantine request: CR: https://bugs.openjdk.java.net/browse/JDK-8147848 "https://bugs.openjdk.java.net/browse/JDK-8147848"; Webrev: http://cr.openjdk.java.net/~akulyakh/8147848/index.html Thumbs up on the cha

Re: RFR: 8147848: tmtools tests ported to JTREG need to be quarantined

2016-01-20 Thread Jesper Wilhelmsson
Den 20/1/16 kl. 18:04, skrev Daniel D. Daugherty: On 1/20/16 9:50 AM, Alexander Kulyakhtin wrote: Hi, Could you, please, review this quarantine request: CR: https://bugs.openjdk.java.net/browse/JDK-8147848 "https://bugs.openjdk.java.net/browse/JDK-8147848"; Webrev: http://cr.openjdk.java.net/~