> On Jan 20, 2016, at 5:20 AM, David Holmes <david.hol...@oracle.com> wrote: > > On 19/01/2016 11:58 PM, Marcus Larsson wrote: >> Hi, >> >> Please review the following patch to fix an issue in UL causing the VM >> to crash during shutdown. >> >> The problem is that the static LogStdoutOutput is deinitialized before >> the last use of it (G1 concurrent thread tries to log very late during >> VM shutdown). The solution is to make sure neither LogStdoutOutput nor >> LogStderrOutput are deinitialized during the full lifetime of the VM. To > > I agree with Kim here - this seems like the "wrong" solution. If the G1 > thread can log very late during VM shutdown then we could > - move the logging "deinitialize" to later in the shutdown process (assuming > the G1 threads won't continue to run right up to process termination); or > - ensure the G1 threads have to terminate, or block, before the > deinitialization
Can I ask a silly question? If the JVM is shutting down is there a need to de-initialize logging? IME iit is highly unlikely that the loss of one or two GC log records would make a difference in my use cases. Kind regards, Kirk
signature.asc
Description: Message signed with OpenPGP using GPGMail