Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread Thomas Stüfe
Hi Staffan, On Fri, Jan 22, 2016 at 1:25 PM, Staffan Larsen wrote: > > > > Cleaning up like this is important if the JVM is being run many time > inside the same host process (think applets within a browser), but this is > becoming much less common. I wonder if it works at all at this point. > >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread Thomas Stüfe
David, On Fri, Jan 22, 2016 at 1:21 PM, David Holmes wrote: > On 22/01/2016 3:00 AM, Thomas Stüfe wrote: > >> Hi, >> >> On Wed, Jan 20, 2016 at 2:01 PM, [email protected] >> > > wrote: >> >> >> > On Jan 20, 2016, at 5:20 AM, David Holmes >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-23 Thread [email protected]
>>> >>> Or am I missing something obvious? >>> >> >> There is an ideal (which we seem to get further and further from) that the >> JVM should be unloadable within a process. In that model everything we >> initialize we should "de-initialize" before termination. And when logging >> itself can dep

RFR(S): JDK-8148104 HSDB could not terminate when launched on CLI.

2016-01-23 Thread Dmitry Samersoff
Everybody, Here is a small patch provided by KUBOTA Yuji. http://cr.openjdk.java.net/~dsamersoff/sponsorship/kubota.yuji/JDK-8148104/webrev.01/ The problem: Running HSDB by jhsdb on CLI i.e. without x11 display, HSDB could not terminate after throwing HeadlessException. HSDB starts WorkerThrea

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-23 Thread Yasumasa Suenaga
Dmitry, Thank you for your explanation. I've added length check with 4096 bytes in new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.04/ PATH_MAX is not defined Visual C++ 2015. So I do not use this macro. Could you review again? Thanks, Yasumasa On 2016/01/22 18:41,

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-23 Thread Dmitry Samersoff
Yasumasa, Looks good for me! -Dmitry On 2016-01-23 17:18, Yasumasa Suenaga wrote: > Dmitry, > > Thank you for your explanation. > I've added length check with 4096 bytes in new webrev: > > http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.04/ > > PATH_MAX is not defined Visual C++ 201