RFR(XS): JDK-8153856 com/sun/jdi/WatchFramePop.sh fails with exit code 1

Everybody, Please review a small fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8153856/webrev.01/ This fix doesn't fix root cause of the test fail but fix small test bug to get better diagnostic. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would lo

RFR(S): JDK-8152847 JDI use of sun.boot.class.path needs to be updated for Jigsaw

Everybody, Please, review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/ Public interface PathSearchingVirtualMachine.bootClassPath() left untouched, but VirtualMachineImpl.bootClassPath() returns an empty list. Tested with RBT -Dmitry -- Dmitry Samersoff Oracle Java

Re: RFR(S): JDK-8152847 JDI use of sun.boot.class.path needs to be updated for Jigsaw

On 12/04/2016 13:36, Dmitry Samersoff wrote: Everybody, Please, review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/ Public interface PathSearchingVirtualMachine.bootClassPath() left untouched, but VirtualMachineImpl.bootClassPath() returns an empty list. This loo

Re: RFR(XS): JDK-8153856 com/sun/jdi/WatchFramePop.sh fails with exit code 1

Can you explain what is going on here? It looks like the old code looked for the TTY process, whereas the new code accepts any process. What am I missing? > On 12 apr. 2016, at 14:28, Dmitry Samersoff > wrote: > > Everybody, > > Please review a small fix. > > http://cr.openjdk.java.net/~dsam

Re: RFR: 8150894: Unused -Xlog tag sequences are silently ignored.

Ping! On 04/06/2016 08:46 AM, Marcus Larsson wrote: Hi, Please review the following patch to add a warning for when tag selections in -Xlog or VM.log don't match any tag sets used in the VM. Webrev: http://cr.openjdk.java.net/~mlarsson/8150894/webrev.00/ Issue: https://bugs.openjdk.java.net

Re: RFR(XS): JDK-8153856 com/sun/jdi/WatchFramePop.sh fails with exit code 1

Staffan, On 2016-04-12 16:32, Staffan Larsen wrote: > Can you explain what is going on here? It looks like the old code > looked for the TTY process, whereas the new code accepts any process. > What am I missing? Both code select jdbCmd first: ll. 926 jdbCmd=`$jdk/bin/jps -v | $grep $jdbKeyword`

[8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump Bug: https://bugs.openjdk.java.net/browse/JDK-8153641 Webrev: http://cr.openjdk.java.net/~aeriksso/8153641/webrev.00/ The crash is because changes I did in JDK-81

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Andreas, Looks good for me! -Dmitry On 2016-04-12 19:05, Andreas Eriksson wrote: > Hi, > > Please review this fix for 8153641: assert(thread_state == > _thread_in_native) failed: Assumed thread_in_native while heap dump > > Bug: https://bugs.openjdk.java.net/browse/JDK-8153641 > Webrev: http:/

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Thanks Dmitry! - Andreas On 2016-04-12 18:07, Dmitry Samersoff wrote: Andreas, Looks good for me! -Dmitry On 2016-04-12 19:05, Andreas Eriksson wrote: Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump Bug: ht

Re: RFR(S): JDK-8152847 JDI use of sun.boot.class.path needs to be updated for Jigsaw

Dmitry, It looks good. Thanks, Serguei On 4/12/16 05:36, Dmitry Samersoff wrote: Everybody, Please, review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/ Public interface PathSearchingVirtualMachine.bootClassPath() left untouched, but VirtualMachineImpl.bootClassPat

Re: [8u] RFR: 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump

Hi Andreas, The fix looks good. Thanks, Serguei On 4/12/16 09:05, Andreas Eriksson wrote: Hi, Please review this fix for 8153641: assert(thread_state == _thread_in_native) failed: Assumed thread_in_native while heap dump Bug: https://bugs.openjdk.java.net/browse/JDK-8153641 Webrev: http:/

Re: RFR(XS): JDK-8153856 com/sun/jdi/WatchFramePop.sh fails with exit code 1

Thanks for the explanation. The change looks good. Do you know if the change in jps output was intentional or caused by something else? > On 12 apr. 2016, at 16:32, Dmitry Samersoff > wrote: > > Staffan, > > On 2016-04-12 16:32, Staffan Larsen wrote: >> Can you explain what is going on here

[PATCH resend2] 8145278: Fix memory leak in splitPathList

# HG changeset patch # User Alex Henrie # Date 1447827030 25200 # Tue Nov 17 23:10:30 2015 -0700 # Node ID 66c6fa3b2280afa12a2d51ea668b6a781b5744b5 # Parent 1f8c4b1a301c989dc299cad63dbc530b1de3ed70 8145278: Fix memory leak in splitPathList diff --git a/src/java.instrument/share/native/libin

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

Hi Serguei, Thank you for looking at this change. On 4/11/16 9:17 PM, [email protected] wrote: Coleen, src/share/vm/prims/jvmtiRedefineClasses.cpp - // Update the version number of the constant pool + // Update the version number of the constant pools (may keep scratch_cp) merge_

Re: RFR 8150607 - Clean up CompactHashtable

Ioi, > On Apr 11, 2016, at 7:11 PM, Ioi Lam wrote: > > Hi Jiangli, > > > Thanks for the review: > > On 4/11/16 6:44 PM, Jiangli Zhou wrote: >> Hi Ioi, >> >> I like the more structural way of reading/writing the compact table with >> SimpleCompactHashtable. It looks quite clean overall. >>

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

Hi Alex, The fix looks good. Could you tell why this is important to you, what is the motivation? Do you really observe this problem, or it is based on a static analysis? Thanks, Serguei On 4/12/16 12:28, Alex Henrie wrote: # HG changeset patch # User Alex Henrie # Date 1447827030 25200 #

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-12 14:07 GMT-06:00 [email protected] : > Hi Alex, > > The fix looks good. > Could you tell why this is important to you, what is the motivation? > Do you really observe this problem, or it is based on a static analysis? I was playing around with the codebase trying to find ways to

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

On 4/12/16 13:11, Alex Henrie wrote: 2016-04-12 14:07 GMT-06:00 [email protected] : Hi Alex, The fix looks good. Could you tell why this is important to you, what is the motivation? Do you really observe this problem, or it is based on a static analysis? I was playing around with the

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

Alex, The fix looks good for me. -Dmitry On 2016-04-12 22:28, Alex Henrie wrote: > # HG changeset patch > # User Alex Henrie > # Date 1447827030 25200 > # Tue Nov 17 23:10:30 2015 -0700 > # Node ID 66c6fa3b2280afa12a2d51ea668b6a781b5744b5 > # Parent 1f8c4b1a301c989dc299cad63dbc530b1de3ed

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

I'm also good with the fix. At this point, I think everyone who has commented on this fix previously has chimed in... Dan On 4/12/16 3:12 PM, Dmitry Samersoff wrote: Alex, The fix looks good for me. -Dmitry On 2016-04-12 22:28, Alex Henrie wrote: # HG changeset patch # User Alex Henrie

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-12 15:34 GMT-06:00 Daniel D. Daugherty : > I'm also good with the fix. At this point, I think everyone who > has commented on this fix previously has chimed in... Yeah, this change shouldn't be controversial, I'm just waiting for someone to push it to the Mercurial repository. -Alex

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

On 4/12/16 12:29, Coleen Phillimore wrote: Hi Serguei, Thank you for looking at this change. On 4/11/16 9:17 PM, [email protected] wrote: Coleen, src/share/vm/prims/jvmtiRedefineClasses.cpp - // Update the version number of the constant pool + // Update the version number of the con

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

Hi Serguei, On 4/12/16 9:35 PM, [email protected] wrote: On 4/12/16 12:29, Coleen Phillimore wrote: Hi Serguei, Thank you for looking at this change. On 4/11/16 9:17 PM, [email protected] wrote: Coleen, src/share/vm/prims/jvmtiRedefineClasses.cpp - // Update the version

Re: RFR 8151546: nsk/jvmti/RedefineClasses/StressRedefine fails in hs nightly

On 4/12/16 18:43, Coleen Phillimore wrote: Hi Serguei, On 4/12/16 9:35 PM, [email protected] wrote: On 4/12/16 12:29, Coleen Phillimore wrote: Hi Serguei, Thank you for looking at this change. On 4/11/16 9:17 PM, [email protected] wrote: Coleen, src/share/vm/prims/jvmti

RFR: 8154064: JVMTI trace event crashes

Hi all, Please review this bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154064 Test with tonga. (the 5 crashed tonga test no longer crashes) Thanks! /Robbin diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp --- a/src/share/vm/prims/jvmtiExport.cppTue Apr 12 09:08:48

Re: RFR: 8154064: JVMTI trace event crashes

Looks good! Thanks, /Staffan > On 13 apr. 2016, at 07:50, Robbin Ehn wrote: > > Hi all, > > Please review this bug fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8154064 > > Test with tonga. (the 5 crashed tonga test no longer crashes) > > Thanks! > > /Robbin > > diff -r 4823056a5

Re: RFR: 8154064: JVMTI trace event crashes

Hi Staffan, Thanks! /Robbin On 04/13/2016 08:02 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 13 apr. 2016, at 07:50, Robbin Ehn wrote: Hi all, Please review this bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154064 Test with tonga. (the 5 crashed tonga test no lo

Re: RFR: 8154064: JVMTI trace event crashes

Looks good. StefanK On 2016-04-13 07:50, Robbin Ehn wrote: Hi all, Please review this bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154064 Test with tonga. (the 5 crashed tonga test no longer crashes) Thanks! /Robbin diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp --- a/

Re: RFR: 8154064: JVMTI trace event crashes

Thanks Stefan! /Robbin On 04/13/2016 08:34 AM, Stefan Karlsson wrote: Looks good. StefanK On 2016-04-13 07:50, Robbin Ehn wrote: Hi all, Please review this bug fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8154064 Test with tonga. (the 5 crashed tonga test no longer crashes) Thanks!