Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi David, Thank you for the comments! I agree with you. Updated Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.4/ Thanks, Serguei On 6/27/16 22:06, David Holmes wrote: Hi Serguei, Overall this looks a lot clearer/simpler. On 28/06/2016

PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.05/ I've requested FC extension for this. Thanks, Yasumasa On 2016/06/13 13:24, David Holmes wrote: Hi Yasumasa, On 13/06/2016 1:45 PM, Yasumasa Suenaga wrote: Hi David, Thank you for your

Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159147 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk1/ Summary: As noted in JDK-8155207 and elsewhere,

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi, On 06/28/2016 11:29 AM, Yasumasa Suenaga wrote: PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.05/ I don't really like that we need to make dynamic allocations here. I would prefer to have the outputs be responsible for describing themse

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi Marcus, I don't really like that we need to make dynamic allocations here. Should use resource area? or char array? If we should use char array, how long should we reserve for buffer? Therefore I suggest that we introduce a describe() function in LogOutput as part of this change, and mo

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi Serguei, Looks good. 1. In modules.cpp, the first assert in get_named_module() has the wrong function name: 825 assert(ModuleEntryTable::javabase_defined(), 826 "Attempt to call *get_module_by_package_name* before java.base is defined"); 2. Also, is a check needed to ensure that packag

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi Harold, On 6/28/16 07:32, harold seigel wrote: Hi Serguei, Looks good. Thank you for reviewing! 1. In modules.cpp, the first assert in get_named_module() has the wrong function name: 825 assert(ModuleEntryTable::javabase_defined(), 826 "Attempt to call *get_module_by_package_name* b

Serviceability Agent tools / API usage .

Hello Everyone, Writing to this group to understand the following aspects related to Serviceability Agent tools / API's. . Have you been using Serviceability Agent related API's or tools for any of your debugging or analysis purpose (e.g. core dump / heapdump ) ? . If the

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.5/ Thanks, Serguei On 6/28/16 07:32, harold seigel wrote: Hi Serguei, Looks good. 1. In modules.cpp, the first assert in get_named_mod

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/27/16 10:20 PM, [email protected] wrote: On 6/27/16 21:08, [email protected] wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-j

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi Serguei, It looks good! Thanks, Harold On 6/28/2016 12:37 PM, [email protected] wrote: Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.5/ Thanks, Serguei On 6/28/16 07:3

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 10:37 AM, [email protected] wrote: Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.5/ make/test/JtregNative.gmk No comments. src/share/vm/classfile/modules.hpp

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 10:24, Daniel D. Daugherty wrote: On 6/27/16 10:20 PM, [email protected] wrote: On 6/27/16 21:08, [email protected] wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159145 The Hotspot webrev: http://cr.openjdk.jav

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Thanks, Harold! Serguei On 6/28/16 10:45, harold seigel wrote: Hi Serguei, It looks good! Thanks, Harold On 6/28/2016 12:37 PM, [email protected] wrote: Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hot

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 11:19, Daniel D. Daugherty wrote: On 6/28/16 10:37 AM, [email protected] wrote: Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.5/ make/test/JtregNative.gmk No

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 13:11, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wrote: On 6/28/16 10:37 AM, [email protected] wrote: Hi Harold, Thank you again for the comments! This is the updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jig

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Dan, The updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.6/ > Has someone checked the generated glue code for completeness and proper checks? This is the generated upper layer function in the jvmtiEnter.cpp: 3185 static jvmtiError JNICALL 318

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 2:11 PM, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wrote: I'll have to check the upper layers of this API, but if an agent can pass a bad 'class_loader' parameter and get this assert() to fire, then that's not good. Hopefully a b

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/28/16 2:11 PM, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wrote: I'll have to check the upper layers of this API, but if an agent can pass a bad 'class_loader' parameter and get this assert(

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

On 6/28/16 5:06 AM, [email protected] wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159147 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8159147-Jigsaw-jli.jdk1/ src/java.instrument/share/classes/java/lang/inst

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

Thanks, Dan! Serguei On 6/28/16 14:45, Daniel D. Daugherty wrote: On 6/28/16 5:06 AM, [email protected] wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JDK-8159147 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/815914

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

Hi Serguei, Changes look good. Just curious why none of the tests actually do anything with the Module or ClassLoader arguments? Thanks, David On 28/06/2016 9:06 PM, [email protected] wrote: Please, review the Jigsaw fix for the enhancement: https://bugs.openjdk.java.net/browse/JD

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 29/06/2016 7:09 AM, [email protected] wrote: On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/28/16 2:11 PM, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wrote: I'll have to check the upper layers of this API, but if an agent can pass a

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, [email protected] wrote: On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/28/16 2:11 PM, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wrote: I'll have to check the upper layers of this

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi Serguei, Looks good to me. A couple of comments ... On 29/06/2016 6:42 AM, [email protected] wrote: Dan, The updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.6/ src/share/vm/classfile/modules.cpp Nit: + const PackageEntry* con

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

Hi David, On 6/28/16 19:17, David Holmes wrote: Hi Serguei, Looks good to me. A couple of comments ... Thank you for reviewing it! On 29/06/2016 6:42 AM, [email protected] wrote: Dan, The updated webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 29/06/2016 12:09 PM, [email protected] wrote: On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, [email protected] wrote: On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/28/16 2:11 PM, [email protected] wrote: On 6/28/16 11:19, Daniel D. Daugherty wro

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 6/28/16 19:30, David Holmes wrote: On 29/06/2016 12:09 PM, [email protected] wrote: On 6/28/16 18:44, David Holmes wrote: On 29/06/2016 7:09 AM, [email protected] wrote: On 6/28/16 14:02, Daniel D. Daugherty wrote: On 6/28/16 2:11 PM, [email protected] wrote: On

Re: Jigsaw Enhancement RFR round #3: 8159145 Add JVMTI function GetNamedModule

On 29/06/2016 12:29 PM, [email protected] wrote: Hi David, On 6/28/16 19:17, David Holmes wrote: Hi Serguei, Looks good to me. A couple of comments ... Thank you for reviewing it! On 29/06/2016 6:42 AM, [email protected] wrote: Dan, The updated webrev: http://cr.op

Re: Jigsaw Enhancement RFR round #1: 8156147 Add ClassLoader parameter to new ClassFileTransformer transform method

Hi David, Thank you for reviewing! The updated tests just pass the the arguments through as required. It provides sanity checks that both old and new overloaded transform methods works as needed. There are some tricky dependencies among the Jtreg java/lang/instrument test classes that I have t