RE: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Hi Jini, I had a look at your change. It makes tests fail if shouldSAAttach returns false. Now, these tests say "Errror: cannot attach", while before they would terminate silently. It is not an Error if the SA can not attach. You can reproduce this by just changing Platform.shouldSAAttach() t

committed > max in MemoryMXBean#getHeapMemoryUsage()

Hi, while working on a change in Elasticsearch, I discovered an interesting situation related to the implementation of jmm_getMemoryUsage (see [jdk-mem-usage]). In one of the test runs, a test failed with the following exception: java.lang.IllegalArgumentException: committed = 542113792 should be

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM [email protected] < [email protected]> wrote: > Hi Jc, > > The fix looks good. > I'll sponsor a push once it has been reviewed. > > Thanks, > Serguei > > > On 7/11/18 10:

Re: RFR: JDK-8206007: nsk/jdb/exclude001 test is taking a long time on some builds

I've attached the patch for JDK-8206007. I'll need a sponsor to push the changes. On 7/5/18, 10:48 AM, Gary Adams wrote: A simple test run using "exclude none" shows 625K methods are being observed. The bulk of those methods were due to the last class accessed in the test - VirtualMachineManage

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Thanks, Goetz. The "Error: cannot attach" was put in deliberately so that we get to know that this is not getting tested. I can change this to retain the old behaviour of skipping the tests if we cannot attach. Thanks, Jini. On 7/12/2018 3:41 PM, Lindenmaier, Goetz wrote: Hi Jini, I had a lo

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

I'll run the patch throuqh our nightly tests to see whether they pass mac. Thanks for this. Let me know in case there are timeouts due to there not being a no-password entry for the user in the /etc/sudoers list. Thanks, Jini.

Re: RFR JDK-8191948 : jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

+1 --alex On 07/11/2018 22:26, [email protected] wrote: Hi Daniil, It looks good. Thanks, Serguei On 7/11/18 22:23, Daniil Titov wrote: Please review the changes that fix jdb issue with evaluation of multidimensional arrays of primitives. The problem here is that for N-dimension

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

Looks good to me as well. --alex On 07/12/2018 07:25, JC Beyler wrote: Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM [email protected] > wrote:

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

Thanks, Alex! Jc, I'll push it if you send me a patch. Thanks, Serguei On 7/12/18 11:30, Alex Menkov wrote: Looks good to me as well. --alex On 07/12/2018 07:25, JC Beyler wrote: Thanks Serguei! Anybody motivated to give this a review please? Thanks! Jc On Wed, Jul 11, 2018 at 2:42 PM

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

Hi Serguei, Here you are: http://cr.openjdk.java.net/~jcbeyler/8206960/webrev.01/ Thanks for the push! Jc On Thu, Jul 12, 2018 at 11:33 AM [email protected] < [email protected]> wrote: > Thanks, Alex! > > Jc, > > I'll push it if you send me a patch. > > Thanks, > Serguei > > >

Re: RFR JDK-8191948 : jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Thank you, Alex and Serguei for reviewing this change! Best regards, Daniil On 7/12/18, 11:21 AM, "Alex Menkov" wrote: +1 --alex On 07/11/2018 22:26, [email protected] wrote: > Hi Daniil, > > It looks good. > > Thanks, > Serguei >

Re: RFR (S) 8206960: [Graal] serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor tests fail

Pushed. Thanks, Serguei On 7/12/18 12:02, JC Beyler wrote: Hi Serguei, Here you are: http://cr.openjdk.java.net/~jcbeyler/8206960/webrev.01/ Thanks for the push!

Re: committed > max in MemoryMXBean#getHeapMemoryUsage()

It's indeed strange that no one reports this issue. I created: https://bugs.openjdk.java.net/browse/JDK-8207200 Mandy On 7/12/18 6:35 AM, Daniel Mitterdorfer wrote: Hi, while working on a change in Elasticsearch, I discovered an interesting situation related to the implementation of jmm_ge

Re: RFR (S) 8205725: Update the JVMTI Spec for Heap Sampling

Hi Jc, It looks good to me (including the CSR that I'had already reviewed). Thank you for preparing a fix for this issue so quickly! Thanks, Serguei On 7/12/18 13:45, JC Beyler wrote: Hi all,

Re: RFR: JDK-8206007: nsk/jdb/exclude001 test is taking a long time on some builds

I'll take care of it shortly. Chris On 7/12/18 7:53 AM, Gary Adams wrote: I've attached the patch for JDK-8206007. I'll need a sponsor to push the changes. On 7/5/18, 10:48 AM, Gary Adams wrote: A simple test run using "exclude none" shows 625K methods are being observed. The bulk of those me

Re: RFR: JDK-8201513: nsk/jvmti/IterateThroughHeap/filter-* are broken

+1 On 7/11/18 2:26 PM, [email protected] wrote: Hi Alex, The fix looks good. Thank you for fixing the typos! Thanks, Serguei On 7/11/18 11:39, Alex Menkov wrote: Hi all, please review a fix for https://bugs.openjdk.java.net/browse/JDK-8201513 webrev: http://cr.openjdk.java.net/~am

RFR(XS): 8207217: Problem list java/lang/management/ThreadMXBean/AllThreadIds.java

Please review this change which problem lists the frequently failing java/lang/management/ThreadMXBean/AllThreadIds.java test until the issue[1] has been fixed: Bug: https://bugs.openjdk.java.net/browse/JDK-8207217 webrev: http://cr.openjdk.j

Re: RFR(XS): 8207217: Problem list java/lang/management/ThreadMXBean/AllThreadIds.java

Ship it! Thanks, David On 13/07/2018 10:21 AM, Mikael Vidstedt wrote: Please review this change which problem lists the frequently failing java/lang/management/ThreadMXBean/AllThreadIds.java test until the issue[1] has been fixed: Bug: https://bugs.openjdk.java.net/browse/JDK-8207217 webre

RE: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Hi Jini, A whole bunch of tests failed on mac. I'll send you A jtr file off list, to avoid spamming the list. See below the core message. The tests passed on linuxppc64le, linuxx86_64 and solaris_sparc, the other tests are still pending. Best regards, Goetz. --System.err:(32/1923)--

Re: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

Thanks a bunch, Goetz. As David feared, the tests are failing due to there not being a no-password entry for the user in the /etc/sudoers list ("sudo: no tty present and no askpass program specified"). Let me see what I can do about this. Thanks, Jini. On 7/13/2018 11:25 AM, Lindenmaier, Goet