Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v2]

2020-10-05 Thread Severin Gehwolf
> An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup > systemd rw,name=sy

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v2]

2020-10-05 Thread Severin Gehwolf
On Sun, 4 Oct 2020 18:12:14 GMT, Boris Ulasevich wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8245543: Cgroups: Incorrect detection logic on some systems (still >> reproducible) > > src/java.base/linux/class

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v2]

2020-10-05 Thread Severin Gehwolf
On Sun, 4 Oct 2020 18:12:39 GMT, Boris Ulasevich wrote: >> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8245543: Cgroups: Incorrect detection logic on some systems (still >> reproducible) > > src/java.base/linux/class

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

2020-10-05 Thread Severin Gehwolf
On Sun, 4 Oct 2020 18:14:37 GMT, Boris Ulasevich wrote: > The change looks reasonable. I checked the fail - it is gone with the change! > And both jtreg tests passed. Thanks for the review and for testing it! - PR: https://git.openjdk.java.net/jdk/pull/485

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

2020-10-05 Thread Severin Gehwolf
On Mon, 5 Oct 2020 09:00:17 GMT, Severin Gehwolf wrote: >> The change looks reasonable. I checked the fail - it is gone with the >> change! And both jtreg tests passed. > >> The change looks reasonable. I checked the fail - it is gone with the >> change! And both jtreg tests passed. > > Thanks

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

2020-10-05 Thread Severin Gehwolf
> An issue similar to > [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been > discovered. On the > affected system, `/proc/self/mountinfo` contains a line such as this one: > > 35 26 0:26 / /sys/fs/cgroup/systemd rw,nosuid,nodev,noexec,relatime - cgroup > systemd rw,name=sy

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v10]

2020-10-05 Thread Erik Österlund
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack > Processing" (cf. > https://openjdk.java.net/jeps/376). > Basically, this patch modifies the epilog safepoint when returning from a > frame (supporting interpreter frames, c1, c2, > and native wrapper frames), to compare the

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-05 Thread Vladimir Kempik
On Fri, 2 Oct 2020 15:26:30 GMT, Vladimir Kempik wrote: >>> Okay but look at the example that documentation gives: >>> >>> > For example, if the jvmtiParamInfo returned by GetExtensionEvents >>> > indicates that there is a jint parameter, the event >>> > handler should be declared: ``` >>> >

Withdrawn: 8252105: parallel heap inspection for ZCollectedHeap

2020-10-05 Thread Lin Zang
On Thu, 10 Sep 2020 02:28:43 GMT, Lin Zang wrote: > - enable parallel heap inspection for ZCollectedHeap > - preliminary evaluation: > Time of jmap histo on 8GB heap with ~5GB objects > * before: 7.103s > * after : 2.734s (with 4 parallel threads) This pull request has been closed without

Re: RFR: 8252105: parallel heap inspection for ZCollectedHeap [v2]

2020-10-05 Thread Lin Zang
On Fri, 2 Oct 2020 08:57:29 GMT, Per Liden wrote: >> Hi @pliden, >>I updated the PR which merge the changed code into ZHeapIterator. >>May I ask your help to review it ? Thanks. >> -Lin > > Hi @linzang, > > I started reviewing your patch in more detail. However, I ended up with a > larg

Re: RFR: 8252105: parallel heap inspection for ZCollectedHeap [v2]

2020-10-05 Thread Per Liden
On Mon, 5 Oct 2020 14:29:02 GMT, Lin Zang wrote: >> Hi @linzang, >> >> I started reviewing your patch in more detail. However, I ended up with a >> large number of major comments and I started >> to feel that it would probably be more productive to create an alternative >> patch for this, so I

Re: RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]

2020-10-05 Thread Bob Vandette
On Mon, 5 Oct 2020 10:16:49 GMT, Severin Gehwolf wrote: >> An issue similar to >> [JDK-8239559](https://bugs.openjdk.java.net/browse/JDK-8239559) has been >> discovered. On the >> affected system, `/proc/self/mountinfo` contains a line such as this one: >> >> 35 26 0:26 / /sys/fs/cgroup/system

Re: RFR: 8253899: Make IsClassUnloadingEnabled signature match specification

2020-10-05 Thread David Holmes
On 5/10/2020 10:47 pm, Vladimir Kempik wrote: On Fri, 2 Oct 2020 15:26:30 GMT, Vladimir Kempik wrote: Okay but look at the example that documentation gives: For example, if the jvmtiParamInfo returned by GetExtensionEvents indicates that there is a jint parameter, the event handler should b

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v2]

2020-10-05 Thread David Holmes
On Fri, 18 Sep 2020 10:56:56 GMT, Aleksei Voitylov wrote: >> thank you Alan, Erik, and David! When the JEP becomes Targeted, I'll use >> this PR to integrate the changes. > > I added the contributors that could be found in the portola project commits. > If anyone knows some other contributors

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v10]

2020-10-05 Thread David Holmes
On Mon, 5 Oct 2020 11:43:52 GMT, Erik Österlund wrote: >> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack >> Processing" (cf. >> https://openjdk.java.net/jeps/376). >> Basically, this patch modifies the epilog safepoint when returning from a >> frame (supporting interpreter

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v10]

2020-10-05 Thread David Holmes
On Mon, 5 Oct 2020 11:43:52 GMT, Erik Österlund wrote: >> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack >> Processing" (cf. >> https://openjdk.java.net/jeps/376). >> Basically, this patch modifies the epilog safepoint when returning from a >> frame (supporting interpreter

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v8]

2020-10-05 Thread David Holmes
On Thu, 1 Oct 2020 10:12:54 GMT, Erik Österlund wrote: >>> _Mailing list message from [Kim Barrett](mailto:[email protected]) on >>> [hotspot-dev](mailto:[email protected]):_ >>> I've only looked at scattered pieces, but what I've looked at seemed to be >>> in good shape. Only a f

Re: RFR: 8253180: ZGC: Implementation of JEP 376: ZGC: Concurrent Thread-Stack Processing [v10]

2020-10-05 Thread David Holmes
On Mon, 5 Oct 2020 11:43:52 GMT, Erik Österlund wrote: >> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack >> Processing" (cf. >> https://openjdk.java.net/jeps/376). >> Basically, this patch modifies the epilog safepoint when returning from a >> frame (supporting interpreter