On Sun, 4 Oct 2020 18:12:39 GMT, Boris Ulasevich <[email protected]> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8245543: Cgroups: Incorrect detection logic on some systems (still
>> reproducible)
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java
> line 80:
>
>> 78: */
>> 79: private static final Pattern MOUNTINFO_PATTERN =
>> 80:
>> Pattern.compile("^[^\\s]+\\s+[^\\s]+\\s+[^\\s]+\\s+([^\\s]+)\\s+([^\\s]+)\\s+[^-]+-\\s+([^\\s]+)\\s+.*$");
>
> Only group_3 = fstype is used in the pattern, right?
Yes. I've removed unused groups now, though.
Originally, my thinking was that `mount root` and `mount path` would be useful
too so I kept it in. It would certainly
be useful for getting rid of reading `/proc/self/mountinfo` twice on the Java
side. As a future enhancement we could do
away with double parsing of mount info by keeping track of relevant cgroup
controller info. I've filed
[JDK-8254001](https://bugs.openjdk.java.net/browse/JDK-8254001) to track this.
-------------
PR: https://git.openjdk.java.net/jdk/pull/485
