Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-21 Thread David Holmes
On Thu, 20 Jan 2022 20:11:43 GMT, Xin Liu wrote: >> src/hotspot/os/posix/signals_posix.cpp line 600: >> >>> 598: assert(!ReduceSignalUsage, "Should not happen with >>> -Xrs/-XX:+ReduceSignalUsage"); >>> 599: signal_was_handled = true; >>> 600: } >> >> Can't we just do this as the ver

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-21 Thread Thomas Stuefe
On Fri, 21 Jan 2022 09:00:49 GMT, David Holmes wrote: >> hi, David and Thomas, >> >> I am nervous about this change. It's not complex but I don't want to break >> the existing java applications. Bear with me. >> >> From my reading, HotSpot can chain a user-custom signal handler because of >

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases

2022-01-21 Thread Aleksey Shipilev
On Tue, 18 Jan 2022 19:36:18 GMT, Chris Plummer wrote: >> While working on JDK-8280003, I noticed that >> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays >> with more than 1-byte size elements, and no large arrays (past 4G limit) are >> tested either. It would be bet

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v2]

2022-01-21 Thread Aleksey Shipilev
> While working on JDK-8280003, I noticed that > java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays > with more than 1-byte size elements, and no large arrays (past 4G limit) are > tested either. It would be better to add those test cases. > > Additional testing: > - [

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v5]

2022-01-21 Thread David Holmes
On Fri, 21 Jan 2022 09:52:22 GMT, Thomas Stuefe wrote: >> Hi Xin, >> Signal chaining doesn't work for BREAK_SIGNAL - from the signal chaining >> docs: >> >> >> Note: >> >> The SIGQUIT, SIGTERM, SIGINT, and SIGHUP signals cannot be chained. If the >> application must >> handle these signals,

RFR: 8240908: RetransformClass does not know about MethodParameters attribute

2022-01-21 Thread Alex Menkov
Changes: - ClassFileReconstituter is updated to restore "MethodParameters" attribute; - handling of the attribute in VM_RedefineClasses is moved to be consistent with other code (like local variable table); - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to /test/lib as it's u

Re: RFR: 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test cases [v2]

2022-01-21 Thread Leonid Mesnik
On Fri, 21 Jan 2022 11:04:26 GMT, Aleksey Shipilev wrote: >> While working on JDK-8280003, I noticed that >> java/lang/instrument/GetObjectSizeIntrinsicsTest.java does not test arrays >> with more than 1-byte size elements, and no large arrays (past 4G limit) are >> tested either. It would be

Re: RFR: 8240908: RetransformClass does not know about MethodParameters attribute

2022-01-21 Thread Serguei Spitsyn
On Fri, 21 Jan 2022 15:40:07 GMT, Alex Menkov wrote: > Changes: > - ClassFileReconstituter is updated to restore "MethodParameters" attribute; > - handling of the attribute in VM_RedefineClasses is moved to be consistent > with other code (like local variable table); > - copied ClassTransformer

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v7]

2022-01-21 Thread Xin Liu
> In early stage of initialization, HotSpot doesn't handle SIGQUIT. The default > signal preposition on Linux is to quit the process and generate coredump. > > There are 2 applications for this signal. > 1. There's a handshake protocol between sun.tools.attach and HotSpot. > VirtualMachineImpl