On Fri, 21 Jan 2022 15:40:07 GMT, Alex Menkov <amen...@openjdk.org> wrote:
> Changes:
> - ClassFileReconstituter is updated to restore "MethodParameters" attribute;
> - handling of the attribute in VM_RedefineClasses is moved to be consistent
> with other code (like local variable table);
> - copied ClassTransformer class (from test/jdk/com/sun/jdi/lib/jdb) to
> /test/lib as it's used by tests from hotspot and jdk (and also by test from
> Valhalla repo); Will file a follow up issues to updates tests and remove the
> class from test/jdk/com/sun/jdi/lib/jdb
src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 3684:
> 3682: // Update constant pool indices in the method's method_parameters.
> 3683: int mp_length = method->method_parameters_length();
> 3684: if (mp_length >= 0) {
This line is better to be:
3684 if (mp_length > 0) {
-------------
PR: https://git.openjdk.java.net/jdk/pull/7180
