Hi Chris,
It looks good to me modulo the comments from Alex.
I'm ok with the _p arguments.
Probably, you've already considered to return Command (instead of CommandHandler) from the
debugDispatch_getHandler().
It allows to get rid of the cmdName_
Hi Daniil,
LGTM++
Thanks,
Serguei
On 1/15/20 14:28, David Holmes wrote:
+1
David
On 16/01/2020 4:41 am, Daniel Fuchs wrote:
Hi Daniil,
That looks fine to me.
best regards,
-- daniel
On 15/01/2020 18:15, Daniil Titov wrote:
Please review a change [1] that fixes a deadlock issue [2] in
Hi Chris,
http://cr.openjdk.java.net/~cjplummer/8236913/webrev.00/src/jdk.jdwp.agent/share/native/libjdwp/MethodImpl.c.udiff.html
+CommandSet Method_Cmds = {
+5, "Method",
+{
+{lineTable, "lineTable"},
+{variableTable, "variableTable"},
+{byte
Chris,
Please, ignore this (will resend my review).
In a part of my review I've looked at the old webrev.
Thanks,
Serguei
On 1/17/20 14:16, serguei.spit...@oracle.com wrote:
Hi Chris,
Hi Chris,
It looks good.
Just one nit below.
http://cr.openjdk.java.net/~cjplummer/8236913/webrev.00/src/jdk.jdwp.agent/share/native/libjdwp/debugDispatch.c.udiff.html
+CommandSet *cmd_set;
+*cmdSetName_p = "";
+*cmdName_p = "";
I'd suggest to replace Unknow
Okay, thanks!
Serguei
On 1/17/20 14:58, Chris Plummer wrote:
Hi Serguei,
I'll make that change.
thanks,
Chris
On 1/17/20 2:33 PM, serguei.spit...@oracle.com
Hi Roman,
Thank you for taking care about this scalability issue!
I have a couple of quick comments.
http://cr.openjdk.java.net/~rkennke/JDK-8227269/webrev.04/src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c.frames.html
72 /*
73 * Lock to p
Hi Daniil,
It looks okay to me in general.
But I'm puzzled with this part:
http://cr.openjdk.java.net/~dtitov/8196729/webrev.01/src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java.udiff.html
+} else if (arg.startsWith("-r")) {
+
] CSR : https://bugs.openjdk.java.net/browse/JDK-8238357
Thanks,
Daniil
From: "serguei.spit...@oracle.com"
Date: Tuesday, February 4, 2020 at 7:51 PM
To: Daniil Titov , "serviceability-dev@openjdk.java.net"
Subject: Re: RFR: 8196729: Add jstatd option to specify RMI conne
4-3-20191214-1527-7538487).
Thanks,
Yasumasa
On 2019/12/14 10:02, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
This is nice move in general.
Thank you for working on this!
http://cr.openjdk.java.net/~ysuenaga/JDK-8234624/webrev.01/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/li
Hi Richard,
It looks good to me.
I can't comment on compiled methods non-entrancy.
What exact tests do you run to verify the fix?
Thanks,
Serguei
On 2/6/20 04:39, Reingruber, Richard wrote:
Hi,
could I please get reviews for this small enhancement:
Webrev: http://cr.openjdk.java.net/~rrich
ead executing the
new handshake. So this is covered as well.
Thanks again for reviewing.
Do I need more reviews or are your reviews enough to push the enhancement?
Best regards,
Richard.
-Original Message-
From: serguei.spit...@oracle.com
Sent: Freitag, 7. Februar 2020 19:06
To: Reingr
Hi Alex,
It looks okay to me.
Minor:
+return bytes[0] == 0x20 && bytes[1] == 0x01 && bytes[2] == 00 && bytes[3] == 0;
'00' looks strange, maybe you want something like this:
+return bytes[0] == 0x20 && bytes[1] == 0x01 && bytes[2] == 0x0 && byt
Hi Chihiro,
Thank you for taking care about this issue!
It looks good to me.
Just a couple of minor comments.
http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.04/src/java.base/share/classes/jdk/internal/vm/VMSupport.java.frames.html
88
Hi Daniil,
I've looked at CSR and posted a couple of questions there.
It'd be nice if you help to resolve my confusion. :)
Thanks,
Serguei
On 2/23/20 20:21, Daniil Titov wrote:
Please review change that adds a new command line option to jhsdb tool for the
debugd mode to specify a RMI connect
Hi Martin,
It looks good to me.
Thanks,
Serguei
On 2/24/20 05:51, Doerr, Martin wrote:
Hi,
reposting on
serviceability-dev (was
core-libs-dev before).
Hi Chris,
This looks good to me.
I always prefer verbose output in tests. :)
Thanks,
Serguei
On 2/24/20 21:48, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8193237
http://cr.openjdk.java.net/~cjplummer/8193237/webrev.00/
The fix is to is
Hi Matthias,
LGTM++
Thanks,
Serguei
On 2/25/20 11:30, Alex Menkov wrote:
Hi Matthias,
LGTM
--alex
On 02/25/2020 08:20, Baesken, Matthias wrote:
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8239462.3/
Best regards, Matthias
IMO the solution with goto makes it even wors
Hi Chris,
It looks good.
Thanks,
Serguei
On 2/25/20 11:47, Chris Plummer wrote:
Hi,
I have to problem list this test due to JDK-8239062 [1], and have to
do so before I can push the fix for JDK-8238268 [2], which exposes
JDK-8239062 [1].
https://bugs.openjdk.java.net/browse/JDK-8239379
d
entiate between \n, \t, \f and \r originally being one or two characters.
Best regards,
Ralf
From: serviceability-dev On Behalf Of Chihiro Ito
Sent: Dienstag, 25. Februar 2020 04:45
To: serguei.spit...@oracle.com
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR: JDK-8222489: jcmd VM.syste
Hi Alex,
It looks good to me.
Thanks,
Serguei
On 3/4/20 16:30, Alex Menkov wrote:
Hi all,
please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8240340
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev/
changes:
- assertThreadState method: don't r
Hi David and Alex,
My understanding is that previous implementation collected logs
separately for each thread in TLS, and at the end, merged and sorted out
the output by log id.
So, the result is that all messages are serialized at the end.
Alex changed the implementation but the result is the
Hi Ram,
+1
Thanks,
Serguei
On 3/3/20 22:10, Chris Plummer wrote:
Hi Ram,
Looks good.
thanks,
Chris
On 3/3/20 9:24 PM, Ramkumar Sunderbabu wrote:
Hi Yumin and Chris,
There is a separate open/test/hotspot/jtreg/ProblemList-zgc.txt
for ZGC.
There is a list of SA tests in that list but these two CDS related
tests are not there.
Would it make sense to include them into ProblemList-zgc.txt
ins
Hi Kevin,
This looks okay to me as well.
Thanks,
Serguei
On 3/5/20 02:38, David Holmes wrote:
Thanks Kevin. I think this is the less risky change and achieves the
goal.
David
On 5/03/2020 8:00 pm, Kevin Walls wrote:
Thanks -
I had tried some ideas in the simple fashion, and we can use %0
/webrev.06/changeset
Regards,
Chihiro
2020年3月7日(土) 16:03 Yasumasa Suenaga :
Hi Chihiro,
I'm also ok with webrev.05 after updating copyright year.
Yasumasa
On 2020/03/07 3:32, serguei.spit...@oracle.com wrote:
Hi Chichiro,
I'm okay with the fix.
Could you, please, update the copyr
Hi Alex,
The update looks good.
Thanks,
Serguei
On 3/9/20 12:15, Alex Menkov wrote:
Updated webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/
Changes are in LockFreeLogger comments only.
--alex
On 03/08/2020 21:19, David Holmes wrote:
P.S.
Forgot to
Hi Chris,
Overall, this looks as a right direction to me while it is not
easy to verify all the details.
I'll make another pass tomorrow.
A couple of quick nits so far:
http://cr.openjdk.java.net/~cjplummer/8238268/webrev.00/test/hotspot/jtre
On 3/10/20 18:57, Chris Plummer wrote:
On 3/10/20 6:07 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
Overall, this looks as a right direction to me while it is not
easy to verify all the details
Please, review the fix of:
https://bugs.openjdk.java.net/browse/JDK-8240881
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8240881-encoding-antidelta/
Summary:
JDK-8240881 is a regression caused by the fix of:
http
0/20 02:54, serguei.spit...@oracle.com wrote:
Hi Chihiro,
Yes, I'll sponsor it.
Thank you for the update.
Thanks,
Serguei
On 3/8/20 06:05, Chihiro Ito wrote:
Hi,
I'm sorry. I included "JDK-" in the changeset title. I removed it and
updated it.
Change set :
http://cr.open
Hi Dan,
Thank you for filing the bug and review!
My mach5 job was submitted later , so your job comes to be handy - thanks!
I'll push the fix.
Thanks,
Serguei
On 3/11/20 12:49, Daniel D. Daugherty wrote:
On 3/11/20 3:35 PM, serguei.spit...@oracle.com wrote:
Please, review the fix of:
Thanks, Ioi!
Serguei
On 3/11/20 12:49, Ioi Lam wrote:
Looks good to me.
Thanks
- Ioi
On 3/11/20 12:35 PM, serguei.spit...@oracle.com wrote:
Please, review the fix of:
https://bugs.openjdk.java.net/browse/JDK-8240881
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8240881-encoding
Hi Alex,
It looks good to me.
It seems, returning S_FALSE from SAOutputCallbacks::Output should be
okay as the same is done when nullptr is returned from malloc.
Thanks,
Serguei
On 3/11/20 15:29, Alex Menkov wrote:
Hi all,
please review small (and I'd say trivial) fix for
https://bugs.open
wanted to know
your view.
Thanks,
Serguei
On 3/10/20 18:57, Chris Plummer wrote:
On 3/10/20 6:07 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
Overall, this looks as a right direction to m
Chris
On 3/11/20 11:20 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
I've made another pass today.
It looks good to me.
I have just one minor questions.
There is some overlap betwe
thanks,
Chris
On 3/12/20 12:06 AM, serguei.spit...@oracle.com
Hi Roman,
Thank you for the update and sorry for the latency in review.
Some comments are below.
http://cr.openjdk.java.net/~rkennke/JDK-8227269/webrev.05/src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c.frames.html
87 cbTrackingObjectF
Sorry, forgot to complete my comments
at the end (see below).
On 3/15/20 23:57, serguei.spit...@oracle.com wrote:
Hi Roman,
Thank you for the update and sorry for the latency in review.
Some comments are below
Hi Daniil,
The update looks pretty good to me so far.
I'll make another pass tomorrow.
Thanks,
Serguei
On 3/13/20 15:05, Daniil Titov wrote:
Hi Yasumasa, Serguei and Alex,
Please review a new version of the webrev that includes the changes Yasumasa
suggested.
Shutdown hook is already regi
PI. What do you think?
The approach to localize canPtraceAttachLinux() in SATestUtils.java
sounds right to me if it is an SA specific API.
Thanks,
Serguei
Chris
On 3/15/20 10:22 PM, serguei.spit...@oracle.com wrote:
0 12:13 PM, Igor Ignatev wrote:
On Mar 16, 2020, at
11:43 AM, "serguei.spit...@oracle.com"
Hi Patricio,
Good finding, thank you for taking care about this!
The fix looks good in general.
There are several spots with the wrong indent (must be 4, not 2):
64 #define ENTER_CONNECTION(connection) do { \
65
Hi Leonid,
It looks good in general.
Just a couple of comments.
http://cr.openjdk.java.net/~lmesnik/8241123/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/share/Wicket.java.frames.html
168 public int waitFor(long timeout) {
169 if (timeou
19, 2020, at 6:03 PM, serguei.spit...@oracle.com
wrote:
Hi Leonid,
It looks good in general.
Just a couple of comments.
http
+1
Thanks,
Serguei
On 3/19/20 13:12, Lois Foltan wrote:
Looks good.
Lois
On 3/19/2020 3:46 PM, coleen.phillim...@oracle.com wrote:
Summary: remove unused code that is changing in Hotspot for hidden
classes.
Ran tier1-3 tests. See bug for more details.
open webrev at
http://cr.openjdk.jav
+1
Thanks,
Serguei
On 3/19/20 20:27, Mikael Vidstedt wrote:
Looks good, thanks for doing this!
Cheers,
Mikael
On Mar 19, 2020, at 8:25 PM, Chris Plummer wrote:
Hello,
Please review the following:
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a
On 3/20/20 04:28, coleen.phillim...@oracle.com wrote:
On 3/19/20 6:43 PM, David Holmes wrote:
Hi Coleen,
On 20/03/2020 5:46 am, coleen.phillim...@oracle.com wrote:
Summary: remove unused code that is changing in Hotspot for hidden
classes.
I'm not sure how to identify unused code in the
Hi Yasumasa,
I looked at you changes.
It is hard to understand if this fully solves the issue.
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.03/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java.frames.html
Hi Patricio,
The update looks good.
Thanks,
Serguei
On 3/18/20 23:18, Patricio Chilano wrote:
Hi
David,
On 3/18/20 8:10 PM, David Holmes
wrote:
Hi
Patricio,
On
Hi Daniil,
It looks Okay in general.
But I've got a question.
329 while (jstatdThread == null) {
330 if (!useDefaultPort) {
331 port = String.valueOf(Utils.getFreePort());
332 }
333
334
situation?
Thanks,
Serguei
Best regards,
Daniil
From: "serguei.spit...@oracle.com"
Date: Monday, March 23, 2020 at 11:45 AM
To: Daniil Titov
, A
aniil
From: "serguei.spit...@oracle.com"
Date: Monday, March 23, 2020 at 12:13 PM
To: Daniil Titov
, Alex Menkov
, serviceability-dev
Subject: Re: 8240711: TestJstatdPort.java failed
eate a new issue for that.
Thanks!
--Daniil
From: "serguei.spit...@oracle.com"
Date: Monday, March 23, 2020 at 12:13 PM
To: Daniil Titov ,
Hi Yasumasa,
The mach5 tier5 testing looks good.
The serviceability/sa/ClhsdbPstack.java
is failed without fix and is not failed with it.
Thanks,
Serguei
On 3/23/20 10:18, serguei.spit...@oracle.com wrote
Hi Daniil,
It looks pretty good in general.
It looks like you removed the last call site of DebugServer.main.
Do we need to remove the DebugServer.java as well?
Thanks,
Serguei
On 3/22/20 15:29, Daniil Titov wrote:
Hi Yasumasa, Serguei and Alex,
Please review a new version of the webrev tha
it to submit repo:
http://hg.openjdk.java.net/jdk/submit/rev/fade6a949bd1
On 2020/03/24 7:39, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The mach5 tier5 testing looks good.
The serviceability/sa/ClhsdbPstack.java is failed without fix and is
not failed with it.
Thanks,
Serguei
On 3/23/20
gent and in JDI.
Chris
But this is not in the scope of this bug.)
Roman
On 3/16/20 8:05 AM, serguei.spit...@oracle.com wrote:
Sorry, forgot to complete my comments at the end (see below).
On 3/15/20 23:57, serguei.spit...@oracle.com wrote:
Hi Roman,
Thank you for the update and sorry for th
On 3/24/20 14:47, Chris Plummer wrote:
On 3/24/20 2:46 PM, serguei.spit...@oracle.com wrote:
On 3/24/20 14:39, Chris Plummer wrote:
On 3/24/20 1:45 PM, Roman Kennke wrote:
I assume JVMTI maintains separate tagging data for each agent so
having
two agents doing tagging won't resu
d.patch
But this is not in the scope of this bug.)
Roman
On 3/16/20 8:05 AM, serguei.spit...@oracle.com wrote:
Sorry, forgot to complete my comments at the end (see below).
On 3/15/20 23:57, serguei.spit...@oracle.com wrote:
Hi Roman,
Thank you for the upda
deprecated first. I also think that it would be better to do in a separate issue
since a CSR for deprecation needs to be filed for that. If you agree I will
create a new issue for that.
I'm okay to separate this.
Thanks,
Serguei
Thanks,
Daniil
On 3/23/20, 11:56 PM, "serguei.spit...@
3:47, Yasumasa Suenaga wrote:
Thanks Serguei!
I will push it when I get second reviewer.
Yasumasa
On 2020/03/25 1:39, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I'm okay with this update.
My mach5 test run for this patch is passed.
Thanks,
Serguei
On 3/23/20 17:08, Yasumasa Suena
why jdb needs to enable class-unload listener
always. A
simple hack disables it, and performance is brilliant, even when
jdb is
attached:
http://cr.openjdk.java.net/~rkennke/disable-jdk-class-unload.patch
But this is not in the scope of this bug.)
Roman
On 3/16/20 8:05 AM, serguei.spit...
Hi Roman,
I'm okay with fix.
Thanks,
Serguei
On 3/26/20 17:15, serguei.spit...@oracle.com wrote:
Hi Roman,
Yes. Thank you for the explanation.
Thanks,
Serguei
On 3/26/20 01:44, Roman Kennke wrote:
That was in the previous implementation: I got a condition wrong in the
table looku
Hi Mandy and Chris,
On 3/29/20 19:17, Mandy Chung wrote:
On 3/27/20 8:51 PM, Chris Plummer wrote:
Hi Mandy,
A couple of very minor nits in the jvmtiRedefineClasses.cpp comments:
153 // classes for primitives, arrays, hidden and vm unsafe
anonymous classes
154 // cannot be redefi
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html
356 void add_classes(LoadedClassInfo* first_class, int num_classes,
bool has_class_mirror_holder) {
3
On 3/30/20 02:30, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have just one comment so far.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03/src/hotspot/share/classfile/classLoaderHierarchyDCmd.cpp.frames.html
356 void add_classes(LoadedClassInfo
Hi Yasumasa,
Yes, this works needs to be done.
I'll take look at you webrev.
Thanks,
Serguei
On 3/31/20 07:41, Daniel D. Daugherty wrote:
Add Robbin to this thread...
This reminded of the following RFE that Robbin filed:
JDK-8201641 JVMTI: GetThreadListStackTraces should use
Thread-Loc
Hi Daniil,
LGTM++
Thanks,
Serguei
On 3/30/20 13:06, Alex Menkov wrote:
Looks good.
--alex
On 03/30/2020 12:43, Daniil Titov wrote:
Please review the change [1] that fixes the failure of
com/sun/jdi/JdwpListenTest.java
and com/sun/jdi/JdwpAttachTest.java tests on OSX 10.15.
The problem he
Hi Egor,
The fix looks good to me.
Thank you for taking care about this optimization!
The call to validateVM() is not really needed
but does not harm as it is an empty method.
I'll sponsor the push for you.
Will submit a ma
Hi Mandy,
Two JDI tests started failing with the update of
src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.java:
vmTestbase/nsk/jdi/ClassUnloadRequest/addClassFilter/filter001/TestDescription.java
vmTestbase/nsk/jdi/ClassUnloadEvent/
Sorry for sending mach5 links to the
open mailing lists, I've removed them below.
Thanks,
serguei
On 4/6/20 09:56, serguei.spit...@oracle.com wrote:
Hi Mandy,
Two JDI tests started failing with the upda
can submit a testing job to make ensure the correctness.
Thanks,
Serguei
On 4/6/20 10:50, Chris Plummer wrote:
Hi Serguei,
This fix looks good.
thanks,
Chris
On 4/6/20 10:05 AM
Vahalla webrev since it has nothing to do with
Vahalla. I'd suggest filing an RFE and pushing it to jdk/jdk.
Easier to track that way if there are issues down the road.
thanks,
Chris
On 4/6/20 10:57 AM, serguei.spit
On 4/6/20 11:54, Mandy Chung wrote:
On 4/6/20 9:56 AM, serguei.spit...@oracle.com wrote:
The suggested fix is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/
This patch looks okay. I'll include in my local patch.
On 4/6/20 11:00 AM, Chris Plummer
Hi Chris,
This looks good.
Thanks,
Serguei
On 4/6/20 17:07, Chris Plummer wrote:
Can I get one more review please?
thanks,
Chris
On 4/3/20 6:56 PM, Chris Plummer wrote:
Here's an updated webrev. I also renamed APP_CLASSNAME to
APP_SLASH_CLASSNAME just to make it a bit more clear which fo
Hi Chris,
Quick question:
Should the
serviceability/sa/LingeredAppSysProps.java be also problem
listed?
Thanks,
Serguei
On 4/5/20 22:49, Chris Plummer wrote:
Hello,
Please help review t
browse/JDK-8242235 first, which gets rid
of the need to problem list on solaris.
Chris
On 4/6/20 6:31 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
Quick question:
Should theserviceability/sa/LingeredAppSysProps.java be also problem
listed?
Thanks,
Serguei
On 4/5/20 22:49, Chris Plummer wro
Hi Chris,
It looks good in general.
But a couple of comments.
http://cr.openjdk.java.net/~cjplummer/8242165/webrev.03/test/hotspot/jtreg/serviceability/sa/TestSysProps.java.html
I'm thinking if it'd make sense to do this kind of refactoring:
OutputAnalyzer runSACommand(String cmd, String a
ists that are not in the output
of LingeredAppSysProps. So at first I was thinking I would need to use
each list as a primary list and have it compare against the other two,
but then I realized I could just use the count of the number of
properties found as a sanity check.
thanks,
Chri
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8242241-jdi-add-assert.1/
Summary:
A useful assert is introduced to check the class
Hi Chris,
It looks good to me.
Thanks,
Serguei
On 4/7/20 20:12, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8240990
http://cr.openjdk.java.net/~cjplummer/8240990/webrev.00
The javascript code was just a few lines like other recent comman
It looks good and trivial.
Thanks,
Serguei
On 4/7/20 21:57, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242265
diff --git a/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.java
b/test/hotspot/jtreg/serviceability/sa/ClhsdbScanOops.
Chris,
Refactored version looks nice.
I was thinking to suggest the same in previous review but decided there
is not a big profit for small blocks of code.
But it is obvious now that it is clearly better. :)
Thanks,
Serguei
On 4/7/20 22:15, Chris Plummer wrote:
Hello,
Please review the fol
This is a one-liner fix. :)
Thanks,
Serguei
On 4/7/20 15:39, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8242241-jdi-add-assert.1/
Summary:
A
Thanks, Chris!
Serguei
On 4/8/20 19:41, Chris Plummer wrote:
LGTM
Chris
On 4/8/20 7:15 PM, serguei.spit...@oracle.com wrote:
This is a one-liner fix. :)
Thanks,
Serguei
On 4/7/20 15:39, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https
,
David
Yasumasa
On 2020/04/01 1:59, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Yes, this works needs to be done.
I'll take look at you webrev.
Thanks,
Serguei
On 3/31/20 07:41, Daniel D. Daugherty wrote:
Add Robbin to this thread...
This reminded of the following RFE that Robbin
ule).
So, the GetCurrentContendedMonitorClosure should work for now.
It is interesting if there will be any other suggestions though.
Thanks,
Serguei
Yasumasa
On 2020/04/09 15:19, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I'm okay with using sub-tasks to do it incrementally.
This
Thanks you, Dan!
Serguei
On 4/9/20 06:34, Daniel D. Daugherty wrote:
On 4/7/20 6:39 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8242241-jdi-add
Hi Yasumasa,
It looks pretty good in general.
A couple of comments though.
http://cr.openjdk.java.net/~ysuenaga/JDK-8242425/webrev.00/src/hotspot/share/prims/jvmtiEnvBase.cpp.frames.html
650 JvmtiEnvBase::get_current_contended_monitor(JavaThread *java_thr
- serviceability/jdwp
Thanks,
Yasumasa
On 2020/04/10 14:50, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It looks pretty good in general.
A couple of comments though
Hi Chris,
LGTM++
Thanks,
Serguei
On 4/13/20 15:33, Alex Menkov wrote:
LGTM
--alex
On 04/13/2020 13:30, Chris Plummer wrote:
Ping!
This one is pretty trivial. You don't really need to know anything
about PMap and PStack to review. It's just cleaning up how they fail
due due not being sup
Hi Magnus,
This looks okay to me unless there is a better solution.
Thanks,
Serguei
On 4/14/20 04:04, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise
Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/14/20 14:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-824161
Thank you for taking care about this,
Magnus!
Serguei
On 4/15/20 00:02, Magnus Ihse Bursie wrote:
On
2020-04-15 02:34, serguei.spit...@oracle.com
wrote:
Hi Magnus,
It looks good to me
Hi Chris,
LGTM++
Thanks,
Serguei
On 4/15/20 13:42, Alex Menkov wrote:
Hi Chris,
The fix looks good.
--alex
On 04/15/2020 10:28, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8230731
http://cr.openjdk.java.net/~cjplummer/8230731/webrev.
Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/15/20 06:00, Magnus Ihse Bursie wrote:
Here is an updated version, that avoids the SuppressWarnings for
modelToView:
http://cr.openjdk.java.net/~ihse/JDK-8242808-fix-all-SA-deprecation/webrev.02
(Only change is in SourceCodePanel.java
Hi Mandy,
I have a couple of minor comments on the Serviceability spec
update.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.06-svc-spec-changes/src/jdk.jdi/share/classes/com/sun/jdi/ReferenceType.java.udiff.html
R
, they are fine on my
Linux x64.
Thanks,
Yasumasa
On 2020/04/10 17:21, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
Thank you for the update.
Minor:
http://cr.openjdk.java.net/~ysuenaga/JDK-8242425/webrev.01/src/hotspot/share/prims/jvmtiEnvBase.cpp.udiff.html
+ err
Okay, thanks.
Non-serviceability changes look good too.
Thanks,
Serguei
On 4/16/20 11:48, Mandy Chung wrote:
On 4/16/20 11:42 AM, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have a
101 - 200 of 2514 matches
Mail list logo
