and
redefinition_count at the same time (making sure to be in the
_thread_in_vm state), then bail out based on the cached value of
is_old.
dl
On 5/26/20 12:04 AM, serguei.spit...@oracle.com wrote:
On 5/25/20 23:39, serguei.spit
Hi Coleen,
Thank you a lot for reviewing this!
On 5/28/20 12:48, coleen.phillim...@oracle.com wrote:
Hi
Serguei,
Sorry for the delay reviewing this again.
On 5/18/20 3:30 AM, serguei.spit...@oracle.com wrote
Hi Alex,
It looks good in general.
+static HRESULT WaitForEvent(IDebugControl *ptrIDebugControl) {
+ // see JDK-8204994: sometimes WaitForEvent fails with E_ACCESSDENIED,
+ // but succeeded on 2nd call.
+ HRESULT hr = ptrIDebugControl->WaitForEvent(DEBUG_WAIT_DEFAUL
hanks,
Serguei
On 5/28/20 14:44, serguei.spit...@oracle.com wrote:
Hi Coleen,
Thank you a lot for reviewing this!
On 5/28/20 12:48, coleen.phillim...@oracle.com wrote:
Hi
Serguei,
Sorry fo
On 5/28/20 17:04, Alex Menkov wrote:
Hi Serguei,
With my testing 2nd call always succeeded, but I was able to reproduce
the case only 3 times with my test runs.
I can implement the loop, but number of retries is anyway an arbitrary
value.
--alex
On 05/28/2020 15:44, serguei.spit...@oracle.com
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in place.
The changes are:
- addressed David's suggestion to rephrase StopThread d
On 5/29/20 00:42, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webrev in place.
The changes are:
- addressed Da
On 5/29/20 00:59, David Holmes wrote:
On 29/05/2020 5:42 pm, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CSR and webr
On 5/29/20 00:56, serguei.spit...@oracle.com wrote:
On 5/29/20 00:42, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this!
On 5/28/20 23:57, David Holmes wrote:
Hi Serguei,
On 28/05/2020 3:12 pm, serguei.spit...@oracle.com wrote:
Hi David,
I've updated the CS
...@oracle.com wrote:
On 5/29/20 00:56,
serguei.spit...@oracle.com wrote:
On 5/29/20 00:42,
serguei.spit...@oracle.com wrote:
Hi David,
Thank you for reviewing this
Hi Alex,
Thank you for the update!
LGTM.
Thanks,
Serguei
On 5/29/20 13:35, Alex Menkov wrote:
Hi Serguei,
ok, I added the loop.
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_WaitForEvent/webrev.2/
--alex
On 05/28/2020 20:35, serguei.spit...@oracle.com wrote:
Hi Alex,
It'
one of the nsk.jdi tests to provide a necessary
test coverage.
Thanks,
Serguei
On 5/26/20 22:58, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8245913
CSR draft (one CSR r
Hi David,
Also jumping to end.
On 5/30/20 06:50, David Holmes wrote:
Hi Serguei,
Jumping to the end for now ...
On 30/05/2020 5:50 am, serguei.spit...@oracle.com wrote:
Hi David and reviewers,
The updated webrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-stop
Please, review a fix for small spec bug:
https://bugs.openjdk.java.net/browse/JDK-8221306
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmt-funcs-cleanup.1/src/
Updated JVM TI spec for the FramePop, MethodEntry and MethodExit events:
y for is_old.
dl
On 5/28/20 7:23 AM, serguei.spit...@oracle.com wrote:
Hi Dean,
Thank you for looking at this!
Okay. Let me check what cab be done in this direction.
There is no point to cache is_old. The compil
On 5/31/20 23:16,
serguei.spit...@oracle.com wrote:
Hi Dean,
To check the is_old as you suggest the target method has to be
passed
to the cache_jvmti_state() as argument. Is it what you are
suggesting?
Just want to
any practical difference in the sense that there may be other (less
convenient but still available) mechanisms to achieve the same goal in
a debugger or agent.
David
On 31/05/2020 5:50 pm, serguei.spit...@oracle.com wrote:
Hi David,
Also jumping to end.
On 5/30/20 06:50, David Holmes wrote
Thanks, Chris!
Serguei
On 6/1/20 11:31, Chris Plummer wrote:
Hi Serguei,
Looks good.
thanks,
Chris
On 5/31/20 1:11 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for small spec bug:
https://bugs.openjdk.java.net/browse/JDK-8221306
Webrev:
http://cr.openjdk.java.net/~sspitsyn
Hi Fairoz,
It looks okay in general.
But I'm not sure this check is going to work.
The problem is the HeapwalkingDebuggee.useStrictCheck
method is invoked in the
context of the HeapwalkingDebugger
process, not the HeapwalkingDebuggee
Hi Daniil,
LGTM.
Thanks,
Serguei
On 5/29/20 16:28, Daniil Titov wrote:
Hi Alex and Serguei,
Please review a new version of the change [1] that makes sure that the test
counts
only the threads it creates and ignores Internal threads VM might create or
destroy.
Testing: Running this test i
On 6/1/20 12:30,
serguei.spit...@oracle.com wrote:
Hi Fairoz,
It looks okay in general.
But I'm not sure this check is going to work.
The problem is the HeapwalkingDebuggee.useStrictCheck
method is invoked i
ome side effects?
Please, let me know what you think.
Thanks,
Serguei
On 6/1/20 15:10, Dean Long wrote:
On
5/31/20 11:16 PM, serguei.spit...@oracle.com
wrote:
Hi Dean,
To check the is_ol
Hi Richard,
This looks good to me.
Thanks,
Serguei
On 5/28/20 09:02, Vladimir Kozlov wrote:
Vladimir Ivanov is on break currently.
It looks good to me.
Thanks,
Vladimir K
On 5/26/20 7:31 AM, Reingruber, Richard wrote:
Hi Vladimir,
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8238585
ld
like to push.
Okay, I'll submit a mach5 job with your fix and let you know about the
results.
Thanks,
Serguei
Thanks, Richard.
-Original Message-
From: serguei.spit...@oracle.com
Sent: Dienstag, 2. Juni 2020 18:55
To: Vladimir Kozlov ; Reingruber, Richard
; ser
Thank you, Alex!
Serguei
On 6/2/20 12:04, Alex Menkov wrote:
+1
--alex
On 06/01/2020 11:31, Chris Plummer wrote:
Hi Serguei,
Looks good.
thanks,
Chris
On 5/31/20 1:11 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for small spec bug:
https://bugs.openjdk.java.net/browse/JDK
Thank you a lot for review, Coleen!
Serguei
On 6/3/20 08:50, coleen.phillim...@oracle.com wrote:
Hi Serguei,
This change looks great. Thank you for fixing this!
Coleen
On 5/28/20 7:16 PM, serguei.spit...@oracle.com
This was seen with the C2:
https://bugs.openjdk.java.net/browse/JDK-8245128
This was seen with the JVMCI:
https://bugs.openjdk.java.net/browse/JDK-8245446
Thanks,
Serguei
On 6/1/20 23:40, serguei.spit...@oracle.com wrote:
Hi David,
The JetBrains confirmed:
Ability to select the exception is a valuable feature they provide.
Throwing only ThreadDeath is almost useless.
So, should I close this and related JDI/JDWP enhancements as WNF?
Thanks,
Serguei
On 6/1/20 08:30, serguei.spit...@oracle.com wrote:
Hi
PING: One more review for this fix is
needed.
Thanks,
Serguei
On 6/3/20 09:52, serguei.spit...@oracle.com wrote:
Thank you a lot for review, Coleen!
Serguei
On 6/3/20 08:50, coleen.phillim
.
Please get another review because this is not a trivial change.
dl
On 6/3/20 10:06 AM, serguei.spit...@oracle.com wrote:
Hi Dean,
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/kitchensink
On 6/3/20 16:10, David Holmes wrote:
Hi Serguei,
On 4/06/2020 6:41 am, serguei.spit...@oracle.com wrote:
Hi David,
The JetBrains confirmed:
Ability to select the exception is a valuable feature they provide.
Throwing only ThreadDeath is almost useless.
So, should I close this and
could run full tier5
now. After that I would
like to push.
Thanks, Richard.
-Original Message-----
From: serguei.spit...@oracle.com
Sent: Dienstag, 2. Juni 2020 18:55
To: Vladimir Kozlov ; Reingruber, Richard
; serviceability-dev@openjdk.java.net;
hotspot-compiler-...@openjdk.java.ne
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8196450
CSR draft (one CSR reviewer is needed before finalizing it):
https://bugs.openjdk.java.net/browse/JDK-8246540
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8245321
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-redef-refact.1/
Summary:
The jvmtiRedefineClasses.cpp functions check_nest_attributes
and
check_pe
Thanks, Harold
On 6/4/2020 3:20 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8245321
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-r
Thank you a lot for review, Coleen!
Serguei
On 6/4/20 11:41, coleen.phillim...@oracle.com wrote:
This
looks good to me also.
Coleen
On 6/4/20 3:20 AM, serguei.spit...@oracle.com wrote:
Please, review a
Hi Daniil,
It is hard to be on top of all the details in these review rounds.
When all threads are counted with mbean.getThreadCount()
it is not clear
there is no race with new non-tested threads creation. Is it
possible?
If so, then the check a
the diff value is
calculated at line 203.
I'm sorry, if the same questions are repeated again.
Thanks,
Serguei
--Best regards,
Daniil
From: "serguei.spit...@oracle.com"
Date: Thursday, June 4, 2020 at 3:03 PM
To: Daniil Titov , Alex Menkov ,
serviceability-dev
Subject: Re:
ested" threads the invariant that
this method tests is that number of threads
mbean.getThreadCount() returns could not be less than number of live test threads,
or that A >= B.
Best regards,
Daniil
On 6/4/20, 4:08 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
Yes, that is right.
Thank you for the comment, David.
Thanks,
Serguei
On 6/4/20 19:46, David Holmes wrote:
Just for the record, this change has been withdrawn and no changes
will be made to JDI or JDWP.
David
On 30/05/2020 8:09 am, serguei.spit...@oracle.com wrote:
Hi David and reviewers
Hi David,
You have already approved the CSR below.
May I count it as a review as there is no difference between CSR
and webrev - both have the same spec update?
Thanks,
Serguei
On 6/3/20 20:57, serguei.spit...@oracle.com
al Message-----
From: serguei.spit...@oracle.com
Sent: Donnerstag, 4. Juni 2020 04:07
To: Reingruber, Richard ;
serviceability-dev@openjdk.java.net; hotspot-compiler-...@openjdk.java.net;
hotspot-runtime-...@openjdk.java.net; hotspot-gc-...@openjdk.java.net
Subject: Re: RFR(S) 8238585: Use han
, serguei.spit...@oracle.com wrote:
Hi David,
You have already approved the CSR below.
May I count it as a review as there is no difference between CSR and
webrev - both have the same spec update?
Thanks,
Serguei
On 6/3/20 20:57, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https
...@oracle.com wrote:
Hi David,
You have already approved the CSR below.
May I count it as a review as there is no difference between CSR and
webrev - both have the same spec update?
Thanks,
Serguei
On 6/3/20 20:57, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https
st regards,
Christian
On 04.06.20 01:05, serguei.spit...@oracle.com wrote:
Hi Dean,
Thank you a lot for the review!
I hope, Christian will have a chance to look at it.
Thanks,
Serguei
On 6/3/20 14:56, Dean Long wrote:
Hi Serguei, I like the latest changes so that JVMCI matches C2.
Please get anot
nsing logic seems to be broken
On 6/1/20 12:30, serguei.spit...@oracle.com
wrote:
Hi Fairoz,
It looks okay in general.
But I'm not sure this check is going to w
Hi Fairoz,
On 6/8/20 02:08, serguei.spit...@oracle.com wrote:
Hi Fairoz,
There are two different isJFRActive() methods, one is on
debuggee side and another on the debugger side.
The one on debuggee side is better to
Hi Fairoz,
LGTM.
Thanks,
Serguei
On 6/8/20 21:20, Fairoz Matte wrote:
Hi Serguei,
Thanks for the clarifications,
I have incorporated the 2nd suggestion, below is the webrev,
http://cr.openjdk.java.net/~fmatte/8243451/webrev.09/
Thanks,
Fairoz
From: Serguei Spitsyn
Sent: Monday, June 8, 202
Hi Poonam,
Thank you for taking care about this!
It looks good besides the comment from Harold and Coleen about
ex_msg can be equal to NULL.
Thanks,
Serguei
On 6/9/20 07:46, Poonam Parhar wrote:
Hello,
Please
Hi Robbin,
Nice catch!
The fix looks good in general.
I'd be nice to add comments to explain why these global refs are created.
Thanks,
Serguei
On 6/9/20 09:15, Robbin Ehn wrote:
Hi all,
If the direct handshake is executed by the target thread, the JNI
local(s) are created in that thread bu
Hi Leonid,
Thank you for taking care about this!
It looks good in general.
However, I think, a similar return is needed in more cases.
One example:
http://cr.openjdk.java.net/~lmesnik/8242891/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/E
On 6/9/20 12:58, Leonid Mesnik wrote:
Hi
On 6/9/20 12:34 PM, serguei.spit...@oracle.com wrote:
Hi Leonid,
Thank you for taking care about this!
It looks good in general.
However, I think, a
Please, review a retroactive CSR for fix
integrated to 14:
https://bugs.openjdk.java.net/browse/JDK-8235360
CSR:
https://bugs.openjdk.java.net/browse/JDK-8246811
Summary:
It is formal public request.
The CSR was alrea
Thanks, David!
Serguei
On 6/9/20 22:29, David Holmes wrote:
Hi Serguei,
I've added my review as well. The request can be Finalized.
Thanks,
David
On 10/06/2020 3:08 pm, serguei.spit...@oracle.com wrote:
Please, review a retroactive CSR for fix integrated to 14:
gee is not "nsk.share.jdi.HeapwalkingDebuggee".
Shouldn't it be placed in HeapWalkingDebugger?
Leonid
On 6/8/20 9:26 PM, serguei.spit...@oracle.com wrote:
Hi Fairoz,
LGTM.
Thanks,
Serguei
On 6/8/20 21:20, Fairoz Matte wrote:
Hi Serguei,
Thanks for the clarifications,
I have incorporated the
ng to work of debugee is not
"nsk.share.jdi.HeapwalkingDebuggee".
Shouldn't it be placed in HeapWalkingDebugger?
Leonid
On 6/8/20 9:26 PM, serguei.spit...@oracle.com wrote:
Hi Fairoz,
LGTM.
Thanks,
Serguei
On 6/8/20 21:20, Fairoz Matte wrote:
Hi Serguei,
Thanks for t
+1
Thanks,
Serguei
On 6/10/20 08:17, Harold Seigel wrote:
+1
Thanks, Harold
On 6/10/2020 10:36 AM, coleen.phillim...@oracle.com wrote:
Looks good to me now.
thanks,
Coleen
On 6/10/20 9:06 AM, Poonam Parhar wrote:
Hello Harold,
Thanks for your review! I fixed the null string issue, and he
Hi Robbin,
I like this variant and it looks good to me.
Thanks,
Serguei
On 6/10/20 06:57, Robbin Ehn wrote:
Hi David and Serguei, (Dan feel free to chime in)
Honestly I think I'd like to see things reverted to the use of
calling_thread as done for the VMOperation previously. We know it is
On 5/28/20 7:16 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
The updated webrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-redef.3/
src/hotspot/share/oops/cpCache.cpp
Hi Jiangli,
I'm sorry for being that late to the party.
I had a problem to follow all the details in this email thread discussion.
It is hard to notice race issues from simple webrev reading.
So, thanks a lot to Ioi and David for catching it.
As I get from the review comments this fix is not mat
d data, sometimes method/class id which are
used my other JVMTI functions.
Leonid
On 6/9/20 6:59 PM, serguei.spit...@oracle.com wrote:
On 6/9/20 12:58, Leonid Mesnik
wrote:
Hi
+1
Thanks,
Serguei
On 6/11/20 17:28, Alex Menkov wrote:
+1
--alex
On 06/11/2020 16:51, David Holmes wrote:
Hi Daniil,
On 12/06/2020 5:56 am, Daniil Titov wrote:
Please review change [1] that fixes an intermittent failure of the
test when it is runs with -Xcomp.
The problem here is that
Hi Leonid,
It looks okay to me.
> I find this whole MBean vs MXBean terminology very confusing.
:)
Me too. :)
For instance, I see some references to MBeanServer (should they
also be replaced with MXBeanServer?):
http:
Thanks, David!
Serguei
On 6/12/20 00:27, David Holmes wrote:
On 12/06/2020 4:02 pm, serguei.spit...@oracle.com wrote:
Hi Leonid,
It looks okay to me.
> I find this whole MBean vs MXBean terminology very confusing. :)
Me too. :)
For instance, I see some references to MBeanServer (sho
Hi Dan and Chris,
Problem-listing it for Xcomp only looks right to me.
Thank you for taking care about it!
Thanks,
Serguei
On 6/12/20 14:20, Chris Plummer wrote:
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty
On 6/12/20 17:22, Daniel D. Daugherty wrote:
Hi Serguei,
Thanks for reviewing! I pushed the changeset just before I took a dinner
break
Great!
so I won't be able to list you as a reviewer.
Not a big deal. :)
Thanks,
Serguei
Dan
On 6/12/20 6:40 PM, serguei.spit...@oracle.com
Hi Chris,
It looks good.
134 if (Assert.ASSERTS_ENABLED) {
135 // The pointer to the HeapBlock that contains this blob is outside of the blob,
136 // but it shouldn't be an error to find a blob based on the pointer to the HeapBlock.
137 // The
Hi Dan, David and Yasumasa,
On 6/16/20 07:39, Daniel D. Daugherty wrote:
On 6/15/20 9:28 PM, David Holmes wrote:
On 16/06/2020 10:57 am, Daniel D. Daugherty wrote:
On 6/15/20 7:19 PM, David Holmes wrote:
On 16/06/2020 8:40 am, Daniel D. Daugherty wrote:
On 6/15/20 6:14 PM, David Holmes wrot
Yes. It seems we have a consensus.
Thank you for taking care about it.
Thanks,
Serguei
On 6/16/20 18:34, David Holmes wrote:
Ok, may I file it to JBS and fix it?
Go for it! :)
Cheers,
David
On 17/06/2020 10:23 am, Yasumasa Suenaga wrote:
On 2020/06/17 8:47, serguei.spit...@oracle.com
,
Yasumasa
On 2020/06/17 14:37, serguei.spit...@oracle.com wrote:
Yes. It seems we have a consensus.
Thank you for taking care about it.
Thanks,
Serguei
On 6/16/20 18:34, David Holmes wrote:
Ok, may I file it to JBS and fix it?
Go for it! :)
Cheers,
David
On 17/06/2020 10:23 am, Yasumasa
,
Yasumasa
On 2020/06/17 14:37, serguei.spit...@oracle.com wrote:
Yes. It seems we have a consensus.
Thank you for taking care about it.
Thanks,
Serguei
On 6/16/20 18:34, David Holmes wrote:
Ok, may I file it to JBS and fix it?
Go for it! :)
Cheers,
David
On 17/06/2020 10:23 am, Yasumasa
Hi Coleen,
Nice simplification!
It looks good to me.
I assume you will run the nsk.jvmti tests.
Thanks,
Serguei
On 6/17/20 14:25, coleen.phillim...@oracle.com wrote:
Summary: Remove JVMTI oops_do calls from JVMTI and GCs
Tested with tier1-3, also built shenandoah to verify shenandoah changes
Thanks,
Yasumasa
On 2020/06/18 0:42, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
+1
Thanks,
Serguei
On 6/18/20 16:16, Mandy Chung wrote:
+1
Mandy
On 6/18/20 4:00 PM, Jonathan Gibbons
wrote:
Please review a trivial fix for an invalid @see tag in
java/lang/ma
6/18/20 17:01, Yasumasa Suenaga wrote:
Thanks Serguei!
I fixed them, and the change works fine on my laptop with
serviceability/jvmti and vmTestbase/nsk/jvmti on Linux x64.
I will push it later.
Yasumasa
On 2020/06/19 6:42, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
This looks good
, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It would be even more safe to run the JDI tests as well.
The ObjectReference owningThread(), waitingThreads() and entryCount()
are based on this JVMTI function.
See:
https://docs.oracle.com/en/java/javase/14/docs/api/jdk.jdi/com/sun/jdi/ObjectReference.html
Hi Jon,
Looks good.
Thanks,
Serguei
On 6/18/20 20:16, Jonathan Gibbons wrote:
resend, with correct subject line
On 6/18/20 8:12 PM, Jonathan Gibbons
wrote:
Please review some ch
Hi Jon,
It looks good.
Thanks,
Serguei
On 6/19/20 21:50, David Holmes wrote:
Looks good.
Thanks,
David
On 20/06/2020 1:08 pm, Jonathan Gibbons wrote:
Please review a couple of minor HTML errors (missing end tags) in a
couple
of classes. These should be the last of the fixes for com.sun.jdi
+1
Thanks,
Serguei
On 6/22/20 19:32, Daniel D. Daugherty wrote:
On
6/22/20 7:55 PM, Jonathan Gibbons wrote:
Please review a small change to fix an unresolved reference
in `@throws IOException`.
Hi Chris,
+if (!env->ExceptionOccurred()) {
env->ThrowNew(ex_cls, "DWARF not found");
+}
Should the !env->ExceptionOccurred() be
replaced with env->ExceptionOccurred()
?
Thanks,
Serguei
On 6/23/
On 6/23/20 14:57,
serguei.spit...@oracle.com wrote:
Hi Chris,
+if (!env->ExceptionOccurred()) {
env->ThrowNew(ex_cls, "DWARF not found");
+}
Should the !env->ExceptionOccurred() be
On 6/23/20 16:00, Chris Plummer wrote:
On 6/23/20 3:01 PM, serguei.spit...@oracle.com wrote:
On 6/23/20 14:57, serguei.spit...@oracle.com wrote:
Hi Chris,
+if (!env->ExceptionOccur
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it):
https://bugs.openjdk.java.net/browse/JDK-8248189
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.1/
The java.lang.instrume
Hi Mandy,
Thank you for looking at this!
On 6/23/20 20:21, Mandy Chung wrote:
Hi Serguei,
I'm glad that you have a patch for this.
On 6/23/20 7:05 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR rev
Thank you a lot, Sundar!
Serguei
On 6/23/20 19:53, sundararajan.athijegannat...@oracle.com wrote:
Looks good
-Sundar
On 24/06/20 7:35 am, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed
Please, hold on.
The fix does not work for a number of the jdk_instrument tests.
Thanks,
Serguei
On 6/23/20 19:05, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it
n of the
Method.setAccessible(boolean flag) api that works for public methods only.
One alternate approach is to relax the current spec to allow premain
methods to be non-public.
Thanks,
Serguei
just a thought
- Larry
On 6/23/20 8:42 PM, serguei.spit...@oracle.com wrote:
Hi Mandy,
Thank y
Hi David,
On 6/23/20 22:50, David Holmes wrote:
Hi Serguei,
On 24/06/2020 3:37 pm, serguei.spit...@oracle.com wrote:
Hi Larry,
Thank you for looking at this!
On 6/23/20 21:32, Laurence Cable wrote:
should we not consider some form of depreciation here, and continue
to support non-public
On 6/23/20 23:33, Alan Bateman wrote:
On 24/06/2020 07:24, serguei.spit...@oracle.com wrote:
:
One approach would be to continue using the setAccessible and add
extra check for non-public premain method.
Something like should probably work:
if (!(Modifier.isPublic(m.getModifiers
On 6/24/20 05:25, David Holmes wrote:
On 24/06/2020 8:14 pm, Alan Bateman wrote:
On 24/06/2020 10:57, David Holmes wrote:
But you are ignoring my next statement. If we remove the
setAccessible(true) then the premain method will not be accessible
as Serguei reported.
Exception in thread "ma
On 6/24/20 12:44, Mandy Chung wrote:
On 6/24/20 12:26 PM, serguei.spit...@oracle.com wrote:
On 6/24/20 05:25, David Holmes wrote:
Ah! The test class SimpleAgent is what is not public. That seems a
bug in the test.
There are many such tests.
We can break some of the existing agents by
ally.
I'll submit a mach5 test jobs to make sure nothing is broken.
Thanks,
Serguei
On 6/24/20 13:07, serguei.spit...@oracle.com wrote:
On
6/24/20 12:44, Mandy Chung wrote:
On 6/24/20 12:26 P
Thanks you for reviewing, Alan!
I'll check if it can be fixed.
Thanks,
Serguei
On 6/25/20 11:07, Alan Bateman wrote:
On 25/06/2020 17:17, serguei.spit...@oracle.com wrote:
New wevrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.2/
One inconsisten
Hi Jc,
It looks good.
Thank you for fixing it!
Thanks,
Serguei
On 6/25/20 11:03, Jean Christophe Beyler wrote:
Hi all!
I hope you are all doing well!
I have a sma
Hi Yasumasa,
I agree with the approach to separate this into different bugs.
At least, it would be nice to separate the stack trace functions.
It will help to better focus on each fix and improve review
quality.
I'd wait for new webrevs from yo
Hi Yasumasa,
I see, some VM_op's also have this check:
1546 ThreadsListHandle tlh;
1547 if (jt != NULL && tlh.includes(jt)
I wonder if it make sense to add as well.
Otherwise, it looks good to me.
Thanks,
Serguei
Hi David,
Thank you for clarification.
Thanks,
Serguei
On 6/26/20 15:50, David Holmes wrote:
Hi Serguei,
On 27/06/2020 2:40 am, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I see, some VM_op's also have this check:
1546 ThreadsListHandle tlh;
1547 if (jt != NULL && tl
On 6/25/20 11:07, Alan Bateman wrote:
On 25/06/2020 17:17, serguei.spit...@oracle.com wrote:
New wevrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.2/
One inconsistency is that it uses getDeclaredMethod to find the 2-arg
premain and getMethod to find the
Hi Chris,
The fix looks good.
I would most likely overlook such a bug with my eyes. :)
Thanks,
Serguei
On 6/26/20 16:03, Chris Plummer wrote:
Hello,
Please help review the following:
http://cr.openjdk.java.net/~cjplummer/7107012/webrev.00/index.html
https://bugs.openjdk.java.net/browse/JDK
i, can I list you as a Reviewer? If so, I will push this change
when I got second reviewer.
Thanks,
Yasumasa
On 2020/06/27 8:51, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for clarification.
Thanks,
Serguei
On 6/26/20 15:50, David Holmes wrote:
Hi Serguei,
On 27/06/2020 2:40
301 - 400 of 2514 matches
Mail list logo
