Re: RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v2]

2023-01-09 Thread Serguei Spitsyn
On Wed, 23 Nov 2022 10:14:23 GMT, Serguei Spitsyn wrote: >> This problem has two sides. >> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents` >> value. >> It caused the native method `notifyJvmtiUnmountBegin()` not called after the >> field `notifyJvmtiEvents` >> value

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v5]

2023-01-09 Thread Chris Plummer
On Mon, 9 Jan 2023 13:25:34 GMT, Yi Yang wrote: >> harmless refactor to share code across different platforms of >> VirtualMachineImpl: >> 1. Shared code to process command response after requesting a command >> execution >> 2. Read functionality in SocketInputStream can be reused > > Yi Yang h

Re: RFR: 8299701: Remove unused GCCause::_wb_conc_mark

2023-01-09 Thread Ivan Walulya
On Sat, 7 Jan 2023 17:41:04 GMT, Kim Barrett wrote: > Please review this change to remove GCCause::_wb_conc_mark and the supporting > implementation. After JDK-8293824 it is no longer used as the cause when > requesting a GC. > > Note: The implementation in ZGC appears to have never been used.

Re: RFR: 8299701: Remove unused GCCause::_wb_conc_mark

2023-01-09 Thread Erik Österlund
On Mon, 9 Jan 2023 14:50:50 GMT, Erik Österlund wrote: >> Please review this change to remove GCCause::_wb_conc_mark and the supporting >> implementation. After JDK-8293824 it is no longer used as the cause when >> requesting a GC. >> >> Note: The implementation in ZGC appears to have never bee

Re: RFR: 8299701: Remove unused GCCause::_wb_conc_mark

2023-01-09 Thread Erik Österlund
On Sat, 7 Jan 2023 17:41:04 GMT, Kim Barrett wrote: > Please review this change to remove GCCause::_wb_conc_mark and the supporting > implementation. After JDK-8293824 it is no longer used as the cause when > requesting a GC. > > Note: The implementation in ZGC appears to have never been used.

RFR: 8299701: Remove unused GCCause::_wb_conc_mark

2023-01-09 Thread Kim Barrett
Please review this change to remove GCCause::_wb_conc_mark and the supporting implementation. After JDK-8293824 it is no longer used as the cause when requesting a GC. Note: The implementation in ZGC appears to have never been used. Prior to JDK-8293824 this cause was only used by a G1-specific

RFR: 8299795: Relativize locals in interpreter frames

2023-01-09 Thread Fredrik Bredberg
Implementation of relativized locals in interpreter frames for x86. x64, aarch64, ppc64le, riscv. Not relativized zero and s390 but done some changes to cope with the changed generic code. Tested tier1-tier8 on supported platforms. The rest was sanity tested using Qemu. - Commit me

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v5]

2023-01-09 Thread Archie L . Cobbs
On Mon, 9 Jan 2023 06:37:22 GMT, David Holmes wrote: > All your new files need a copyright and GPL header. Sorry if I'm being blind but I'm not seeing it. Which file(s) are you referring to? The `@test /nodynamiccopyright/` files don't get one per [this](https://openjdk.org/groups/compiler/te

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v5]

2023-01-09 Thread Yi Yang
> harmless refactor to share code across different platforms of > VirtualMachineImpl: > 1. Shared code to process command response after requesting a command > execution > 2. Read functionality in SocketInputStream can be reused Yi Yang has updated the pull request incrementally with one additio

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v4]

2023-01-09 Thread Andrey Turbanov
On Mon, 9 Jan 2023 03:29:04 GMT, Yi Yang wrote: >> harmless refactor to share code across different platforms of >> VirtualMachineImpl: >> 1. Shared code to process command response after requesting a command >> execution >> 2. Read functionality in SocketInputStream can be reused > > Yi Yang h