On Mon, 9 Jan 2023 13:25:34 GMT, Yi Yang <[email protected]> wrote:
>> harmless refactor to share code across different platforms of
>> VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command
>> execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Update
> src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java
>
> Co-authored-by: Andrey Turbanov <[email protected]>
src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java line 61:
> 59: int pid = Integer.parseInt(vmid);
> 60: if (pid < 1) {
> 61: throw new AttachNotSupportedException("Invalid process
> identifier -1");
Why the change to using -1 instead of `vmid`? It seems presumptuous that it is
-1, and also seems less useful than printing `vmid`.
-------------
PR: https://git.openjdk.org/jdk/pull/11823
